From nobody Wed Feb 11 00:59:28 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 049B4C77B7D for ; Thu, 18 May 2023 07:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbjERH22 (ORCPT ); Thu, 18 May 2023 03:28:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230108AbjERH2G (ORCPT ); Thu, 18 May 2023 03:28:06 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 711D4213A for ; Thu, 18 May 2023 00:28:05 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-965b5f3b9ffso177815466b.0 for ; Thu, 18 May 2023 00:28:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684394884; x=1686986884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fXL5o5qPvph6Jym30uHyOqMAZEOM4W+jtVScVxTiDlk=; b=ryT3oII2qDSHvEnNd8R3Sxowcji9SoTEbJkcGp19IIs+FWqR5+MsE+p0x5qh15PDQd i6kTbi07i9WT+RjRbfYWccwFP297hTr1IW9+vIW4y4ldZsySI2GacVMRsOWHWD8vRcXw fCCnIuBKoI3pQB7+fpAmk5rlAASAmGvL26SC0XR8c6iX5K3N3H6oIawvpL+EHYoS3M5v HIx3FfeqyJLxmgdWEtMNZpAKwrdmlAmTdwGVSFpHRDWy8/1qpho/tf2ePrHktnIReFPK 3viszkD0I3ZkFL5h9H4v05K/ZzLF1WRU3TmaQZb8h16t18DKTxcZ8XTnXie3BvMdrFJf PcHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684394884; x=1686986884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fXL5o5qPvph6Jym30uHyOqMAZEOM4W+jtVScVxTiDlk=; b=lr+UQ7Pl69eovTjKnbMf/15cXcvBURrlAV6UG78n9Swaba5YWF7cvfMzA5QXNmuHg/ 59wpYqCaOGMm82oCOpYc2ybriDulOwE5O/t6V1EMWG71KSv6d8M5RyYwO7qR3vAwXHjH jWtwbORsk8U0BJkMI4paRMNB3qzTuM3vZt66zdmRx5cJwL05HRCTYgggGQxUAnBBz0Do Hu0RMPw9ywYIDCA6Q5op30W9zjKquinOEWrI+j8/nB0q8/K35ngMFshv6TpC5lM8owlK 4JbxKTrZhDrvD1sPJtQtxneLr3/skyKqKwDKDZCJ1VBGnEcrgH9gTYfgUOcRMzFLR0qo 113Q== X-Gm-Message-State: AC+VfDx47ZV41pe3imoujVFBtP7U9v7AIC/GC4jK78KjESsoZh7f3Jsv TEL1QnCe3BY+aj3weu2BhpTT+fliXd37WVZjVrVvJA== X-Google-Smtp-Source: ACHHUZ6jvtLDiIknXfnlrRB0KFzN9p8chuhdTxU60B7h54mon8DHKl9rh8r1GsMm+rETremULB/ksA== X-Received: by 2002:a17:907:3d93:b0:94a:4739:bed9 with SMTP id he19-20020a1709073d9300b0094a4739bed9mr5233414ejc.13.1684394883911; Thu, 18 May 2023 00:28:03 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a2b:c408:5834:f48e]) by smtp.gmail.com with ESMTPSA id g17-20020a17090669d100b00965aee5be9asm594241ejs.170.2023.05.18.00.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 00:28:03 -0700 (PDT) From: Krzysztof Kozlowski To: Oder Chiou , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Pierre-Louis Bossart Subject: [RESEND PATCH 06/12] ASoC: codecs: rt711-sdca: do not store status in state container Date: Thu, 18 May 2023 09:27:47 +0200 Message-Id: <20230518072753.7361-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> References: <20230518072753.7361-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Driver in its update status callback stores Soundwire device status in state container but it never uses it later. Simplify the code a bit. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pierre-Louis Bossart --- sound/soc/codecs/rt711-sdca-sdw.c | 5 +---- sound/soc/codecs/rt711-sdca.h | 1 - 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/rt711-sdca-sdw.c b/sound/soc/codecs/rt711-sdc= a-sdw.c index 51f3335343e0..2c5eb28259dc 100644 --- a/sound/soc/codecs/rt711-sdca-sdw.c +++ b/sound/soc/codecs/rt711-sdca-sdw.c @@ -143,9 +143,6 @@ static int rt711_sdca_update_status(struct sdw_slave *s= lave, { struct rt711_sdca_priv *rt711 =3D dev_get_drvdata(&slave->dev); =20 - /* Update the status */ - rt711->status =3D status; - if (status =3D=3D SDW_SLAVE_UNATTACHED) rt711->hw_init =3D false; =20 @@ -168,7 +165,7 @@ static int rt711_sdca_update_status(struct sdw_slave *s= lave, * Perform initialization only if slave status is present and * hw_init flag is false */ - if (rt711->hw_init || rt711->status !=3D SDW_SLAVE_ATTACHED) + if (rt711->hw_init || status !=3D SDW_SLAVE_ATTACHED) return 0; =20 /* perform I/O transfers required for Slave initialization */ diff --git a/sound/soc/codecs/rt711-sdca.h b/sound/soc/codecs/rt711-sdca.h index 22076f268577..11d421e8ab2b 100644 --- a/sound/soc/codecs/rt711-sdca.h +++ b/sound/soc/codecs/rt711-sdca.h @@ -19,7 +19,6 @@ struct rt711_sdca_priv { struct regmap *regmap, *mbq_regmap; struct snd_soc_component *component; struct sdw_slave *slave; - enum sdw_slave_status status; struct sdw_bus_params params; bool hw_init; bool first_hw_init; --=20 2.34.1