From nobody Fri Sep 20 18:33:20 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 786C9C77B7A for ; Thu, 18 May 2023 04:08:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbjEREIC (ORCPT ); Thu, 18 May 2023 00:08:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229975AbjEREHi (ORCPT ); Thu, 18 May 2023 00:07:38 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C5233590 for ; Wed, 17 May 2023 21:07:37 -0700 (PDT) X-UUID: 83d7aa66f53111ed9cb5633481061a41-20230518 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=xlKKwoSCHB/hWBr95sZMrzCVAZzotOyMBb84BEXYmhQ=; b=BSafWlqaqtfJzTQJG/iaKqokmHk3DKrSKieQPk+J0Il8RqkpsmWeICqTuhovpCcaGv0ZwUC7kYlCzEP9ygDuQUQ3Cic0yZRbTdLgHbB4zG/wIzeZT52aDYXRlEpVsr/gpuxBf8hpoB3lKAUYqYpCe4f3h1hsN5gzLv7Px2TyCfU=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.25,REQID:c770463f-3afd-4e83-b53f-7d39d9f12641,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:d5b0ae3,CLOUDID:921438c1-e32c-4c97-918d-fbb3fc224d4e,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-UUID: 83d7aa66f53111ed9cb5633481061a41-20230518 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 336472801; Thu, 18 May 2023 12:07:33 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 18 May 2023 12:07:32 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 18 May 2023 12:07:31 +0800 From: Sen Chu To: Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno CC: , , , Sen Chu Subject: [PATCH v2] spmi: mediatek: add device id check Date: Thu, 18 May 2023 12:07:29 +0800 Message-ID: <20230518040729.8789-1-sen.chu@mediatek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add device id check for spmi write API. Signed-off-by: Sen Chu Reviewed-by: AngeloGioacchino Del Regno --- Change in v1: Fix: this should be unlikely(sid & ~0xf) [Sen Chu ] --- --- drivers/spmi/spmi-mtk-pmif.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c index b3c991e1ea40..78a96e00ed54 100644 --- a/drivers/spmi/spmi-mtk-pmif.c +++ b/drivers/spmi/spmi-mtk-pmif.c @@ -378,6 +378,12 @@ static int pmif_spmi_write_cmd(struct spmi_controller = *ctrl, u8 opc, u8 sid, int ret; u32 data, cmd; =20 + /* Check for argument validation. */ + if (unlikely(sid & ~0xf)) { + dev_err(&ctrl->dev, "exceed the max slv id\n"); + return -EINVAL; + } + if (len > 4) { dev_err(&ctrl->dev, "pmif supports 1..4 bytes per trans, but:%zu request= ed", len); =20 --=20 2.18.0