From nobody Fri Sep 20 18:42:18 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AA41C77B7D for ; Thu, 18 May 2023 04:07:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbjEREHn (ORCPT ); Thu, 18 May 2023 00:07:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbjEREH2 (ORCPT ); Thu, 18 May 2023 00:07:28 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DFFC3A9F for ; Wed, 17 May 2023 21:06:57 -0700 (PDT) X-UUID: 6afba7fef53111ed9cb5633481061a41-20230518 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=y3Na9qwd7540dOdP5z5gJIwHoh/0qkxTTF1GjdKpjf0=; b=niwCexI6WupKrfdkVkUdmy3Y2dSXkoHYOIOPxrB9pPAmBuqJxlJL7I+PFKr21FcJr/AUnF+jQjTDgxWgVL+rxLySBV52D0/qdAYeUdDAtJ5eUQbhnj5lPes+StFJ1cjKzacobEhLJaGpFaoHtI9SvIf8CXFIT2eQ0yuYC8i3vQo=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.25,REQID:a63f4d3d-5a28-40d4-ad4b-2b2e41a5e5e0,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:100,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:100 X-CID-INFO: VERSION:1.1.25,REQID:a63f4d3d-5a28-40d4-ad4b-2b2e41a5e5e0,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:100,FILE:0,BULK:0,RULE:Spam_GS981B3D,ACTIO N:quarantine,TS:100 X-CID-META: VersionHash:d5b0ae3,CLOUDID:e6c0306c-2f20-4998-991c-3b78627e4938,B ulkID:230518120652UQHM1KDE,BulkQuantity:0,Recheck:0,SF:48|38|29|28|17|19,T C:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 ,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-UUID: 6afba7fef53111ed9cb5633481061a41-20230518 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1478683676; Thu, 18 May 2023 12:06:51 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Thu, 18 May 2023 12:06:50 +0800 Received: from mhfsdcap04.gcn.mediatek.inc (10.17.3.154) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Thu, 18 May 2023 12:06:49 +0800 From: Sen Chu To: Liam Girdwood , Mark Brown , Matthias Brugger , AngeloGioacchino Del Regno CC: , , , Sen Chu Subject: [PATCH v2] regulator: mt6359: add read check for PMIC MT6359 Date: Thu, 18 May 2023 12:06:46 +0800 Message-ID: <20230518040646.8730-1-sen.chu@mediatek.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add hardware version read check for PMIC MT6359 Signed-off-by: Sen Chu Reviewed-by: AngeloGioacchino Del Regno --- Change in v1: Fix: this should be if (ret) [Sen Chu ] --- --- drivers/regulator/mt6359-regulator.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/mt6359-regulator.c b/drivers/regulator/mt635= 9-regulator.c index 1849566784ab..3eb86ec21d08 100644 --- a/drivers/regulator/mt6359-regulator.c +++ b/drivers/regulator/mt6359-regulator.c @@ -951,9 +951,12 @@ static int mt6359_regulator_probe(struct platform_devi= ce *pdev) struct regulator_config config =3D {}; struct regulator_dev *rdev; struct mt6359_regulator_info *mt6359_info; - int i, hw_ver; + int i, hw_ver, ret; + + ret =3D regmap_read(mt6397->regmap, MT6359P_HWCID, &hw_ver); + if (ret) + return ret; =20 - regmap_read(mt6397->regmap, MT6359P_HWCID, &hw_ver); if (hw_ver >=3D MT6359P_CHIP_VER) mt6359_info =3D mt6359p_regulators; else --=20 2.18.0