From nobody Thu Dec 18 08:59:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BACC77B7F for ; Thu, 18 May 2023 01:52:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbjERBwS (ORCPT ); Wed, 17 May 2023 21:52:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjERBwQ (ORCPT ); Wed, 17 May 2023 21:52:16 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C779930CD for ; Wed, 17 May 2023 18:51:50 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-561a80d872dso23176727b3.3 for ; Wed, 17 May 2023 18:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684374708; x=1686966708; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=zXh/O/V/WptHcvZP+JCdTYTDP4LQ9st6a4OKh85bxLg=; b=IfmQuyHqbPtqNnhVieMu9NzCq4te8XLyLb/DhJuRmnprCTKiLUdOcW6g3y2jB1dgkw YFNcIF+OSbv5phj/j2mXjZK1mFlyvAe2aq1crDGN0RreDGx/deLCWh8WLU8nvJ4Gpn0x ochjMURbmABoRK5v6ctPRm/1GCnTeHPXmZ6bpCP4+Il3DO8AmNxg0xbQHm0/ZovoBPe+ pA6kO/hvzAML1E0cPRlo4hwhaSAM0ELQy2CxzL/77SQq/Dko6cvu5yudJ7m4L03nAFUQ dXAFgjMf4adYvGjw99XcYjUepdrxgpym8kGLufrd3hhSNPGeUvt8xanCRGPdyEEyPAFX lNsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684374708; x=1686966708; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zXh/O/V/WptHcvZP+JCdTYTDP4LQ9st6a4OKh85bxLg=; b=eYINyXa/uD+JKQVVCnxLQrZ7n5q6BftxMAxyw4Cfi24KCDTnNBodZFffrD/qr9FrFt 5rQWS/I9P1sVNAZxEoF/0sk6154JXMgNVL42p3daxb9ocy1S8WhnUOpEE6cxExBNo3ev n4JC7RS4FaDdPUjKA+Auf+vxeUDywT2roEL9h5MpqF+bNdIJUZY80BrNSi5zS2e3BqD3 uhH0J1i9slu3B2SHA3HkD7uAKpO4rD3pAY3StS+af8c0o1NdnVgDOxWslnmBzDAFmwan c6YUSn3sg9XC390gOA5VNO6+cdy+N18UJJC4dFQCkbLXrZxTeMajKvSO9NZbjpCoGT4l EuuA== X-Gm-Message-State: AC+VfDwZIzc23J3TGpyHWoc1K3ZmpNJB8RNWRX1bYoD0vh6pMu4hXzbS FO2KhgiwboDZc7L5onZlolZtjebMr/U= X-Google-Smtp-Source: ACHHUZ5YR3a7R9JsHjBo5Xw0oxDMRKd1Rw9K1kdyGq6xvpeMZdMrKgm1WLSCiFPT5VQPXfLP5Z5nDA2kPAA= X-Received: from pandoh.svl.corp.google.com ([2620:15c:2c5:11:2f7e:7405:7496:cdec]) (user=pandoh job=sendgmr) by 2002:a0d:ec09:0:b0:54c:2409:c306 with SMTP id q9-20020a0dec09000000b0054c2409c306mr93492ywn.6.1684374708680; Wed, 17 May 2023 18:51:48 -0700 (PDT) Date: Wed, 17 May 2023 18:50:54 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog Message-ID: <20230518015054.2223833-1-pandoh@google.com> Subject: [PATCH RESEND] iommu/amd: Fix domain flush size when syncing iotlb From: Jon Pan-Doh To: Joerg Roedel , Suravee Suthikulpanit Cc: Will Deacon , Robin Murphy , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Jon Pan-Doh , stable@vger.kernel.org, Gary Zibrat , Sudheer Dantuluri , Nadav Amit , Vasant Hegde Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When running on an AMD vIOMMU, we observed multiple invalidations (of decreasing power of 2 aligned sizes) when unmapping a single page. Domain flush takes gather bounds (end-start) as size param. However, gather->end is defined as the last inclusive address (start + size - 1). This leads to an off by 1 error. With this patch, verified that 1 invalidation occurs when unmapping a single page. Fixes: a270be1b3fdf ("iommu/amd: Use only natural aligned flushes in a VM") Cc: # 5.15.x Suggested-by: Gary Zibrat Tested-by: Sudheer Dantuluri Acked-by: Nadav Amit Reviewed-by: Vasant Hegde Signed-off-by: Jon Pan-Doh Reviewed-by: Jerry Snitselaar lock, flags); - domain_flush_pages(dom, gather->start, gather->end - gather->start, 1); + domain_flush_pages(dom, gather->start, gather->end - gather->start + 1, 1= ); amd_iommu_domain_flush_complete(dom); spin_unlock_irqrestore(&dom->lock, flags); } --=20 2.40.0.634.g4ca3ef3211-goog