From nobody Mon Feb 9 03:31:26 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB3E2C77B75 for ; Wed, 17 May 2023 12:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231818AbjEQMxL (ORCPT ); Wed, 17 May 2023 08:53:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231789AbjEQMxI (ORCPT ); Wed, 17 May 2023 08:53:08 -0400 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A62272D68 for ; Wed, 17 May 2023 05:53:07 -0700 (PDT) Received: from vefanov-Precision-3650-Tower.intra.ispras.ru (unknown [10.10.2.69]) by mail.ispras.ru (Postfix) with ESMTPSA id E979144C1013; Wed, 17 May 2023 12:53:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru E979144C1013 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1684327986; bh=KFaX/2tqEHJVLG8kfiqijrjpzQ1dulXoIoRl1Nm6ws4=; h=From:To:Cc:Subject:Date:From; b=ZG1fdJH2oBF1CHR2wwa1NllsEyhlC/jOhH8h9ubTvPRpSNyDlOduUsGvINvz6FN1w /l4EkLGy8uUj43MBmgeHPNizD5r053D/05CVV1ry6yX36RdHHsGTrkcWp5TsTzZW3F pAQfrN2BdL/5S2rfItpWx9Lpt5lHQW8aGQZ5s7Oc= From: Vladislav Efanov To: Luben Tuikov Cc: Vladislav Efanov , David Airlie , Daniel Vetter , =?UTF-8?q?Christian=20K=C3=B6nig?= , Andrey Grodzovsky , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] drm/sched: Remove redundant check Date: Wed, 17 May 2023 15:52:47 +0300 Message-Id: <20230517125247.434103-1-VEfanov@ispras.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The rq pointer points inside the drm_gpu_scheduler structure. Thus it can't be NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: c61cdbdbffc1 ("drm/scheduler: Fix hang when sched_entity released") Signed-off-by: Vladislav Efanov Reviewed-by: Luben Tuikov --- drivers/gpu/drm/scheduler/sched_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/sched= uler/sched_main.c index 8c183639603e..aea5a90ff98b 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -1141,9 +1141,6 @@ void drm_sched_fini(struct drm_gpu_scheduler *sched) for (i =3D DRM_SCHED_PRIORITY_COUNT - 1; i >=3D DRM_SCHED_PRIORITY_MIN; i= --) { struct drm_sched_rq *rq =3D &sched->sched_rq[i]; =20 - if (!rq) - continue; - spin_lock(&rq->lock); list_for_each_entry(s_entity, &rq->entities, list) /* --=20 2.34.1