From nobody Sat Feb 7 15:12:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F02C77B7A for ; Tue, 16 May 2023 16:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230070AbjEPQ01 (ORCPT ); Tue, 16 May 2023 12:26:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbjEPQ0Y (ORCPT ); Tue, 16 May 2023 12:26:24 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6D9A1FD8 for ; Tue, 16 May 2023 09:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684254285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=a3FIsBwvLJd8bGvVv7dnr0FhAmLIXHj6zTtEadqChU4=; b=ESy4CMLQ4vc9r3t4fhjdjc4GqngI/20bXEBcVN2mIK/xG+SezrqQvhRKTl01PzHy+GV4VE xnnMGMX2I/i+5+fpVVb9BZzEZfeZ8/le1Yt+tGJu4OUTNjjR+U0TTbKYmW1E+aegkGDy62 Lp3zvp9biavgNeKQ79E87oV+gzImVEo= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-2SbFuMN8NBa2JKDDVivjfw-1; Tue, 16 May 2023 12:24:44 -0400 X-MC-Unique: 2SbFuMN8NBa2JKDDVivjfw-1 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-506a7b4f141so15845099a12.2 for ; Tue, 16 May 2023 09:24:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684254283; x=1686846283; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a3FIsBwvLJd8bGvVv7dnr0FhAmLIXHj6zTtEadqChU4=; b=RG1ViOVP+hsVm1IcX8eXCixEmTwEoFBKYDdM2XieJM+5TaTq2PTaTlcWngUpGgvktR cQ/atGGgPGJGYK9ZorTSrArRhYjBXs6Go7J66Ikbj7OxsURY93kbPzkUyDePLKrh01E4 rZe9SOEmuAUDei7i8eJmoP6fHoqKnCu4i0RANeqdRlYfycAir9KOdYZT5HvlpQ2yUPp2 JTo4Nn7YNX2YwWStZsYfnQ/CQN6n6YsMcZglok+pl4uWtCy84SI6ym5V469rMTFsau8v zGcMoaEboCw0HTSWjz79alRgcOQG2qEbe/BRzqgMnH70LKGvw22h7kZCLAs5vamW81xN VSIA== X-Gm-Message-State: AC+VfDzktbquG3ptwYp1ZV7SRapVwYcXRXlqrGJhVIzfGub/65omowdM ZQnrgOOZ3SAIpZ7qcMdLUAR3v9NeEOdwJpkoeCQ6WdcFHKEGHPVEya6tY9F0U0wNW9FovCEci/R ssdNlFFjCJvVeFVMThU8HPB7X X-Received: by 2002:a17:907:ea1:b0:96a:7cc9:d038 with SMTP id ho33-20020a1709070ea100b0096a7cc9d038mr20985625ejc.37.1684254283176; Tue, 16 May 2023 09:24:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5VJEFkuiXqs1L2y9Byop/2x0Fk2/VbMoPdJeW2FbwCObi+PgEHAQ+KfKHQZOE6KJh5Qxl6Ww== X-Received: by 2002:a17:907:ea1:b0:96a:7cc9:d038 with SMTP id ho33-20020a1709070ea100b0096a7cc9d038mr20985598ejc.37.1684254282819; Tue, 16 May 2023 09:24:42 -0700 (PDT) Received: from fedora.redhat.com ([2a06:c701:476e:4300:fe29:2a5c:9188:df81]) by smtp.gmail.com with ESMTPSA id ks16-20020a170906f85000b00947740a4373sm10953098ejb.81.2023.05.16.09.24.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 09:24:41 -0700 (PDT) From: Dana Elfassy X-Google-Original-From: Dana Elfassy To: eballetb@redhat.com, dmitry.torokhov@gmail.com, javierm@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Dana Elfassy Subject: [PATCH] Input: tests: add test to cover all input_grab_device() function Date: Tue, 16 May 2023 19:24:12 +0300 Message-Id: <20230516162412.461066-1-dangel101@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently input_grab_device() isn't covered by any tests Thus, adding a test to cover the cases: 1. The device is grabbed successfully 2. Trying to grab a device that is already grabbed by another input handle Signed-off-by: Dana Elfassy Reviewed-by: Javier Martinez Canillas Tested-by: Javier Martinez Canillas --- drivers/input/tests/input_test.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/drivers/input/tests/input_test.c b/drivers/input/tests/input_t= est.c index 25bbf51b5c87..cd4db365e9fa 100644 --- a/drivers/input/tests/input_test.c +++ b/drivers/input/tests/input_test.c @@ -124,10 +124,38 @@ static void input_test_match_device_id(struct kunit *= test) KUNIT_ASSERT_FALSE(test, input_match_device_id(input_dev, &id)); } =20 + +static void input_test_grab(struct kunit *test) +{ + struct input_dev *input_dev =3D test->priv; + struct input_handle test_handle; + struct input_handler handler; + struct input_handle handle; + struct input_device_id id; + int res; + + handler.name =3D "handler"; + handler.id_table =3D &id; + + handle.dev =3D input_get_device(input_dev); + handle.name =3D dev_name(&input_dev->dev); + handle.handler =3D &handler; + res =3D input_grab_device(&handle); + KUNIT_ASSERT_TRUE(test, input_grab_device(&handle)); + + test_handle.dev =3D input_get_device(input_dev); + test_handle.name =3D dev_name(&input_dev->dev); + test_handle.handler =3D &handler; + + res =3D input_grab_device(&test_handle); + KUNIT_ASSERT_EQ(test, res, -EBUSY); +} + static struct kunit_case input_tests[] =3D { KUNIT_CASE(input_test_polling), KUNIT_CASE(input_test_timestamp), KUNIT_CASE(input_test_match_device_id), + KUNIT_CASE(input_test_grab), { /* sentinel */ } }; =20 --=20 2.40.1