From nobody Mon Feb 9 19:05:23 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED596C77B7D for ; Mon, 15 May 2023 06:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240328AbjEOGyN (ORCPT ); Mon, 15 May 2023 02:54:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240483AbjEOGxV (ORCPT ); Mon, 15 May 2023 02:53:21 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83E3C199F for ; Sun, 14 May 2023 23:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684133573; x=1715669573; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7HU4GkkFBUz3CDwO3kK4aBa3k7/H20TmG32LVN6IOSQ=; b=edVJDUa+ozApmZ2dERc0R4BRi5Dt1XdVlwX2sVzxniuvnZxz22mHFQcR eaO+BQo8T0SvTULrLvUdwTGM/R5bKDmVYXC31uUgLZ3bcf46rsHw/ngBx 0txhXo39e4JKwuZSfoNGr5sIxS3Zl37a52VTwUbxVCYnmX4DF/dEqKPsj TujTdq4fzbyhqlAbGmEF653wdhmEM05Vm/TDL+McVVefmKXPypHNHnDip hTARD7cd1QXtgQaePgxc3PIQSNvJ5zUCSSIt0qcIh8UhiobPKSb2MmG2U qUC5zYjLNheuMWrkyUxlKYEwKcPESDu8TJRIyqp/rTV1fV+XcBErNFL5p A==; X-IronPort-AV: E=McAfee;i="6600,9927,10710"; a="349966573" X-IronPort-AV: E=Sophos;i="5.99,275,1677571200"; d="scan'208";a="349966573" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2023 23:51:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10710"; a="694908802" X-IronPort-AV: E=Sophos;i="5.99,275,1677571200"; d="scan'208";a="694908802" Received: from bard-ubuntu.sh.intel.com ([10.239.185.57]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2023 23:51:18 -0700 From: Bard Liao To: alsa-devel@alsa-project.org, vkoul@kernel.org, broonie@kernel.org, tiwai@suse.de Cc: linux-kernel@vger.kernel.org, vinod.koul@linaro.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com Subject: [PATCH v2 25/26] soundwire: intel: remove .free callback implementation Date: Mon, 15 May 2023 15:10:41 +0800 Message-Id: <20230515071042.2038-26-yung-chuan.liao@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230515071042.2038-1-yung-chuan.liao@linux.intel.com> References: <20230515071042.2038-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Pierre-Louis Bossart The interface is not needed for IPC3 solution but will be needed with an updated parameter list for ACE2.x+IPC4 combinations. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Rander Wang Reviewed-by: Ranjani Sridharan Signed-off-by: Bard Liao --- drivers/soundwire/intel.c | 37 +------------------------------------ 1 file changed, 1 insertion(+), 36 deletions(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 15cecd2e062d..f52167aa48db 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -663,25 +663,6 @@ static int intel_params_stream(struct sdw_intel *sdw, return -EIO; } =20 -static int intel_free_stream(struct sdw_intel *sdw, - int stream, - struct snd_soc_dai *dai, - int link_id) -{ - struct sdw_intel_link_res *res =3D sdw->link_res; - struct sdw_intel_stream_free_data free_data; - - free_data.stream =3D stream; /* direction */ - free_data.dai =3D dai; - free_data.link_id =3D link_id; - - if (res->ops && res->ops->free_stream && res->dev) - return res->ops->free_stream(res->dev, - &free_data); - - return 0; -} - /* * DAI routines */ @@ -817,7 +798,6 @@ static int intel_hw_free(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) { struct sdw_cdns *cdns =3D snd_soc_dai_get_drvdata(dai); - struct sdw_intel *sdw =3D cdns_to_intel(cdns); struct sdw_cdns_dai_runtime *dai_runtime; int ret; =20 @@ -838,12 +818,6 @@ intel_hw_free(struct snd_pcm_substream *substream, str= uct snd_soc_dai *dai) return ret; } =20 - ret =3D intel_free_stream(sdw, substream->stream, dai, sdw->instance); - if (ret < 0) { - dev_err(dai->dev, "intel_free_stream: failed %d\n", ret); - return ret; - } - dai_runtime->pdi =3D NULL; =20 return 0; @@ -871,7 +845,6 @@ static void *intel_get_sdw_stream(struct snd_soc_dai *d= ai, static int intel_trigger(struct snd_pcm_substream *substream, int cmd, str= uct snd_soc_dai *dai) { struct sdw_cdns *cdns =3D snd_soc_dai_get_drvdata(dai); - struct sdw_intel *sdw =3D cdns_to_intel(cdns); struct sdw_cdns_dai_runtime *dai_runtime; int ret =3D 0; =20 @@ -894,7 +867,6 @@ static int intel_trigger(struct snd_pcm_substream *subs= tream, int cmd, struct sn =20 dai_runtime->suspended =3D true; =20 - ret =3D intel_free_stream(sdw, substream->stream, dai, sdw->instance); break; =20 case SNDRV_PCM_TRIGGER_PAUSE_PUSH: @@ -940,9 +912,7 @@ static int intel_component_dais_suspend(struct snd_soc_= component *component) */ for_each_component_dais(component, dai) { struct sdw_cdns *cdns =3D snd_soc_dai_get_drvdata(dai); - struct sdw_intel *sdw =3D cdns_to_intel(cdns); struct sdw_cdns_dai_runtime *dai_runtime; - int ret; =20 dai_runtime =3D cdns->dai_runtime_array[dai->id]; =20 @@ -952,13 +922,8 @@ static int intel_component_dais_suspend(struct snd_soc= _component *component) if (dai_runtime->suspended) continue; =20 - if (dai_runtime->paused) { + if (dai_runtime->paused) dai_runtime->suspended =3D true; - - ret =3D intel_free_stream(sdw, dai_runtime->direction, dai, sdw->instan= ce); - if (ret < 0) - return ret; - } } =20 return 0; --=20 2.25.1