From nobody Mon Feb 9 21:37:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E90C77B7D for ; Mon, 15 May 2023 06:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239049AbjEOGxe (ORCPT ); Mon, 15 May 2023 02:53:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240332AbjEOGxF (ORCPT ); Mon, 15 May 2023 02:53:05 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75FDDC2 for ; Sun, 14 May 2023 23:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684133554; x=1715669554; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=P4I4WMgNIQxYQ334Q+vWNS1kymuWnkPuLaU0h554R2Q=; b=aDZrahoO9qnOb+BaXAlTuzRLwfI0qVsAhDMdk3DOkMQ+zWXbiHXcvsQq M0UjSt5pC86fuXEOMggx53gb6Pk4EgpRM78Zj1b44M4yxoOG/hPurNwuf GqA5cKqbQZkktwl0ErBMj1nfwACrJtpPOzC/EdjICw7DB2mw0/NZzWTBD spg1CRZ5/jUEOuJd8anikyLzCPNlQ8CFlFywLdxfOwdUMmxt17EB9VgVR QRF+zHVySEFIL4f2/zX4z++rHar90OC1zQ/AiM+8SfVX0a+VDMD/AdqcU pwvvrBl1T1K5c4blIW3gmZsNvWnVruq43WKcypxOUPKQbNtJmbfTEZcez Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10710"; a="349966555" X-IronPort-AV: E=Sophos;i="5.99,275,1677571200"; d="scan'208";a="349966555" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2023 23:51:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10710"; a="694908791" X-IronPort-AV: E=Sophos;i="5.99,275,1677571200"; d="scan'208";a="694908791" Received: from bard-ubuntu.sh.intel.com ([10.239.185.57]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2023 23:51:13 -0700 From: Bard Liao To: alsa-devel@alsa-project.org, vkoul@kernel.org, broonie@kernel.org, tiwai@suse.de Cc: linux-kernel@vger.kernel.org, vinod.koul@linaro.org, pierre-louis.bossart@linux.intel.com, bard.liao@intel.com Subject: [PATCH v2 23/26] soundwire: intel: remove .trigger callback implementation Date: Mon, 15 May 2023 15:10:39 +0800 Message-Id: <20230515071042.2038-24-yung-chuan.liao@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230515071042.2038-1-yung-chuan.liao@linux.intel.com> References: <20230515071042.2038-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Pierre-Louis Bossart The interface is not needed for IPC3 solutions but will be needed with an updated parameter list for ACE2.x+IPC4 combinations. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Rander Wang Reviewed-by: Ranjani Sridharan Signed-off-by: Bard Liao --- drivers/soundwire/intel.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index c8eb1ec512c4..15cecd2e062d 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -872,18 +872,9 @@ static int intel_trigger(struct snd_pcm_substream *sub= stream, int cmd, struct sn { struct sdw_cdns *cdns =3D snd_soc_dai_get_drvdata(dai); struct sdw_intel *sdw =3D cdns_to_intel(cdns); - struct sdw_intel_link_res *res =3D sdw->link_res; struct sdw_cdns_dai_runtime *dai_runtime; int ret =3D 0; =20 - /* - * The .trigger callback is used to send required IPC to audio - * firmware. The .free_stream callback will still be called - * by intel_free_stream() in the TRIGGER_SUSPEND case. - */ - if (res->ops && res->ops->trigger) - res->ops->trigger(dai, cmd, substream->stream); - dai_runtime =3D cdns->dai_runtime_array[dai->id]; if (!dai_runtime) { dev_err(dai->dev, "failed to get dai runtime in %s\n", --=20 2.25.1