From nobody Sun Feb 8 21:29:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5403C7EE26 for ; Sun, 14 May 2023 10:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237411AbjENKhT (ORCPT ); Sun, 14 May 2023 06:37:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231127AbjENKhM (ORCPT ); Sun, 14 May 2023 06:37:12 -0400 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [IPv6:2001:67c:2050:0:465::102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3A051FC1 for ; Sun, 14 May 2023 03:37:04 -0700 (PDT) Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4QJzT92d2Nz9sks; Sun, 14 May 2023 12:37:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mariushoch.de; s=MBO0001; t=1684060621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z5ukRjO1JmPw5Mmn3xKNIs5VdxgNV3ShpZVHdaDxMdA=; b=0RWqoP3iZXKNPXKJxL5pZ+bdMLwJK7oLG/iKO1JeS08rRgXk7TjFfoRicvohZe4L90fgus 1xbkbWOjNKq4Sh7hCBJDX9pO+wOHmud6Qeu/p/zDujds8AkqTSwy/pgPlF4Y8qNP8vFVuz epZ8LgAC/SRyrirbZdXAYwnitWMtpGD4FFyhlWovHGH9caTFTkzTpsbFxoJBLpW9JWjGgr cDv8fSkcKxLT+fUWj+RAOHFiS4LysoMRfU4wtBxapZp5LRFBvmlYtaSC0nOlL4yOATBBi+ imZS+vBjgkquClxahQFi9cZIY516T+wpUO39/zAD5tZLVB6bRUu1rs8R8CoB9w== From: Marius Hoch To: Jean Delvare , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marius Hoch Subject: [PATCH 1/2] i2c: i801: Force no IRQ for Dell Latitude E7450 Date: Sun, 14 May 2023 12:36:33 +0200 Message-Id: <20230514103634.235917-2-mail@mariushoch.de> In-Reply-To: <20230514103634.235917-1-mail@mariushoch.de> References: <20230514103634.235917-1-mail@mariushoch.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4QJzT92d2Nz9sks Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The Dell Latitude E7450 uses IRQ 18 for the accelerometer, but also claims that the SMBus uses IRQ 18. This will result in: i801_smbus 0000:00:1f.3: PCI INT C: failed to register GSI i801_smbus 0000:00:1f.3: Failed to enable SMBus PCI device (-16) i801_smbus: probe of 0000:00:1f.3 failed with error -16 Force the SMBus IRQ to IRQ_NOTCONNECTED in this case, so that we fall back to polling, which also seems to be what the (very dated) Windows 7 drivers on the Dell Latitude E7450 do. This was tested on Dell Latitude E7450. Signed-off-by: Marius Hoch --- drivers/i2c/busses/i2c-i801.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index ac5326747c51..5fd2ac585160 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -1624,6 +1624,20 @@ static void i801_setup_hstcfg(struct i801_priv *priv) pci_write_config_byte(priv->pci_dev, SMBHSTCFG, hstcfg); } =20 +/** + * These DELL devices claim an IRQ for the SMBus (usually 18), but we can'= t use + * it, as its actually for the I2C accelerometer. + */ +static const struct dmi_system_id dmi_force_no_irq[] =3D { + { + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E7450"), + }, + }, + {} /* Terminating entry */ +}; + static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) { int err, i; @@ -1657,6 +1671,12 @@ static int i801_probe(struct pci_dev *dev, const str= uct pci_device_id *id) if (!(priv->features & FEATURE_BLOCK_BUFFER)) priv->features &=3D ~FEATURE_BLOCK_PROC; =20 + if (dmi_check_system(dmi_force_no_irq)) { + /* Force no IRQ for these devices, otherwise pcim_enable_device will fai= l */ + dev->irq =3D IRQ_NOTCONNECTED; + dev->irq_managed =3D 1; + } + err =3D pcim_enable_device(dev); if (err) { dev_err(&dev->dev, "Failed to enable SMBus PCI device (%d)\n", --=20 2.40.1 From nobody Sun Feb 8 21:29:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 222A2C77B7D for ; Sun, 14 May 2023 10:37:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237472AbjENKhX (ORCPT ); Sun, 14 May 2023 06:37:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237326AbjENKhO (ORCPT ); Sun, 14 May 2023 06:37:14 -0400 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [IPv6:2001:67c:2050:0:465::102]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAB341FC2 for ; Sun, 14 May 2023 03:37:06 -0700 (PDT) Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4QJzTC4F5Mz9slQ; Sun, 14 May 2023 12:37:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mariushoch.de; s=MBO0001; t=1684060623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+pNLEM67C7eGHuRPLnaCaZVb0MEuWPzCgH5AM/sZq6w=; b=yYwaHwtIywaJslI5D3mZuTVRHklOC6qNi1QoqnSqZEBIia/v5EIfsAheqZSdVzkuPntvXt ygrwWmQlITxxYcOc5w2irzLBff3wQ1hMJ7Xvd41Wei79Dxl6oFhP7JN+i+bQXTK2GUZs9Y MwcOmkKhbdfCEegH6/pOQnLXRELI9+TBW5KxBIVnkotKbGMqCjvOyq1Ov1x19qSNwqy3+P ERCrTLyJwdxiuJue31t/1JcpzJpYsbx31+V2EmpjYwVM1DJorNZejmlVhky1od0kZI90my LukX1nOwhjr8R7t4h4ZWOgU03b1g/T32CL+hFcUuoFk46vKQ+jNF0NnwoHcmpw== From: Marius Hoch To: Jean Delvare , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marius Hoch Subject: [PATCH 2/2] i2c: i801: Force no IRQ for further Dell Latitudes Date: Sun, 14 May 2023 12:36:34 +0200 Message-Id: <20230514103634.235917-3-mail@mariushoch.de> In-Reply-To: <20230514103634.235917-1-mail@mariushoch.de> References: <20230514103634.235917-1-mail@mariushoch.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4QJzTC4F5Mz9slQ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Per the referred bug reports, there are further Dell Latitude devices affected by the same bug, so also handle these. Signed-off-by: Marius Hoch --- drivers/i2c/busses/i2c-i801.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c index 5fd2ac585160..2e13fd04a6ab 100644 --- a/drivers/i2c/busses/i2c-i801.c +++ b/drivers/i2c/busses/i2c-i801.c @@ -1635,6 +1635,20 @@ static const struct dmi_system_id dmi_force_no_irq[]= =3D { DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E7450"), }, }, + /* Per https://bugzilla.redhat.com/show_bug.cgi?id=3D1415950 */ + { + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E5450"), + }, + }, + /* Per https://bugzilla.kernel.org/show_bug.cgi?id=3D194141 */ + { + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E5550"), + }, + }, {} /* Terminating entry */ }; =20 --=20 2.40.1