From nobody Mon Feb 9 05:41:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E9DC77B7D for ; Sat, 13 May 2023 06:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232164AbjEMF6O (ORCPT ); Sat, 13 May 2023 01:58:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbjEMF6M (ORCPT ); Sat, 13 May 2023 01:58:12 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 310C81703 for ; Fri, 12 May 2023 22:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:In-Reply-To:References; bh=JwvBlXffIR0HVqcitR36C1vwkyoUehqX0Gm5NBSTvZk=; b=I+iRnGYIbH0GzESG0nV955gJUa 0UPKyS/3Qb6BMiTbeTDcCOdZb6t8rJdRYDvFibJjoDDonE/XO1JsdC8BigzdBGV+1XQMUYDN1ilsi 2qw908Jr765lQtgmh5i9NvGx2y5UGEEwdrKcPepoeExmP11o8zlVXSnrdSKTayT6U0WY1jh2L3C84 iq+q935gdVdCRN32X0qWWlqn7dccEOqU7m5spB1uEBTo/W5Ex55QgNHeczWkLIWDJ/dzesIGwJC+e MXjwSqBFH7N3PX1PvB7OfzjFl6o0hdZ5MHH8iQ1uwmBd+xoc3IVTY3k3bmtWWX+ipK5kjLC1CrsKl tUnFsPRQ==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pxiGc-00DlRD-1n; Sat, 13 May 2023 05:58:06 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Michael Ellerman , Nicholas Piggin , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, Arnd Bergmann , =?UTF-8?q?Pali=20Roh=C3=A1r?= Subject: [RFC PATCH] powerpc: udbg: export udbg_putc Date: Fri, 12 May 2023 22:58:04 -0700 Message-Id: <20230513055804.23775-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In a randconfig with CONFIG_SERIAL_CPM=3Dm and CONFIG_PPC_EARLY_DEBUG_CPM=3Dy, there is a build error: ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undef= ined! The build can be fixed by exporting "udbg_putc" in udbg.c. OTOH, maybe something like this is more appropriate in arch/powerpc/Kconfig.debug? config PPC_EARLY_DEBUG_CPM bool "Early serial debugging for Freescale CPM-based serial ports" - depends on SERIAL_CPM + depends on SERIAL_CPM=3Dy Signed-off-by: Randy Dunlap Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org Cc: Arnd Bergmann Cc: "Pali Roh=C3=A1r" --- arch/powerpc/kernel/udbg.c | 1 + 1 file changed, 1 insertion(+) diff -- a/arch/powerpc/kernel/udbg.c b/arch/powerpc/kernel/udbg.c --- a/arch/powerpc/kernel/udbg.c +++ b/arch/powerpc/kernel/udbg.c @@ -14,6 +14,7 @@ #include =20 void (*udbg_putc)(char c); +EXPORT_SYMBOL(udbg_putc); void (*udbg_flush)(void); int (*udbg_getc)(void); int (*udbg_getc_poll)(void);