From nobody Wed Feb 11 10:52:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C01C1C77B7D for ; Wed, 10 May 2023 07:29:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236227AbjEJH3m (ORCPT ); Wed, 10 May 2023 03:29:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236019AbjEJH3U (ORCPT ); Wed, 10 May 2023 03:29:20 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0439F76B7 for ; Wed, 10 May 2023 00:28:52 -0700 (PDT) From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1683703720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K9e5Gmxnr1gXDBGeNuKaFQxHbcIQ5VBb6TocWugW/4Y=; b=MsGQx0Yn3nDgmGDCgRTElTTqZq5ZVBm+O7aBs6cBZdJknN2UAh8Ajtml5XCjiRL37fd9aA mDvQQoTfrX7iNDzNPyK0xRzsyAXIU6hxXY9cYZ/SjNrBdYG5NHaPEvVyvnLgnE6lzsyH+o snjJEoKNWPO5NiCgQ3EIHH/cuTR5G7bmVdpupfGHzHxAi1DlFq3Wjv/FKNMLmTjPzry9V3 lOg7lmtYGf09MkVzfXygW975sZ2AJHWxzR5ESxFRgolceaY1LBecEzprVWZIbHbsnC4PNJ qfl145y85d64c5FC8crX+XBHSvuC2VDKJFBf5or4Vr+5H5lGDLbIYZ79fxy4Xw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1683703720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K9e5Gmxnr1gXDBGeNuKaFQxHbcIQ5VBb6TocWugW/4Y=; b=qvE78fBh2zFxbasIL6LECFfoBK/7Ck0cpmzzkaXxBbikGdZke+zlN3OF2P17nIZTFOQ6A6 w7Op04FsBJ62r3DQ== To: linux-kernel@vger.kernel.org Cc: Peter Zijlstra , John Stultz , Thomas Gleixner , Eric Dumazet , "Rafael J . Wysocki" , Arjan van de Ven , "Paul E . McKenney" , Frederic Weisbecker , Rik van Riel , Steven Rostedt , Sebastian Siewior , Giovanni Gherdovich , Lukasz Luba , "Gautham R . Shenoy" , Anna-Maria Behnsen , Tejun Heo , Lai Jiangshan Subject: [PATCH v6 08/21] workqueue: Use global variant for add_timer() Date: Wed, 10 May 2023 09:28:04 +0200 Message-Id: <20230510072817.116056-9-anna-maria@linutronix.de> In-Reply-To: <20230510072817.116056-1-anna-maria@linutronix.de> References: <20230510072817.116056-1-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The implementation of the NOHZ pull at expiry model will change the timer bases per CPU. Timers, that have to expire on a specific CPU, require the TIMER_PINNED flag. If the CPU doesn't matter, the TIMER_PINNED flag must be dropped. This is required for call sites which use the timer alternately as pinned and not pinned timer like workqueues do. Therefore use add_timer_global() to make sure TIMER_PINNED flag is dropped. Signed-off-by: Anna-Maria Behnsen Cc: Tejun Heo Cc: Lai Jiangshan Acked-by: Tejun Heo Reviewed-by: Frederic Weisbecker --- v6: - New patch: As v6 provides unconditially setting TIMER_PINNED flag in add_timer_on() workqueue requires new add_timer_global() variant. --- kernel/workqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 4666a1a92a31..5c529f19e709 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1682,7 +1682,7 @@ static void __queue_delayed_work(int cpu, struct work= queue_struct *wq, if (unlikely(cpu !=3D WORK_CPU_UNBOUND)) add_timer_on(timer, cpu); else - add_timer(timer); + add_timer_global(timer); } =20 /** --=20 2.30.2