From nobody Wed Feb 11 07:25:45 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1B25C7EE25 for ; Tue, 9 May 2023 02:12:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234065AbjEICMd (ORCPT ); Mon, 8 May 2023 22:12:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbjEICMb (ORCPT ); Mon, 8 May 2023 22:12:31 -0400 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9962C93C5; Mon, 8 May 2023 19:12:29 -0700 (PDT) X-UUID: 664dc89cd2b247b58cbe342628b969e4-20230509 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.22,REQID:e00b98a3-2ddc-4ba9-90f4-e29fc37af68b,IP:5,U RL:0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-15 X-CID-INFO: VERSION:1.1.22,REQID:e00b98a3-2ddc-4ba9-90f4-e29fc37af68b,IP:5,URL :0,TC:0,Content:-5,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-15 X-CID-META: VersionHash:120426c,CLOUDID:6ace2c6b-2f20-4998-991c-3b78627e4938,B ulkID:2305091012243TVTBB2R,BulkQuantity:0,Recheck:0,SF:38|24|17|19|44|102, TC:nil,Content:0,EDM:-3,IP:-2,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 ,OSI:0,OSA:0,AV:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-UUID: 664dc89cd2b247b58cbe342628b969e4-20230509 X-User: gehao@kylinos.cn Received: from localhost.localdomain [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 1014334548; Tue, 09 May 2023 10:12:21 +0800 From: Hao Ge To: mturquette@baylibre.com, sboyd@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, wenst@chromium.org Cc: gehao618@163.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Hao Ge Subject: [PATCH] mediatek/clk-mt8173-apmixedsys: use devm_of_iomap to avoid resource leak in clk_mt8173_apmixed_probe Date: Tue, 9 May 2023 10:12:14 +0800 Message-Id: <20230509021214.17105-1-gehao@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use devm_platform_ioremap_resource to take the place of of_iomap for avoid that we don't called iounmap when return some error or remove device. Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock drivers and a= llow module build") Signed-off-by: Hao Ge --- drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/med= iatek/clk-mt8173-apmixedsys.c index 8c2aa8b0f39e..8a2a88c63d15 100644 --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c @@ -146,8 +146,8 @@ static int clk_mt8173_apmixed_probe(struct platform_dev= ice *pdev) struct clk_hw *hw; int r; =20 - base =3D of_iomap(node, 0); - if (!base) + base =3D devm_of_iomap(&pdev->dev, node, 0, NULL); + if (IS_ERR(base)) return PTR_ERR(base); =20 clk_data =3D mtk_alloc_clk_data(CLK_APMIXED_NR_CLK); --=20 2.25.1 No virus found Checked by Hillstone Network AntiVirus