From nobody Wed Feb 11 16:30:16 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223C7C77B75 for ; Sat, 6 May 2023 18:31:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbjEFSbJ (ORCPT ); Sat, 6 May 2023 14:31:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjEFSbG (ORCPT ); Sat, 6 May 2023 14:31:06 -0400 Received: from stravinsky.debian.org (stravinsky.debian.org [IPv6:2001:41b8:202:deb::311:108]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE9C53C00; Sat, 6 May 2023 11:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Content-Transfer-Encoding:MIME-Version :Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=LfQNvT8H4D9rjb0SPnNWYAHLtyQ02TVfsmKU8Ox/okM=; b=lT4MqoKgZ/hrrbrvj+z8CyC1Iq L+GZI6lC/epdVrXrEwUzXsyyahHXXkTMtOJBQ1QewyL38nv4Xiv4GuS7UjlCYRSHWos7YfvN3JSkx UgbA0jdaP744HubPc+kFub6sNi2FQybTdfrfsk665FKc2/KjawgoFVdp0TG1YUMu2Ip63qa2vkGCk FDLYfwFsZwDKACjIxNyNjhfTcLxhUZ2lz/Pi0IVljPoR3Dfzdc7XEHv4INJvNm3tV0yOZSM3NZ/Kq OxdzBSUM+xDcoU0PsjAYX4tgaY5FT3iUagDzfaF6hUsoD0lEYlYA6/mm1ACFF8zCQOEUG99wKoerh xKHaemjw==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1pvMg8-006Idn-FK; Sat, 06 May 2023 18:30:44 +0000 From: Anuradha Weeraman To: Alexander Viro , Christian Brauner , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: anuradha@debian.org Subject: [PATCH] fs/open.c: Fix W=1 kernel doc warnings Date: Sat, 6 May 2023 23:59:27 +0530 Message-Id: <20230506182928.384105-1-anuradha@debian.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1983; i=anuradha@debian.org; h=from:subject; bh=MRs99HIyR+zaAgLmQG7AKOrC7Pt3I10oWZjroXWkqZw=; b=owEBbQKS/ZANAwAKAWNttaHZGGD9AcsmYgBkVpyIJES2GogU87hL5uzQKHFwaebfNS79m8XZ3 nJ846fnOlGJAjMEAAEKAB0WIQT1a48U4BTN710Ef8FjbbWh2Rhg/QUCZFaciAAKCRBjbbWh2Rhg /RY/EACKnoZ9qR6/hlJUVJEycxLf3UE1mXP2z+0+N7AVHZz1rn/9/Jr7moRuCmmp2OeSDQRKLbL jZie3E0ZLs7+YmvMKX+4SjVcmQqnj06q3H2n6otKH3xuxPI/WXo0GK3YNe3vXr+8jyOIA99Di8M +RQVA9Hnm++C1XTodSmAwHWUXsVr+O+9E94Wqdw5VzkRyQuRQq74SWrCWhjjCwbmi7N+BiDqAfX n/shlfZw9iZ9/G+FJ/CzIANdb8f9YZcDVYaDeLCJeQRpR6/OZ5+Y6Qo6jvsWYxfoiRlDTywx36h kz66tumIAl/OgiyFEmISWNlpgvwS4tBsBE5uBXUiA9JVv8XYLkPqTEZH5iMRlZ+2xuSDqT7upzn l5MAFsEs7PJbxS3j7Qgj9lwA0dRZCX6aFb0qoO7AafQoX1k9waGV5EhrORFUp8Hn0O68/hU+Vs3 ExINAu4NLzUh9KV3Nc0vx07H0U6J0JkCBYFzlk7ljFsNpIdpPnYZcOgyS9oQUgf5aah8HSKIhI5 J2mLpndtDBZ3uSBEmr3Se67JVQ0NdDgcFIrWZHrc8vKxiQ8BdQfGyLmnBk8GNdmVV6ay6mDRyF7 I4dnQJ5MfX2IYL68F2vPgtxsTeS6tSO4hAyrkb/nFVbySV4enSe/Qhr4I91eYWU1BoFwfUQID5g gPjZFvjWxAaY8Eg== X-Developer-Key: i=anuradha@debian.org; a=openpgp; fpr=F56B8F14E014CDEF5D047FC1636DB5A1D91860FD Content-Transfer-Encoding: quoted-printable X-Debian-User: anuradha Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" fs/open.c: In functions 'setattr_vfsuid' and 'setattr_vfsgid': warning: Function parameter or member 'attr' not described - Fix warning by removing kernel-doc for these as they are static inline functions and not required to be exposed via kernel-doc. fs/open.c: warning: Excess function parameter 'opened' description in 'finish_open' warning: Excess function parameter 'cred' description in 'vfs_open' - Fix by removing the parameters from the kernel-doc as they are no longer required by the function. Signed-off-by: Anuradha Weeraman --- fs/open.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/fs/open.c b/fs/open.c index 4401a73d4032..fd8fa5936b51 100644 --- a/fs/open.c +++ b/fs/open.c @@ -700,10 +700,7 @@ SYSCALL_DEFINE2(chmod, const char __user *, filename, = umode_t, mode) return do_fchmodat(AT_FDCWD, filename, mode); } =20 -/** - * setattr_vfsuid - check and set ia_fsuid attribute - * @kuid: new inode owner - * +/* * Check whether @kuid is valid and if so generate and set vfsuid_t in * ia_vfsuid. * @@ -718,10 +715,7 @@ static inline bool setattr_vfsuid(struct iattr *attr, = kuid_t kuid) return true; } =20 -/** - * setattr_vfsgid - check and set ia_fsgid attribute - * @kgid: new inode owner - * +/* * Check whether @kgid is valid and if so generate and set vfsgid_t in * ia_vfsgid. * @@ -989,7 +983,6 @@ static int do_dentry_open(struct file *f, * @file: file pointer * @dentry: pointer to dentry * @open: open callback - * @opened: state of open * * This can be used to finish opening a file passed to i_op->atomic_open(). * @@ -1043,7 +1036,6 @@ EXPORT_SYMBOL(file_path); * vfs_open - open the file at the given path * @path: path to open * @file: newly allocated file with f_flag initialized - * @cred: credentials to use */ int vfs_open(const struct path *path, struct file *file) { --=20 2.39.2