From nobody Wed Feb 11 16:31:06 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 823BBC77B75 for ; Sat, 6 May 2023 12:22:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232067AbjEFMWi (ORCPT ); Sat, 6 May 2023 08:22:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231576AbjEFMWg (ORCPT ); Sat, 6 May 2023 08:22:36 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0412114921; Sat, 6 May 2023 05:22:33 -0700 (PDT) Received: from joe-virtual-machine.localdomain ([10.12.176.104]) (user=U201911841@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 346CLPj1014147-346CLPj2014147 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 6 May 2023 20:21:31 +0800 From: Zhong Yong To: Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , "James E.J. Bottomley" , "Martin K. Petersen" Cc: hust-os-kernel-patches@googlegroups.com, Zhong Yong , Dongliang Mu , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: mpt3sas: Fix missing unwind goto in mpt3sas_config_update_driver_trigger_pg3() Date: Sat, 6 May 2023 20:20:30 +0800 Message-Id: <20230506122032.2090153-1-U201911841@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: U201911841@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Smatch warns: drivers/scsi/mpt3sas/mpt3sas_config.c:2478 mpt3sas_config_update_driver_trigger_pg3() warn: missing unwind goto? Fix this by assigning '-EFAULT' to 'rc' and changing the direct return to a goto 'out'. Fixes: 2a5c3a35c156 ("scsi: mpt3sas: Add persistent SCSI sense trigger page= ") Signed-off-by: Zhong Yong Reviewed-by: Dongliang Mu --- The issue is found by static analysis and the patch remains untested. --- drivers/scsi/mpt3sas/mpt3sas_config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_config.c b/drivers/scsi/mpt3sas/m= pt3sas_config.c index d114ef381c44..a426d086044a 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_config.c +++ b/drivers/scsi/mpt3sas/mpt3sas_config.c @@ -2475,7 +2475,8 @@ mpt3sas_config_update_driver_trigger_pg3(struct MPT3S= AS_ADAPTER *ioc, ioc_err(ioc, "%s: Failed to get trigger pg3, ioc_status(0x%04x)\n", __func__, ioc_status)); - return -EFAULT; + rc =3D -EFAULT; + goto out; } =20 if (set) { --=20 2.34.1