From nobody Fri Sep 12 22:33:58 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A35EC7EE2F for ; Thu, 4 May 2023 22:55:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229920AbjEDWy6 (ORCPT ); Thu, 4 May 2023 18:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbjEDWyx (ORCPT ); Thu, 4 May 2023 18:54:53 -0400 Received: from DM5PR00CU002.outbound.protection.outlook.com (mail-centralusazon11021020.outbound.protection.outlook.com [52.101.62.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C24C111B65; Thu, 4 May 2023 15:54:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RILn03F5Y4Dj1r5Xke8qwNTXbbC7zH1B3CHGUQ2BSIB9pnfzkI5wxnDpSD/XzBifxyRuc4nUlxkbLYnyMidfA+cL1eUYdrkpfheTVe7UBJwzkkjW1nS+pKg9iypSSYpwchrmfxX3yJ11ZQgyXvI3lDbEFo8Fml1+Kaq4ucRP9gjYOhYSMMfnD9xuk7Xrdfj7pFsZsoKPLvdjxHoQW+8XZ6UAbLH9LC0uFWCGLjijXxXL9l8rVpYrBym60+JCDgvdfpIqwDCVG0o3ib49QwI2mLrsxrg3U5sNyEsl45nsqxiCkswMqle2KhM2PE4hxKzjJlKIiO56fL2yozKN54TK6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JZ2FgUj8NAsudVWESIa0P9z62Q+QvUqm2435JD6xthY=; b=SmG/OVl6P4N+Er9rnu7JX0buc7o1Kvimb35P7zuSNpuFmHXrFyR8kFo1GcEU6MJG4uN0W2pbAfiFW1e2AX5vSo8OUyGYuszOv3Ip3yqolRwe9NENC/wcX1J1WUYaAj9EcKH3a4WaahY3hXscAtY4ubzt+lzMPPR9oTMT/nJuvO1uEYbtLx8GRabQqIiYqF9HH6QkShivuJe3B1Q7rb2z/6nDYSVasN83gNt5Dj7v4C74Bcz7PH4T5p5gS5I/xmUAjAkOKiatKYwwEi0ZYHfAFe9XYN3XPH9si6ApMgNeBTuT9vnVjE7ihgC35Xm6f7lUGvTjVo6jNPfUSe5gBp5lUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JZ2FgUj8NAsudVWESIa0P9z62Q+QvUqm2435JD6xthY=; b=bx7i01W6mTf2ja0NYTlVafAzRb5R88E66xrDeRR0GRisMZjUND1VzUpeUQJBbkIZjf+5bonG8qa+rro7gbZX2MenHOy+rsDdt/pdWRU+5UzMiqrUfYGK7Q7s2cTpDV9dfn/RlfDh1cBnRbIcHrlVmg93makeU07Q0oEUok8i1QU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; Received: from SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) by SA0PR21MB1883.namprd21.prod.outlook.com (2603:10b6:806:e9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.9; Thu, 4 May 2023 22:54:49 +0000 Received: from SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274]) by SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274%4]) with mapi id 15.20.6387.011; Thu, 4 May 2023 22:54:49 +0000 From: Dexuan Cui To: ak@linux.intel.com, arnd@arndb.de, bp@alien8.de, brijesh.singh@amd.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, haiyangz@microsoft.com, hpa@zytor.com, jane.chu@oracle.com, kirill.shutemov@linux.intel.com, kys@microsoft.com, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com, tglx@linutronix.de, tony.luck@intel.com, wei.liu@kernel.org, x86@kernel.org, mikelley@microsoft.com Cc: linux-kernel@vger.kernel.org, Tianyu.Lan@microsoft.com, Dexuan Cui Subject: [PATCH v6 1/6] x86/tdx: Retry TDVMCALL_MAP_GPA() when needed Date: Thu, 4 May 2023 15:53:46 -0700 Message-Id: <20230504225351.10765-2-decui@microsoft.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230504225351.10765-1-decui@microsoft.com> References: <20230504225351.10765-1-decui@microsoft.com> X-ClientProxiedBy: CYXPR03CA0033.namprd03.prod.outlook.com (2603:10b6:930:d2::10) To SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR2101MB1101:EE_|SA0PR21MB1883:EE_ X-MS-Office365-Filtering-Correlation-Id: 7dd1a140-0e47-4afe-ae73-08db4cf29066 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BeH8wj7Fk+4xEsYCp3vHU3Fw5ccOrgjsFw99IVYS2OiZd+A+ZOCao5iK8A/r9sP430QJwobGEmbqAhJ1N2tdI7cQSJUhzfhmVPG2HeXMkNginJC6BCcN/b+MCU6Z+pIILTzuCPZoxzBNmxsGTLc+3rXswlxqIbScN2Djr/tIVCa9Gr1Vk6TH+yK0IUwOe630GUpyzDtzIZOyS5VWpBB/5+2bb2p/F0UymdgbfSeYx4tuMWmSkvta58s4kVgSP3xTZQoHN2J4W1AsCuyDVk5FSlNVP6BspnXg5MGyWi2HuYzeIp3e0uAlPD5uLoHJ0FusYF7g3J3uz0f+Rp5AU4wzLdSaiLQI0wDWODTd+35TNwkuUxbTDZQ3hGB4EaBl2+0RZcI6yHbTdY7wVORvKnLMfDdZ+B8HFFDVb3HrcrvyDjTKMtVLrdFpCuLKeZDOBKSr8mH0MnIOQdjhV5aJ/IGAPE0OYLAZNfjrUEA96tdh7pV7y8ZRMEIGPdwz1XnHNH/MPZxC86MWgzgaVuZ1XYOD/ChvVsXcAUzR5MkjYM/oBNb9hgap8N3h/ngWEasHh1SK+srhEU3quowidBdwVTi67FVjMWgxrihNlqnjyGwemoF8HbrSmNwXoP/6AoGcUEQ1Rui1GQyaIKRtZfXoifB9/Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR2101MB1101.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(36756003)(86362001)(66946007)(786003)(316002)(66476007)(6666004)(66556008)(52116002)(478600001)(4326008)(6636002)(6486002)(10290500003)(2906002)(82960400001)(8936002)(5660300002)(8676002)(7416002)(38100700002)(921005)(186003)(82950400001)(107886003)(6512007)(1076003)(6506007)(2616005)(41300700001)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Gi9gcNfvxisYvMGS5Vme1G8AMoREN74gP0TNlsx76v690ypq15E7X5B2Irg9?= =?us-ascii?Q?9Y2NRb0iAX2k7mI0of4rgR5oqLNwb6u/EuryqrGm9qflzs4E0BsokROEr3rw?= =?us-ascii?Q?3iT+VpRxhkl1NuYWM58J1Gtm3zbiSQIiJi/7aNvgoa94M9wWlOFOOYdV8Jql?= =?us-ascii?Q?nLTlXZRxm2IK0o+4tRTt/KlgS5+/W1YmU9/37W95Z89mWypZ3Em31LRm23S0?= =?us-ascii?Q?0UvqBXdACkN+I0ARDK79g/udzhffxKAY9hxxiPCpTzdNehuRmfnIae+m1L5Q?= =?us-ascii?Q?DKvn00oPWP/mq2NQM+5csM58JXRDhaaLZX5/7440i/scPo/ddep3UWqFvDB3?= =?us-ascii?Q?Q/rxxP3MZVsi59Icv9yRqFXY7bGP9gmpnO6pYgmBrU73v5KH9T/cUAFhX53G?= =?us-ascii?Q?EArxUNKfkq3YgC2iA4TDji+fhW9NOe8FuClVqzsOnBzkirNfHavyRztdRePF?= =?us-ascii?Q?xPXOt2mK5rKjqJ0iUISB8nLrAs2HcOXOABp83QVTrVBEWGGSICau7l23SmpW?= =?us-ascii?Q?/xUYLLi6srPeNaCv+9G55o89WdFoJv/XFa4U/5ouu/RQ5rEU0L/wqjqZdS8k?= =?us-ascii?Q?EKk8iuRXhko9euHvtt1i4qI1aHhVy3RDWZo8HCDJofQBRWwWbhjN+IQZDKgK?= =?us-ascii?Q?L9gqH4KbgBQL/gnA16t1hNAPeig0/yqof20y/WSlCKbVH/9Qi4wIxYFCjqiA?= =?us-ascii?Q?ElUP/jdILewLjWnv0yWIuJQGxWHuTj/dGlHnCdlrDCOH6k8ByqGY0kZjAdWp?= =?us-ascii?Q?RSDNwYkwx48RmJh4WXdfpFb9Im7wqKUVPIaHN3PqiPxyiPivcLadjQW0QJS3?= =?us-ascii?Q?/nYvPaZuzNByNavko/eTD6sd2IDAeTV4z80U0Jlez5XkhmV0cFpTol+WPQ6Y?= =?us-ascii?Q?23jFbxd80YCTgHymWebMcYUkVvQoT8dVSbSi2yAuHop2zfc80URp6J1aeT7q?= =?us-ascii?Q?k8w3ZMSRGwTMwsYoBEqyVGIK5NOgT+T6zCd6Mvos1g0+wqDyesIy/Cu7++04?= =?us-ascii?Q?U2n+yrJyu3xhIFRdO3rhEBSgw8VUsL1FAtqV1klT5qB/hGU6sO6X6EPTy9YA?= =?us-ascii?Q?RYHI1aTdWwfKk4W46mkXIRX+xA91TdLkqHau6/h/I8Piw1Su9b7CiDtO7tkQ?= =?us-ascii?Q?tLqgar7+IU0d7TEFYXfpk+fo2yZFO/POTB5uxKppPVvoIqvei4+AiJ2E05nT?= =?us-ascii?Q?fOnPHKUTyWb89LRnPBYXHwxaCK9rNm2+XyQhDgD4kiYAv603qMQJ+B5wTfFb?= =?us-ascii?Q?FfMZ0QTUsHpewvMMcHrbakBDYro/FyrIwGonbIi44GFvTl96OGiN3zJMAIzv?= =?us-ascii?Q?utM4IBs2Nai50KL4kG82sD2GHgzv4h/QqqBcmcJPCucOJbJnzObLegdbRy/B?= =?us-ascii?Q?j9Y0FdUQyoAdpA2wxxrBeSwn+OljQaI6n6lRHs0V2Gm59GOKHHui8zVIyk9w?= =?us-ascii?Q?0dde8Qj4Wp6Z7500r6q95SgW1mVAQWH2wY61sdTjoZk3eIEzhkezOK0Uh6VK?= =?us-ascii?Q?7ToCj9fZHXHVodl6ETqS2LiMmsVugEOX85qhWDbr65VJOq+C5o0g4hWTS9um?= =?us-ascii?Q?nNFOqniEhRkjNqhjkVAGMRo71JsyaCc4CpaB71Bpedd6T8qz1XECIIcUwWmn?= =?us-ascii?Q?/IpoaQKbCAB3agTS/V1OkpP3pzROSjC17ayxlNKQiixB?= X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7dd1a140-0e47-4afe-ae73-08db4cf29066 X-MS-Exchange-CrossTenant-AuthSource: SN6PR2101MB1101.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 22:54:49.3491 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VitlBIzQNhh73axCBMWkS0w2vXo0O3I+QCfVczfOWkFP6NnhWbaFX7mYn3JLSPGQiYPmM6FhsmZ0lme0wW1+zg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR21MB1883 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GHCI spec for TDX 1.0 says that the MapGPA call may fail with the R10 error code =3D TDG.VP.VMCALL_RETRY (1), and the guest must retry this operation for the pages in the region starting at the GPA specified in R11. When a TDX guest runs on Hyper-V, Hyper-V returns the retry error when hyperv_init() -> swiotlb_update_mem_attributes() -> set_memory_decrypted() decrypts up to 1GB of swiotlb bounce buffers. Acked-by: Kirill A. Shutemov Reviewed-by: Michael Kelley Signed-off-by: Dexuan Cui --- Changes in v2: Used __tdx_hypercall() directly in tdx_map_gpa(). Added a max_retry_cnt of 1000. Renamed a few variables, e.g., r11 -> map_fail_paddr. Changes in v3: Changed max_retry_cnt from 1000 to 3. Changes in v4: __tdx_hypercall(&args, TDX_HCALL_HAS_OUTPUT) -> __tdx_hypercall_ret() Added Kirill's Acked-by. Changes in v5: Added Michael's Reviewed-by. Changes in v6: None. arch/x86/coco/tdx/tdx.c | 64 +++++++++++++++++++++++++++++++++-------- 1 file changed, 52 insertions(+), 12 deletions(-) diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c index 4c4c6db39eca..5574c91541a2 100644 --- a/arch/x86/coco/tdx/tdx.c +++ b/arch/x86/coco/tdx/tdx.c @@ -28,6 +28,8 @@ #define TDVMCALL_MAP_GPA 0x10001 #define TDVMCALL_REPORT_FATAL_ERROR 0x10003 =20 +#define TDVMCALL_STATUS_RETRY 1 + /* MMIO direction */ #define EPT_READ 0 #define EPT_WRITE 1 @@ -788,14 +790,15 @@ static bool try_accept_one(phys_addr_t *start, unsign= ed long len, } =20 /* - * Inform the VMM of the guest's intent for this physical page: shared with - * the VMM or private to the guest. The VMM is expected to change its map= ping - * of the page in response. + * Notify the VMM about page mapping conversion. More info about ABI + * can be found in TDX Guest-Host-Communication Interface (GHCI), + * section "TDG.VP.VMCALL". */ -static bool tdx_enc_status_changed(unsigned long vaddr, int numpages, bool= enc) +static bool tdx_map_gpa(phys_addr_t start, phys_addr_t end, bool enc) { - phys_addr_t start =3D __pa(vaddr); - phys_addr_t end =3D __pa(vaddr + numpages * PAGE_SIZE); + int max_retry_cnt =3D 3, retry_cnt =3D 0; + struct tdx_hypercall_args args; + u64 map_fail_paddr, ret; =20 if (!enc) { /* Set the shared (decrypted) bits: */ @@ -803,12 +806,49 @@ static bool tdx_enc_status_changed(unsigned long vadd= r, int numpages, bool enc) end |=3D cc_mkdec(0); } =20 - /* - * Notify the VMM about page mapping conversion. More info about ABI - * can be found in TDX Guest-Host-Communication Interface (GHCI), - * section "TDG.VP.VMCALL" - */ - if (_tdx_hypercall(TDVMCALL_MAP_GPA, start, end - start, 0, 0)) + while (1) { + memset(&args, 0, sizeof(args)); + args.r10 =3D TDX_HYPERCALL_STANDARD; + args.r11 =3D TDVMCALL_MAP_GPA; + args.r12 =3D start; + args.r13 =3D end - start; + + ret =3D __tdx_hypercall_ret(&args); + if (ret !=3D TDVMCALL_STATUS_RETRY) + break; + /* + * The guest must retry the operation for the pages in the + * region starting at the GPA specified in R11. Make sure R11 + * contains a sane value. + */ + map_fail_paddr =3D args.r11; + if (map_fail_paddr < start || map_fail_paddr >=3D end) + return false; + + if (map_fail_paddr =3D=3D start) { + retry_cnt++; + if (retry_cnt > max_retry_cnt) + return false; + } else { + retry_cnt =3D 0; + start =3D map_fail_paddr; + } + } + + return !ret; +} + +/* + * Inform the VMM of the guest's intent for this physical page: shared with + * the VMM or private to the guest. The VMM is expected to change its mapp= ing + * of the page in response. + */ +static bool tdx_enc_status_changed(unsigned long vaddr, int numpages, bool= enc) +{ + phys_addr_t start =3D __pa(vaddr); + phys_addr_t end =3D __pa(vaddr + numpages * PAGE_SIZE); + + if (!tdx_map_gpa(start, end, enc)) return false; =20 /* private->shared conversion requires only MapGPA call */ --=20 2.25.1 From nobody Fri Sep 12 22:33:58 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA784C77B7C for ; Thu, 4 May 2023 22:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229606AbjEDWzC (ORCPT ); Thu, 4 May 2023 18:55:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbjEDWyy (ORCPT ); Thu, 4 May 2023 18:54:54 -0400 Received: from DM5PR00CU002.outbound.protection.outlook.com (mail-centralusazon11021020.outbound.protection.outlook.com [52.101.62.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E11311D80; Thu, 4 May 2023 15:54:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=As5p4FQi2sOVitQQKKj8LzX6f7aqaWdpJSygeF9LMzqglLB1NWxzqql6p2EIFGWkqK17gpe8iYKr2T6KCBD6QP4u1z5fNrtTeNsVzJS+Z4uVNWQdBOI0e/Wk4zJ1cLOcW0C1rHcS2nuNAJ1y3ZXRhzALszvjN3OE3IzJ4ZtWRKu/G5QOwaYEH5D+MTCuwJsVJ3agB0wBrQRVLIxIo1N1msQFFGi17UC+ldCgqJ15pwQqQN8P0wUmcNKfZb702OKTzc3WXVLBjjo6Fv5TwTjoBQ0BY23k35YQdfzih4lQzRW5tt6eRSb8Z/NUZsoWRkcrWIEC68AoMz/kusfWx5iltg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F8E9Nk4FNiFw3SJfXQWE+zYXr8WlJktHjMyIKEPXEzA=; b=dVjN22pDEpRECyT25hfi7zls99PWWvc2WaPKq1ubhUoH39rkau47JKjCdY7+CKK3f5iHy5kHEcx48GzRnHwS3JZUReD8EOSK4DLcp9FkVBSUC9CKpfVp70CPmzBJWz1m9pW635y/Ni7R5nbj8kcZIix7ltX1VFKBjy2KP09ZeXFxmvq9uiXlAR6mpM85ojEg2eb5clBBJ7CnUWSW+8rfMjoDSHx6DQOSgmk6cpt79tqTU3NoQA/rqOGbDxzWFk8FikI/vs4pGLuCnvZhlezGYKFMZQm8u6EKN02tUFLPHgYeXPnFmAFH1LBMQNcHTFgIgM6sJcOoQzf+zAqSb8d/oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F8E9Nk4FNiFw3SJfXQWE+zYXr8WlJktHjMyIKEPXEzA=; b=LZJPbVdI/ztKWxBOyvqrd+9V2iYU1CfAti3zQi9DmWffhGlzoJJZ4FM5XKSqhNI3ZRglf0vMURNFkW8QGzQvp7/Qyd/WS4RgogTpx4bFj3EjL942bYDICwos6XjVtb1p0MqTi6u6Nd9wT7FV7s9V0bmJW+XqqyKnO1R78a1SaGs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; Received: from SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) by SA0PR21MB1883.namprd21.prod.outlook.com (2603:10b6:806:e9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.9; Thu, 4 May 2023 22:54:51 +0000 Received: from SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274]) by SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274%4]) with mapi id 15.20.6387.011; Thu, 4 May 2023 22:54:51 +0000 From: Dexuan Cui To: ak@linux.intel.com, arnd@arndb.de, bp@alien8.de, brijesh.singh@amd.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, haiyangz@microsoft.com, hpa@zytor.com, jane.chu@oracle.com, kirill.shutemov@linux.intel.com, kys@microsoft.com, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com, tglx@linutronix.de, tony.luck@intel.com, wei.liu@kernel.org, x86@kernel.org, mikelley@microsoft.com Cc: linux-kernel@vger.kernel.org, Tianyu.Lan@microsoft.com, Dexuan Cui Subject: [PATCH v6 2/6] x86/tdx: Support vmalloc() for tdx_enc_status_changed() Date: Thu, 4 May 2023 15:53:47 -0700 Message-Id: <20230504225351.10765-3-decui@microsoft.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230504225351.10765-1-decui@microsoft.com> References: <20230504225351.10765-1-decui@microsoft.com> X-ClientProxiedBy: CYXPR03CA0033.namprd03.prod.outlook.com (2603:10b6:930:d2::10) To SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR2101MB1101:EE_|SA0PR21MB1883:EE_ X-MS-Office365-Filtering-Correlation-Id: b70d12be-4f96-420d-b0a1-08db4cf29171 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x3+C0bFHHXzXL/S1w5vbpyD49XsXlenhxgl29TF2cR3TrxrbGF7cjtWY6nax2S4llDnFpHfL0JRrmrpDhhKPCfWGjTAKkj2PFqf76tnJZkV+JXV6aSBShMGrFVxZdwaZlNwOezXdNQhWB8M/ONY8W8NQggmBi/GWNBGKTBOLR1hcbYVuL6r2TvzUfVtSj5x0u+ay0LhxDxBXuYIuRjN0RaaRA31VL7CRHofBFgzRzJIYpJElVN+TG9Q3DMdh7daBHEN0NRbPQSs/m7/h5us7eWiPxU5zw4Kmfqgw/LrCVobW3UUtnwAJvCj5WS63kRoEHXX24DQL0gdWJDTdHNkkxy4+EqPxuenPRPPpmHJ2K9Mxl37Y+fKfPJkGSKPl6VjxaT1gTV0g06MBEJpxu/i4y/h3KZInTqGQ9nMk+bI1WkYjmpKc9u93KvEai9f6ovdOSrF4YnX3Uzruc+b/UVBJKbuteNj9AgeZ63+YC5/iGyfUIzkIOTvfoe4OczLJ7/g4d04mVxaPdHoLL5s3YFhUKfrd8qfC9C+4qnopHsosAXwTdoSQAWahYi+Yd5uMaYnY8bnKd6CehWGiAjaB1cwJlyj+FVquCr+y/+SaQKH3t+FCIkyualmBEVA6d6KN9ksl4ZRLiC9+6zgIhlkVHu46RQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR2101MB1101.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(36756003)(86362001)(66946007)(786003)(316002)(66476007)(6666004)(66556008)(52116002)(478600001)(4326008)(6636002)(6486002)(10290500003)(2906002)(82960400001)(8936002)(5660300002)(8676002)(7416002)(38100700002)(921005)(186003)(82950400001)(107886003)(6512007)(1076003)(6506007)(2616005)(41300700001)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0+hKvBATs+EdyYTnwcdQODEHnEPu6354LzzewHssS+cd44yTa97CDwLCuGAK?= =?us-ascii?Q?PzboNIw/dlwA63zOdYTeMwTYrPfXF9EfB/OSFegmmk6QFYYRskjRNTQX6XRg?= =?us-ascii?Q?sZQAq4ZnCB812yoBshiDqDVvxDN9pJThbL1muZdpJ02HG7coJahhkvaA20s0?= =?us-ascii?Q?X5ARvLv8h0KFwANIFBOclxV9Z02zFxWogandUhvvsjHC4izGm+pxw4Nij8jt?= =?us-ascii?Q?2UpScG0UHfnan2Cs3XjIKTHnd/1CVgqq/4f6jOKmC0GlYqZkNh4Ik1O4Rnlx?= =?us-ascii?Q?9/6Us4QPlScOB8cA9VuTyppPtWZPed6362rMKbIHjZ4bAyhqtxZxjBBVGCnm?= =?us-ascii?Q?3UjZlK9HKBc/mdat2uV7v4o20n6k4MSQAX9413DI7ZzqA8uVlZzKVJnGWKJp?= =?us-ascii?Q?hRCfovOFdcycJ9ufTbikcAA4WBdHYHI8GdNsWeWQIRrH9VhwFchc8BfxCW2T?= =?us-ascii?Q?ucrjs9L7KllK7byFVpUPhkB3NHbvX1f/DG/lkJtlJBKEvqLTiCxqgfbFL+tp?= =?us-ascii?Q?joRVGR3ac50VGlXxWPxv+JL0Ff24tf+CGmCngXOITmBWim+XSH6ZCD11Rar+?= =?us-ascii?Q?eOOtqmVxdQ3j/1Gix3wC6F9wWZp+246h+qZE1ChJrfPYHoDu2gRhhyGMmXPs?= =?us-ascii?Q?Aq0+Wf+UDCG8At1pIY/k6Ra0MPmPjVDQHWpg/B+Sb1pLirc/ebMzzW695wZm?= =?us-ascii?Q?40mUC4nA8LBi5QlCiYuYZCGCe7X/dx2DDGsHWUrXf1lcKUqffYy2mYPQHlwa?= =?us-ascii?Q?TZobE0TvywaxWlAqGYowqmc/VMKFXMJEMX920bu0Fg/zHN3Z67zl+mf7wgtS?= =?us-ascii?Q?ojfSFnEuUdOzJBKTqIYfXUjRxVTts+fobi0JljMLlf67WLyohMxJv0PvQta4?= =?us-ascii?Q?jREreY6OwajyjeYlbbj+Das7DD6eg6Dgt8Eb6x7j8Q0Uy9VT3QuFHVRL+UOl?= =?us-ascii?Q?kTvFnsYQazUroAq9eyGEzajOg++bLaSsPsBvT/wbyG1BcWfh1pnmMWATxGzp?= =?us-ascii?Q?34ZT6/dXXLuCYjJmJEbsmRkitN8zGOF3lmM49R4PI8HIMWR1mGMnML04e9Uq?= =?us-ascii?Q?MRTnPe5UGA7trxUW2ENca0a2Mj+HYHiO2tKyMWoeQUb+XIkcmIKyAQSEYTl4?= =?us-ascii?Q?Ce+3iYyw5+M7KK8GT6QCqUMmJBz2/8q7+KZDrv2PiIF3bsXIcu6CjgkcEMfw?= =?us-ascii?Q?sSxezAP65kvSrSaNAS+kfbJ8QXXMvNsIwbt5W2V81fpJyWrIcl8PL62XXyoR?= =?us-ascii?Q?fmSseYdhA/mvJBp17r0SGamCU7bGXBcj62JSYsgR1TPXqzEx+5ZTwfudP6AT?= =?us-ascii?Q?pfjRup8G3s4N+ejQBLSghgnVhBLH0TJVt6m93spHbuT0vdqxovKJxnaTKUht?= =?us-ascii?Q?PP2EPFjTDxrNg1eLfYO2uRqKh4R211rI5h7LV+KrVVfOxKR/wxzHzic7fKIh?= =?us-ascii?Q?4c6VPgeKdJsO6W0i7l9J20WrVSgF5oJ+krAhIhwkeVj8YezH+VWoD/BI+Hfd?= =?us-ascii?Q?oyKJWFtIuzrMbPf2CQ9s6StNkbHHgkx2BG06aNa97OPphdvDaJbYkR8nRTR/?= =?us-ascii?Q?6mdYsBiv2Zz0ZlqFkUUJys2CnoO6NPttNkxG1dbjjXYxTQ0FVcbEmfpFSoRA?= =?us-ascii?Q?riKNzPTB20th+jdn3iqVtYknm/WTl2rgD3qVFKyNdD8A?= X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: b70d12be-4f96-420d-b0a1-08db4cf29171 X-MS-Exchange-CrossTenant-AuthSource: SN6PR2101MB1101.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 22:54:51.0487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: x0L2WymJC7dRfrKvuFG0HKx9gxwh1oibbHPj3J/k2iWgb6gVrRuzmV0pSP3HvKwOLKLxQWglceBIyzPcPgmcgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR21MB1883 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a TDX guest runs on Hyper-V, the hv_netvsc driver's netvsc_init_buf() allocates buffers using vzalloc(), and needs to share the buffers with the host OS by calling set_memory_decrypted(), which is not working for vmalloc() yet. Add the support by handling the pages one by one. Co-developed-by: Kirill A. Shutemov Signed-off-by: Kirill A. Shutemov Reviewed-by: Michael Kelley Signed-off-by: Dexuan Cui --- Changes in v2: Changed tdx_enc_status_changed() in place. Hi, Dave, I checked the huge vmalloc mapping code, but still don't know how to get the underlying huge page info (if huge page is in use) and try to use PG_LEVEL_2M/1G in try_accept_page() for vmalloc: I checked is_vm_area_hugepages() and __vfree() -> __vunmap(), and I think the underlying page allocation info is internal to the mm code, and there is no mm API to for me get the info in tdx_enc_status_changed(). Changes in v3: No change since v2. Changes in v4: Added Kirill's Co-developed-by since Kirill helped to improve the code by adding tdx_enc_status_changed_phys(). Thanks Kirill for the clarification on load_unaligned_zeropad()! The vzalloc() usage in drivers/net/hyperv/netvsc.c: netvsc_init_buf() remains the same. It may not worth it to "allocate a vmalloc region, allocate pages manually", because we have to consider the worst case where the system is sufferiing from severe memory fragmentation and we can only allocate multiple single pages. We may not want to complicate the code in netvsc_init_buf(). We'll support NIC SR-IOV for TDX VMs on Hyper-V, so the netvsc send/recv buffers won't be used when the VF NIC is up. Changes in v5: Added Kirill's Signed-off-by. Added Michael's Reviewed-by. Changes in v6: None. arch/x86/coco/tdx/tdx.c | 76 ++++++++++++++++++++++++++++------------- 1 file changed, 52 insertions(+), 24 deletions(-) diff --git a/arch/x86/coco/tdx/tdx.c b/arch/x86/coco/tdx/tdx.c index 5574c91541a2..731be50b3d09 100644 --- a/arch/x86/coco/tdx/tdx.c +++ b/arch/x86/coco/tdx/tdx.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -789,6 +790,34 @@ static bool try_accept_one(phys_addr_t *start, unsigne= d long len, return true; } =20 +static bool try_accept_page(phys_addr_t start, phys_addr_t end) +{ + /* + * For shared->private conversion, accept the page using + * TDX_ACCEPT_PAGE TDX module call. + */ + while (start < end) { + unsigned long len =3D end - start; + + /* + * Try larger accepts first. It gives chance to VMM to keep + * 1G/2M SEPT entries where possible and speeds up process by + * cutting number of hypercalls (if successful). + */ + + if (try_accept_one(&start, len, PG_LEVEL_1G)) + continue; + + if (try_accept_one(&start, len, PG_LEVEL_2M)) + continue; + + if (!try_accept_one(&start, len, PG_LEVEL_4K)) + return false; + } + + return true; +} + /* * Notify the VMM about page mapping conversion. More info about ABI * can be found in TDX Guest-Host-Communication Interface (GHCI), @@ -838,6 +867,19 @@ static bool tdx_map_gpa(phys_addr_t start, phys_addr_t= end, bool enc) return !ret; } =20 +static bool tdx_enc_status_changed_phys(phys_addr_t start, phys_addr_t end, + bool enc) +{ + if (!tdx_map_gpa(start, end, enc)) + return false; + + /* private->shared conversion requires only MapGPA call */ + if (!enc) + return true; + + return try_accept_page(start, end); +} + /* * Inform the VMM of the guest's intent for this physical page: shared with * the VMM or private to the guest. The VMM is expected to change its mapp= ing @@ -845,37 +887,23 @@ static bool tdx_map_gpa(phys_addr_t start, phys_addr_= t end, bool enc) */ static bool tdx_enc_status_changed(unsigned long vaddr, int numpages, bool= enc) { - phys_addr_t start =3D __pa(vaddr); - phys_addr_t end =3D __pa(vaddr + numpages * PAGE_SIZE); + unsigned long start =3D vaddr; + unsigned long end =3D start + numpages * PAGE_SIZE; =20 - if (!tdx_map_gpa(start, end, enc)) + if (offset_in_page(start) !=3D 0) return false; =20 - /* private->shared conversion requires only MapGPA call */ - if (!enc) - return true; + if (!is_vmalloc_addr((void *)start)) + return tdx_enc_status_changed_phys(__pa(start), __pa(end), enc); =20 - /* - * For shared->private conversion, accept the page using - * TDX_ACCEPT_PAGE TDX module call. - */ while (start < end) { - unsigned long len =3D end - start; + phys_addr_t start_pa =3D slow_virt_to_phys((void *)start); + phys_addr_t end_pa =3D start_pa + PAGE_SIZE; =20 - /* - * Try larger accepts first. It gives chance to VMM to keep - * 1G/2M SEPT entries where possible and speeds up process by - * cutting number of hypercalls (if successful). - */ - - if (try_accept_one(&start, len, PG_LEVEL_1G)) - continue; - - if (try_accept_one(&start, len, PG_LEVEL_2M)) - continue; - - if (!try_accept_one(&start, len, PG_LEVEL_4K)) + if (!tdx_enc_status_changed_phys(start_pa, end_pa, enc)) return false; + + start +=3D PAGE_SIZE; } =20 return true; --=20 2.25.1 From nobody Fri Sep 12 22:33:58 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E671DC7EE2A for ; Thu, 4 May 2023 22:55:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbjEDWzG (ORCPT ); Thu, 4 May 2023 18:55:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229900AbjEDWy4 (ORCPT ); Thu, 4 May 2023 18:54:56 -0400 Received: from DM5PR00CU002.outbound.protection.outlook.com (mail-centralusazon11021025.outbound.protection.outlook.com [52.101.62.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30E2E11DA6; Thu, 4 May 2023 15:54:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MqNDVUvv1EahNpfWY86+/5plFH4IRAA4/YJsGVZasGjPKpU7K95u5oZib32JXrTK4pgP6tKfdhyJ2+YAdlpFfrTIPdsVdlB/WfzggQRyqdLx4lY0FV+CFo9xfzuwslHjIwbK+CHYd7WY2dgaa9TcMMtWTvdejmT038Y72TkhE1xNueziYtirOVcDU8ydnMYSQoJ3u3vAGK8ilxIuPnxFqEK/EhrzImK4OQOfRO7XkwGvlsoSCs2Xoe1q6BHsAQm7+Ir5gYSqvHPqiTwtIFDNmMProVhMLjxzAI4FSVPci3pSCbzXC2t6QC2+xJo12nDiQHV2NFhuT7V2E71qKfGj2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HICxEjvifot0hXyluUJx+0RyHTbJjmVRE7X2xR7lbv4=; b=fwio32D+D2JpyZHJP+me5bFGxwjTUPPM66TOVlfLeSJ0R+MD5Ix2QZIzfDidIflSuMnB08EfamY2uvru0OH9OlAlaVhLzuJ90lxL7cGIBge6XXtOaLN4r3Xb+8y4rkN3pzPH60kpdRPndoM79XSsMG5DBir/bi8+1H5Jmvi6ZGNLQodOxRSQwJPudcxTkjdjVwzVniamCu+pehA9y3H9P5oywOfGG4qXLVa655Q1/IQ4RX9yNv/zGtPObdUs9tsJ2KoQ6HnzGhK8+ANMxlr02YcwRgNGrwYEgkDffa7KyNJRBgenKQDIlkZqHGDBYFpQtqbvQyq/uVKN9DjFoGSJRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HICxEjvifot0hXyluUJx+0RyHTbJjmVRE7X2xR7lbv4=; b=P9m3kxYjctlvCvlwdHgfWXXdXGOS/4i1xzWBi6D6k7wb/CJMcN8TVkDAISKyNQXw1sAg7zBRQcx7wFBBDLi0tanF4beMsGDBqQnkmjV7iLn/1v/dmAQ2yVwJiuOzVG+z/K2kGplt3TILyPMvhKoMzYy5+0XLDkkUvYmSpSLdMSo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; Received: from SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) by SA0PR21MB1883.namprd21.prod.outlook.com (2603:10b6:806:e9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.9; Thu, 4 May 2023 22:54:52 +0000 Received: from SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274]) by SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274%4]) with mapi id 15.20.6387.011; Thu, 4 May 2023 22:54:52 +0000 From: Dexuan Cui To: ak@linux.intel.com, arnd@arndb.de, bp@alien8.de, brijesh.singh@amd.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, haiyangz@microsoft.com, hpa@zytor.com, jane.chu@oracle.com, kirill.shutemov@linux.intel.com, kys@microsoft.com, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com, tglx@linutronix.de, tony.luck@intel.com, wei.liu@kernel.org, x86@kernel.org, mikelley@microsoft.com Cc: linux-kernel@vger.kernel.org, Tianyu.Lan@microsoft.com, Dexuan Cui Subject: [PATCH v6 3/6] x86/hyperv: Add hv_isolation_type_tdx() to detect TDX guests Date: Thu, 4 May 2023 15:53:48 -0700 Message-Id: <20230504225351.10765-4-decui@microsoft.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230504225351.10765-1-decui@microsoft.com> References: <20230504225351.10765-1-decui@microsoft.com> X-ClientProxiedBy: CYXPR03CA0033.namprd03.prod.outlook.com (2603:10b6:930:d2::10) To SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR2101MB1101:EE_|SA0PR21MB1883:EE_ X-MS-Office365-Filtering-Correlation-Id: 87ac88d2-bdaa-4990-298e-08db4cf29273 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mRQ2fbIyIGHOhinHO4YDXgFzB6ogdwBYLDXggHHQ3+mY0xyOFhjXKCnR7FaDifF5KMeMOnXBJePLSmRGPug044SezcUGn8fGIfgrlDoPMUW5/sjOuL9Y//wxDHxhSjUjM+hAXLrW6lWWxyMKjHrz1qVPHoFVqbbxYE7NVWdqQI0Eto2kPqR1Ffef0xp0KOFefQ3CBbdiIn7pVrcp/HCT9zRKTUTV60eXdxJgmV1h5FF3th6TXQ4g0Cvd+yynHaDkeLkhXXA1MiArfkNLyeEGYP9dSJES8nHDTFMup41v9zTWoxrTwZzC4Ejn168jRSeg+jVuBt4yPVARz8ILRZ4y0wGgEXZCR0ZBxllc/I/E7YP//0lAYDpXWLO0cxAWzPlQUisUuNnozihTqyvsk9F8qbJ43lZfnncUml+a0tUZGcKBlRBHcGp9yVcdzVf1v8CqXP4JUeg1RnS9mmrlAYdXW7NrwPDvpBInhNyX9l3CBSDQK8kTxb6JTSeMyYwuAzIfoUzOd36kfyJebN32I5Ldh+LHKbInlvg7MWWgPNwpja99sX/LPJ+xFbATL+DCbolX3S3xWFOztUuLV9w+X4FVppZ36ERcUNnJCuWnEr5HEl9v1z1HrrhWAwqwd9c7XQPuItRrVdkK4XkwEG63keRgPg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR2101MB1101.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(36756003)(86362001)(66946007)(786003)(316002)(66476007)(6666004)(66556008)(52116002)(478600001)(4326008)(6636002)(6486002)(10290500003)(2906002)(82960400001)(8936002)(5660300002)(8676002)(7416002)(38100700002)(921005)(186003)(82950400001)(107886003)(6512007)(1076003)(6506007)(2616005)(41300700001)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wdn+iHBzZSwpEDS9ANIAqyCtUUEK8NvFqHdza3pIhfOx+DyIm/sWYZ2cn2v9?= =?us-ascii?Q?vZMdrY9/b2Nh7omBBAOiLlD5ebwvapju0BUZ/sV+6kx3P6PoTl1D30MU7Hqx?= =?us-ascii?Q?9WRdKlCik3rKPSD9V4UV2l1VCNig0QhPwZ6hB+S0FQ64mQGJgU8Xh5Fm/WJE?= =?us-ascii?Q?UYmCWSa3zKcNafYVcBdxsK9zi2WdTVjvg3vovX2Db7rEAP9sxeP5qBTeCx87?= =?us-ascii?Q?Q1MGX9n4/4rQFX4CbjNq6qdT51UBXNkQKFywEKLhrsKtOJ+yrbkaD6lgS4XC?= =?us-ascii?Q?wwrLFEHFVUGj8/GhFvLeACQH9BwaZo6aSwdQbxWMpTjSpOc2BNhXhmnQ/6kd?= =?us-ascii?Q?HsFD7RpVuSlGrpAPw3Ieo1+kZm/nJbUR0r/YyPzRwB0AezENRwr9DbMOnevE?= =?us-ascii?Q?ZqBxaHVhpw9jbdZDfLL1QyoI5Bzf3lw9h3BKVoEhhj1A4jDL13VociPE1KHh?= =?us-ascii?Q?EaANuAiQ4IvRxQiTVV58U5T3UpeC56HijhfhAtxMOCtYKya9tNM5nDASMGUc?= =?us-ascii?Q?ZxrtlOT1OUF5iCerQgLdaHoAPMKgSUqkJtsfNpkQoXvMKYGcBRIx3Qk1o7yr?= =?us-ascii?Q?rihsKiGc1HIjqBqIEkuZc7w3Gh3tWkdnh96FPX9BV18BuGCCT1FtzuqmVKCl?= =?us-ascii?Q?5SfxJwbiuDGqiPz46j5y34xhdY1cGwvSkYiTHHghtCaQLUEfck3LakvhGSVF?= =?us-ascii?Q?RNvGUPy6SeePsmVJHkEVwi5AUvKTULvv0SnyWMa/zRclO3sTL5P1c3oI2r07?= =?us-ascii?Q?oGWsh5ZkKTAq8uiaI++0yF4UOruPoAQbQSjnNnT99wRwN5PYZ7ZNLyT6JBp3?= =?us-ascii?Q?qNXLNmrS95leMiCnSV6gAAH652OShc54HuREhd3/Z0hQTj0i5CnBLEUiYKK7?= =?us-ascii?Q?PrY20HzlhgRH80fnGy0133ungSIZU6YiVaztlEIGYJ7rDXS+eNto4uqSwzue?= =?us-ascii?Q?an4xh5os4Gn0LomdcC58Ot7qRW8OCuPlF+FMUnExyyUctRqs/YifSA4W0+QZ?= =?us-ascii?Q?XoQX1hwOE9f24E7he3vtfhH5RFRk+0dcsF1p3r9dLAG4v6HYnbaxNWjq5QFX?= =?us-ascii?Q?vpcBA6h8dL3urGSqe89dTdy/QecMXVryOib1VtL1+6Cu42sUCAhK7onscyhr?= =?us-ascii?Q?QQbXl0tpnlV88XUuKQIdITG2NXd9K9s64wnbD9Xlt8bkQf/dYpc8PRdFzKHh?= =?us-ascii?Q?4pBdc8R4mkfgPmlN6I3N1GMb4Ua9N7FeDI7W74V6HVXJLvxMZAB9Ji20pgVr?= =?us-ascii?Q?fCzsWo1PVWLl/g3R3WZFGEl1HIZp9hFxViDbglHJvb0IpmTl/95yhkafQWKC?= =?us-ascii?Q?Zr86Aee7+6+ryFGLPEG3CFpNK6K6ApzsYq8pGloYc32qO9Xm4p+wyXru2mmD?= =?us-ascii?Q?2N1lNWvC8ztM92xvJWf87b3TnhcO6AGVqVmFizpF0H3z6SZyzT7ZE8NB72Mf?= =?us-ascii?Q?HbDTSsOur1KWaQNKOK49MlQFmyyaj7xUoIrCo+fyzYDqJeRUTTK7G+lfgXvY?= =?us-ascii?Q?flrmY3+m+nc0GvVsQ06qY0iQa6wSklE7SV9vxysoVixq3NxokKvjZk4zaakt?= =?us-ascii?Q?g4Ud/4PdRKta8L6xBhPmgpdoiUeFa6mFtG5ytMo9bhjnuhnvHxkyq5uPNX/J?= =?us-ascii?Q?lzjZ6M3liuGjHzp5KcX1Fd28vKvy7Jh1kB8zS2cwDekn?= X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87ac88d2-bdaa-4990-298e-08db4cf29273 X-MS-Exchange-CrossTenant-AuthSource: SN6PR2101MB1101.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 22:54:52.7602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YuFFR1b2+iLSvnf8zlCGIwnTSpki69PTX43WNUuzayaWzwItE8W+5+8c0dFtS/OqSOJE5VZ5XbB7QJLW9N6xtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR21MB1883 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" No logic change to SNP/VBS guests. hv_isolation_type_tdx() wil be used to instruct a TDX guest on Hyper-V to do some TDX-specific operations, e.g. hv_do_hypercall() should use __tdx_hypercall(), and a TDX guest on Hyper-V should handle the Hyper-V Event/Message/Monitor pages specially. Reviewed-by: Kuppuswamy Sathyanarayanan Reviewed-by: Michael Kelley Signed-off-by: Dexuan Cui --- Changes in v2: Added "#ifdef CONFIG_INTEL_TDX_GUEST and #endif" for hv_isolation_type_tdx() in arch/x86/hyperv/ivm.c. Simplified the changes in ms_hyperv_init_platform(). Changes in v3: Added Kuppuswamy's Reviewed-by. Changes in v4: A minor rebase to Michael's v7 DDA patchset. Changes in v5: Added Michael's Reviewed-by. Changes in v6: None. arch/x86/hyperv/ivm.c | 6 ++++++ arch/x86/include/asm/hyperv-tlfs.h | 3 ++- arch/x86/include/asm/mshyperv.h | 3 +++ arch/x86/kernel/cpu/mshyperv.c | 2 ++ drivers/hv/hv_common.c | 6 ++++++ include/asm-generic/mshyperv.h | 1 + 6 files changed, 20 insertions(+), 1 deletion(-) diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c index cc92388b7a99..952117ce2d80 100644 --- a/arch/x86/hyperv/ivm.c +++ b/arch/x86/hyperv/ivm.c @@ -400,6 +400,7 @@ bool hv_is_isolation_supported(void) } =20 DEFINE_STATIC_KEY_FALSE(isolation_type_snp); +DEFINE_STATIC_KEY_FALSE(isolation_type_tdx); =20 /* * hv_isolation_type_snp - Check system runs in the AMD SEV-SNP based @@ -409,3 +410,8 @@ bool hv_isolation_type_snp(void) { return static_branch_unlikely(&isolation_type_snp); } + +bool hv_isolation_type_tdx(void) +{ + return static_branch_unlikely(&isolation_type_tdx); +} diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hype= rv-tlfs.h index cea95dcd27c2..ebb6d24fe352 100644 --- a/arch/x86/include/asm/hyperv-tlfs.h +++ b/arch/x86/include/asm/hyperv-tlfs.h @@ -169,7 +169,8 @@ enum hv_isolation_type { HV_ISOLATION_TYPE_NONE =3D 0, HV_ISOLATION_TYPE_VBS =3D 1, - HV_ISOLATION_TYPE_SNP =3D 2 + HV_ISOLATION_TYPE_SNP =3D 2, + HV_ISOLATION_TYPE_TDX =3D 3 }; =20 /* Hyper-V specific model specific registers (MSRs) */ diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyper= v.h index 49bb4f2bd300..231e56631295 100644 --- a/arch/x86/include/asm/mshyperv.h +++ b/arch/x86/include/asm/mshyperv.h @@ -26,6 +26,7 @@ union hv_ghcb; =20 DECLARE_STATIC_KEY_FALSE(isolation_type_snp); +DECLARE_STATIC_KEY_FALSE(isolation_type_tdx); =20 typedef int (*hyperv_fill_flush_list_func)( struct hv_guest_mapping_flush_list *flush, @@ -47,6 +48,8 @@ extern u64 hv_current_partition_id; =20 extern union hv_ghcb * __percpu *hv_ghcb_pg; =20 +extern bool hv_isolation_type_tdx(void); + int hv_call_deposit_pages(int node, u64 partition_id, u32 num_pages); int hv_call_add_logical_proc(int node, u32 lp_index, u32 acpi_id); int hv_call_create_vp(int node, u64 partition_id, u32 vp_index, u32 flags); diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index c7969e806c64..2fd687a80033 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -404,6 +404,8 @@ static void __init ms_hyperv_init_platform(void) =20 if (hv_get_isolation_type() =3D=3D HV_ISOLATION_TYPE_SNP) static_branch_enable(&isolation_type_snp); + else if (hv_get_isolation_type() =3D=3D HV_ISOLATION_TYPE_TDX) + static_branch_enable(&isolation_type_tdx); } =20 if (hv_max_functions_eax >=3D HYPERV_CPUID_NESTED_FEATURES) { diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c index 64f9ceca887b..6156114cd9c5 100644 --- a/drivers/hv/hv_common.c +++ b/drivers/hv/hv_common.c @@ -502,6 +502,12 @@ bool __weak hv_isolation_type_snp(void) } EXPORT_SYMBOL_GPL(hv_isolation_type_snp); =20 +bool __weak hv_isolation_type_tdx(void) +{ + return false; +} +EXPORT_SYMBOL_GPL(hv_isolation_type_tdx); + void __weak hv_setup_vmbus_handler(void (*handler)(void)) { } diff --git a/include/asm-generic/mshyperv.h b/include/asm-generic/mshyperv.h index 402a8c1c202d..3449a8a27c03 100644 --- a/include/asm-generic/mshyperv.h +++ b/include/asm-generic/mshyperv.h @@ -58,6 +58,7 @@ extern void * __percpu *hyperv_pcpu_output_arg; extern u64 hv_do_hypercall(u64 control, void *inputaddr, void *outputaddr); extern u64 hv_do_fast_hypercall8(u16 control, u64 input8); extern bool hv_isolation_type_snp(void); +extern bool hv_isolation_type_tdx(void); =20 /* Helper functions that provide a consistent pattern for checking Hyper-V= hypercall status. */ static inline int hv_result(u64 status) --=20 2.25.1 From nobody Fri Sep 12 22:33:58 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E4BBC7EE21 for ; Thu, 4 May 2023 22:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbjEDWzK (ORCPT ); Thu, 4 May 2023 18:55:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbjEDWy5 (ORCPT ); Thu, 4 May 2023 18:54:57 -0400 Received: from DM5PR00CU002.outbound.protection.outlook.com (mail-centralusazon11021025.outbound.protection.outlook.com [52.101.62.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 870DC120BE; Thu, 4 May 2023 15:54:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KYNe6b3SSOn4OAxNFvx2ZteJChO4pgigqO7XPYNTFtCqYo1QULz87/ewfAu35aR3hF5X4SRs6E5WsbeyvWjCI5f3tJEMeIGjAu5G2piFe2AiAsEQDCQ32TzMoZMiMvG7tCL5vHghFABkIujpEiGKITUhqcsskWV8nN3hF9PdCVZBbTMQl0fVC8SlxwflR5YibO4IZXqOlICKAraEupeUmXEfoYrpRvDGjULT0ayTWKh/1nYDYaltg6ezSGVHr2hVmJhzhHnjCQpsQeLdKDSdwdm34dBajPC3Kwzdmj/8jWLlKQHA14G635vETNNPuquuYczzV6XlIj4xgr6vSEjO0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CFkwAzDbnM+6fr8oaghD3/GiUHCe0E2goDYodXrWc5o=; b=hAK+OaUc94CDMuqGfgXmKh98HIv0QhGMtdXhR1Bil4PpNCWBNEb8M5aS9vWGtOOcZYDUt12JVXOI1Fd7tffrdDRrOf6y5LnbQQTj3y6t6lCMyz/uXkjlp0hAuJUzgXBGOOD3yo+ta9zyc4znfArnw1K0Fh4SachZlHxlnuBWH9RXGmWN6O5UnHqIHPCQXVwOL+8fqDpl2WLZ1rTQjn2/hk8DQja9DEUsU3W8l59neoC74LKgO5eWUFZjnglrKxywyq17Wl1KOa7Cuv7N4L3gpC0MRKrRAefVNqcuwHsxaWdUfulJ/B4bX83fwz5w4aIyoHtk0HvbnxSa3WSv+txG0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CFkwAzDbnM+6fr8oaghD3/GiUHCe0E2goDYodXrWc5o=; b=YzOEhVs+NhlaFuBJsfGGc/IdDiU3s0EWndp5bve/S5i+T/S1723pUD8VAMRAPffR2VgM27ZhQCw9Q8HJQU4sX4D1aAXpfSUTCoLiCzcPfM70SHcm5PpkP9u9YcRUK0tfQb5q+oQl9VcM5WVu++i9RmuyiGj/bluozgxmtYfsKvY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; Received: from SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) by SA0PR21MB1883.namprd21.prod.outlook.com (2603:10b6:806:e9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.9; Thu, 4 May 2023 22:54:54 +0000 Received: from SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274]) by SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274%4]) with mapi id 15.20.6387.011; Thu, 4 May 2023 22:54:54 +0000 From: Dexuan Cui To: ak@linux.intel.com, arnd@arndb.de, bp@alien8.de, brijesh.singh@amd.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, haiyangz@microsoft.com, hpa@zytor.com, jane.chu@oracle.com, kirill.shutemov@linux.intel.com, kys@microsoft.com, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com, tglx@linutronix.de, tony.luck@intel.com, wei.liu@kernel.org, x86@kernel.org, mikelley@microsoft.com Cc: linux-kernel@vger.kernel.org, Tianyu.Lan@microsoft.com, Dexuan Cui Subject: [PATCH v6 4/6] x86/hyperv: Support hypercalls for TDX guests Date: Thu, 4 May 2023 15:53:49 -0700 Message-Id: <20230504225351.10765-5-decui@microsoft.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230504225351.10765-1-decui@microsoft.com> References: <20230504225351.10765-1-decui@microsoft.com> X-ClientProxiedBy: CYXPR03CA0033.namprd03.prod.outlook.com (2603:10b6:930:d2::10) To SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR2101MB1101:EE_|SA0PR21MB1883:EE_ X-MS-Office365-Filtering-Correlation-Id: 89448e2e-5c5d-47c4-6713-08db4cf29379 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: by20hvDjI1RD/GgkhCXuJgWKWNUQO8BHIXNNeTNuwyIW3BNCQTJ1M//0POivWpLwBlUk2k2qILH6J7GCYa9ZF/oEUMPEiyWALdWe4E3eOmpoux4/RenZWuI4tG9qTU78tFs8RR7TfPgRJJYaUitAtapptaA8sBHUUmVqtfi6FAtSxRn+fOSB8Kam0F7GKsBgztIHY0HBPddbFtQhYwDwUAACViTVVj9l1PQtaCmE74JRD2AkkPlXaQHORP+mCQ+2b8TPoPYrd7vGVBByFsf2l3UhAHCZSKbGkwI1V2i/nnTdyVGzMK6ga/RczN2FnPQWhWCA1iMQ1oDFinz/5CmtfEeyBA6jDP92zEYPk02TdekQwXDTg/Eiwy6vOb2Vg1hAcpChr74INC/rNrTQJBRgIq3DwN+DTqvM8NkBsxBkYlrlKKHVEPK0Phm9mFSVcj4+4/bGSND4wLRVWfmGVy2bNhNhkmFzAeztw8HYJxfPOHd1RfrTO3rDWffv5JkcwbXZo28FkG7o6pKTQqv+YkUGWVEntxgi3nSutxxgw1qHlQm9FWieaXuKIxc6nn+5pCuUU9r+vFH1DVWNuBGMqdRiBZJnjp48tDz9qfRTixMgAzD8S80G+WX5pROToxxnG4/eI8YzrasMgFRLUuflNj6VzQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR2101MB1101.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(36756003)(86362001)(66946007)(786003)(316002)(66476007)(6666004)(66556008)(52116002)(478600001)(4326008)(6636002)(6486002)(10290500003)(2906002)(82960400001)(8936002)(5660300002)(8676002)(7416002)(38100700002)(921005)(186003)(82950400001)(107886003)(6512007)(1076003)(6506007)(2616005)(41300700001)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?22lNv78yYcSQSHuQI9pXertietr97MQjnnrdyxqaCYqgkEDxkSJoVurYedWd?= =?us-ascii?Q?d1p+qaVPmEWYvYPH5lXdltbm16jHVHoWvtHgJyvFVjbXQH8CspMWCPRIganW?= =?us-ascii?Q?AsQ8r1D67rwgkBeYxZ/v0M+RxYkjEx5VK4gy9vpSOqgcNkAAMRU1Z1Zcrcg7?= =?us-ascii?Q?D7mfdFpUZSOgGZaRbG33EKKsZ8L1aDmNE0eVqg4qipE1Qfcc4VnQ6f0y27/H?= =?us-ascii?Q?uJgmxTF2jp7OtmbysQQVbXD2++GXO4xHXzUXqbsTtFzMV++DDO9CsMudY3Im?= =?us-ascii?Q?K8mtDNjVnXGo33VfTjU7GFd6ZH2Mp50h9Cm8+atCmcaCfRdWX4Jxkm9K5luN?= =?us-ascii?Q?2KviE+L3iEr57lRG3xhSKmQbC1vqFdSyYjFnUQSL6usjOx68BuRd/yWK5Ir5?= =?us-ascii?Q?haxSp3AX1l43qe1AXciNwg8bzGAgpVC+ixouGcchXVcBqjo8rRJiQYJWWub8?= =?us-ascii?Q?ALb4KSERo+zkpiNaAFaiwNFrORw01gHgg9SYFYt9sOrCzuxhkMuyuba215MR?= =?us-ascii?Q?7vETmRmQ6BQWp6gKT666nuqrmq7mIICHQVzKqc84RQ+t8kkKVKY7uheH3Gpc?= =?us-ascii?Q?PARpB6mSiu/H8m1+FSfdCPax6TN4+PNw27HzwK7g4gLs9Q2RjtP6vMEPYBxH?= =?us-ascii?Q?lMmjIY3WTYpEd8vPxpgigWCeAhqOa3rYaxSFIPCSH3gwVimB4kUE2cXyYxG3?= =?us-ascii?Q?KEwjfpGkcjNU3UHRjGnFkb4BZwarLyk5zMNaYG/j62LAg7M0rsPplWNvC8K1?= =?us-ascii?Q?43UwRzoav28uGiVqMS0TrR90I8hQ0APK9eWLPpgCJTxGnMmq+2lfRcqa6KuT?= =?us-ascii?Q?XG/85dHPn9riuZNwFoOiAugacgZM8flLmV9oeyW3219DRgYPG0E1stqGV3bI?= =?us-ascii?Q?5xryujReb5akxdl4lf4vSPDs9oajSvV5CEe9KQzdCtArttAQBw0nokA4JUoV?= =?us-ascii?Q?Q0DZGRYpYG6B9YYCGX2CLkAG+ID530oJS3C9Uxn4X5yf+4RskL3yBh5MGFRi?= =?us-ascii?Q?QtOAHywU4191vXj69b9QpaHi2yWnFJYLhSkUvYwtCmz9DpqLZqu+SvTt2CGq?= =?us-ascii?Q?03zu45AHrq8MdKq9rH1V12BxvwRYe/FgiHpOIAmX+0+/r9oyJYn5wGeWYtXp?= =?us-ascii?Q?ndbkMV3mcAtLs2kQNZFImfqwDqkbO3FZZlnR9J8Xe9BbkPqeXjLitPRcb8cr?= =?us-ascii?Q?m4xM/k5zR786TcRdSZ/Cy9xpRhU4w6TrE7EdM/amFecP5IIA4P4becjShoGL?= =?us-ascii?Q?mCGLY1S1pyJerOThhqaqDYN9gELK0l5PSMF70iJHZHZxvt81nlonf17tpV9V?= =?us-ascii?Q?Ub2PIq/jU1PwspgOgEHCjeliDo1Du3hve4x2755e3AiZ5KxvqHj6KjRjVhP3?= =?us-ascii?Q?cKLDEQR+sdDAsFLDFYvtQVpHoZM/KP6h2+txloDsCQ2IYYbbVUnTK9bvzghl?= =?us-ascii?Q?lwfN6u1sYApABLGEu+AcnkRD+LsU818an64Yipjw6DDC//d46IY1ttqyJI1F?= =?us-ascii?Q?efYTRf/9fFeE0lUmEt9D83kCcXscRgT8Rk6jnmXmvJrWVlCsAjuc6xJDEwIy?= =?us-ascii?Q?yIlnhOLOhwMzUuemZAey6rx6qTQlrmgyV9m2AhfXTM+Eg0YQFESWS+1F61mr?= =?us-ascii?Q?y4OjTpfC1+V1EBq3FO/iZ1Jqg8e8rf1fpWQhSDvA0otB?= X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89448e2e-5c5d-47c4-6713-08db4cf29379 X-MS-Exchange-CrossTenant-AuthSource: SN6PR2101MB1101.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 22:54:54.5230 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hoz1HvYb1lr3LfSpLo4vtCH9zEdeizZWXxdeD7XqWlIBobBmpkoPvWeEojlm6WrId5OMaZjDtz3dmiKDGcGapg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR21MB1883 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A TDX guest uses the GHCI call rather than hv_hypercall_pg. In hv_do_hypercall(), Hyper-V requires that the input/output addresses must have the cc_mask. Reviewed-by: Kuppuswamy Sathyanarayanan Reviewed-by: Michael Kelley Signed-off-by: Dexuan Cui --- Changes in v2: Implemented hv_tdx_hypercall() in C rather than in assembly code. Renamed the parameter names of hv_tdx_hypercall(). Used cc_mkdec() directly in hv_do_hypercall(). Changes in v3: Decrypted/encrypted hyperv_pcpu_input_arg in hv_common_cpu_init() and hv_common_cpu_die(). Changes in v4: __tdx_hypercall(&args, TDX_HCALL_HAS_OUTPUT) -> __tdx_hypercall_ret() hv_common_cpu_die(): explicitly ignore the error set_memory_encrypted() [= Michael Kelley] Added Sathyanarayanan's Reviewed-by. Changes in v5: Added Michael's Reviewed-by. Changes in v6: None. arch/x86/hyperv/hv_init.c | 8 ++++++++ arch/x86/hyperv/ivm.c | 14 ++++++++++++++ arch/x86/include/asm/mshyperv.h | 17 +++++++++++++++++ drivers/hv/hv_common.c | 24 ++++++++++++++++++++++++ 4 files changed, 63 insertions(+) diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index a5f9474f08e1..f175e0de821c 100644 --- a/arch/x86/hyperv/hv_init.c +++ b/arch/x86/hyperv/hv_init.c @@ -432,6 +432,10 @@ void __init hyperv_init(void) /* Hyper-V requires to write guest os id via ghcb in SNP IVM. */ hv_ghcb_msr_write(HV_X64_MSR_GUEST_OS_ID, guest_id); =20 + /* A TDX guest uses the GHCI call rather than hv_hypercall_pg. */ + if (hv_isolation_type_tdx()) + goto skip_hypercall_pg_init; + hv_hypercall_pg =3D __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, @@ -471,6 +475,7 @@ void __init hyperv_init(void) wrmsrl(HV_X64_MSR_HYPERCALL, hypercall_msr.as_uint64); } =20 +skip_hypercall_pg_init: /* * hyperv_init() is called before LAPIC is initialized: see * apic_intr_mode_init() -> x86_platform.apic_post_init() and @@ -594,6 +599,9 @@ bool hv_is_hyperv_initialized(void) if (x86_hyper_type !=3D X86_HYPER_MS_HYPERV) return false; =20 + /* A TDX guest uses the GHCI call rather than hv_hypercall_pg. */ + if (hv_isolation_type_tdx()) + return true; /* * Verify that earlier initialization succeeded by checking * that the hypercall page is setup diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c index 952117ce2d80..61ff7060b39b 100644 --- a/arch/x86/hyperv/ivm.c +++ b/arch/x86/hyperv/ivm.c @@ -415,3 +415,17 @@ bool hv_isolation_type_tdx(void) { return static_branch_unlikely(&isolation_type_tdx); } + +u64 hv_tdx_hypercall(u64 control, u64 param1, u64 param2) +{ + struct tdx_hypercall_args args =3D { }; + + args.r10 =3D control; + args.rdx =3D param1; + args.r8 =3D param2; + + (void)__tdx_hypercall_ret(&args); + + return args.r11; +} +EXPORT_SYMBOL_GPL(hv_tdx_hypercall); diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyper= v.h index 231e56631295..945e5afaba69 100644 --- a/arch/x86/include/asm/mshyperv.h +++ b/arch/x86/include/asm/mshyperv.h @@ -10,6 +10,7 @@ #include #include #include +#include =20 /* * Hyper-V always provides a single IO-APIC at this MMIO address. @@ -54,6 +55,12 @@ int hv_call_deposit_pages(int node, u64 partition_id, u3= 2 num_pages); int hv_call_add_logical_proc(int node, u32 lp_index, u32 acpi_id); int hv_call_create_vp(int node, u64 partition_id, u32 vp_index, u32 flags); =20 +u64 hv_tdx_hypercall(u64 control, u64 param1, u64 param2); + +/* + * If the hypercall involves no input or output parameters, the hypervisor + * ignores the corresponding GPA pointer. + */ static inline u64 hv_do_hypercall(u64 control, void *input, void *output) { u64 input_address =3D input ? virt_to_phys(input) : 0; @@ -61,6 +68,10 @@ static inline u64 hv_do_hypercall(u64 control, void *inp= ut, void *output) u64 hv_status; =20 #ifdef CONFIG_X86_64 + if (hv_isolation_type_tdx()) + return hv_tdx_hypercall(control, + cc_mkdec(input_address), + cc_mkdec(output_address)); if (!hv_hypercall_pg) return U64_MAX; =20 @@ -104,6 +115,9 @@ static inline u64 _hv_do_fast_hypercall8(u64 control, u= 64 input1) u64 hv_status; =20 #ifdef CONFIG_X86_64 + if (hv_isolation_type_tdx()) + return hv_tdx_hypercall(control, input1, 0); + { __asm__ __volatile__(CALL_NOSPEC : "=3Da" (hv_status), ASM_CALL_CONSTRAINT, @@ -149,6 +163,9 @@ static inline u64 _hv_do_fast_hypercall16(u64 control, = u64 input1, u64 input2) u64 hv_status; =20 #ifdef CONFIG_X86_64 + if (hv_isolation_type_tdx()) + return hv_tdx_hypercall(control, input1, input2); + { __asm__ __volatile__("mov %4, %%r8\n" CALL_NOSPEC diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c index 6156114cd9c5..5b32adff0e61 100644 --- a/drivers/hv/hv_common.c +++ b/drivers/hv/hv_common.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include =20 @@ -359,6 +360,7 @@ int hv_common_cpu_init(unsigned int cpu) u64 msr_vp_index; gfp_t flags; int pgcount =3D hv_root_partition ? 2 : 1; + int ret; =20 /* hv_cpu_init() can be called with IRQs disabled from hv_resume() */ flags =3D irqs_disabled() ? GFP_ATOMIC : GFP_KERNEL; @@ -368,6 +370,17 @@ int hv_common_cpu_init(unsigned int cpu) if (!(*inputarg)) return -ENOMEM; =20 + if (hv_isolation_type_tdx()) { + ret =3D set_memory_decrypted((unsigned long)*inputarg, pgcount); + if (ret) { + /* It may be unsafe to free *inputarg */ + *inputarg =3D NULL; + return ret; + } + + memset(*inputarg, 0x00, pgcount * HV_HYP_PAGE_SIZE); + } + if (hv_root_partition) { outputarg =3D (void **)this_cpu_ptr(hyperv_pcpu_output_arg); *outputarg =3D (char *)(*inputarg) + HV_HYP_PAGE_SIZE; @@ -388,6 +401,8 @@ int hv_common_cpu_die(unsigned int cpu) unsigned long flags; void **inputarg, **outputarg; void *mem; + int pgcount =3D hv_root_partition ? 2 : 1; + int ret; =20 local_irq_save(flags); =20 @@ -402,6 +417,15 @@ int hv_common_cpu_die(unsigned int cpu) =20 local_irq_restore(flags); =20 + if (hv_isolation_type_tdx()) { + ret =3D set_memory_encrypted((unsigned long)mem, pgcount); + if (ret) + pr_warn("Hyper-V: Failed to encrypt input arg on cpu%d: %d\n", + cpu, ret); + /* It's unsafe to free 'mem'. */ + return 0; + } + kfree(mem); =20 return 0; --=20 2.25.1 From nobody Fri Sep 12 22:33:58 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A877C7EE21 for ; Thu, 4 May 2023 22:55:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229978AbjEDWzO (ORCPT ); Thu, 4 May 2023 18:55:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbjEDWzA (ORCPT ); Thu, 4 May 2023 18:55:00 -0400 Received: from DM5PR00CU002.outbound.protection.outlook.com (mail-centralusazon11021016.outbound.protection.outlook.com [52.101.62.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6A5C11DB0; Thu, 4 May 2023 15:54:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VXPPikV3EySHSo6r7tVD1Hs+rxlWQ1K5bu5ty995M4ZOSrl4Q97bzuqDJd4kO3YlC62lx6QwtuMvrp+nMrAv0iiQYNVO4yKJFRgDlc2R3su9B2xJGblRHrXipSxlSwIsCk4ezu2MXna2D/YoGPlA47Q/SaWqN1e7/VGsOf4SdV8IhFw6EeBzsnSBaXDgWTxS8HkXAqu9AR+hOPeOUyHNb80v7E0LM8eVdG6lVlAQF/U8LZLUEtJ8eUkr81GCmSced+Wg7qvmUR0go4FEyDy707ZmEvwA9nW8H7bGkw/fW2xWq8V9CJIiQp/iF3YvaZjQiCo7QmRaqYmaJWKG8u0jXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fta8+0e6UUqJv4EdrFHymmWFDpNIxydJnyKMfTInjP8=; b=SYMpkQ5hu8tQSzicVfEy12GzWhPySXxI/vetb+RVamyx6syf1skdxhTGDXhF/5d6Gb7WO8+Ivuq7Ry91WaHPPIS6oxu8N5P6FpNhXQyTppfNRzc43Ev7swbCQQ4FGWmLT3Fie7djI8FRHAI+OcO60fkYBVVJVQgkfoOnilFpd7zyr/xK3TJLqTvKhUa7rygt1laiYZTTjVq7bav7rNhE8uS+PugH7RNHxVZkSgQci6JSRO6yNWAPo4loYVGmO/aVTUnbKFT7YVvinCbw0mTZIwb5e0kmVnU3ab2Q9T4mJyNJcBDtFrmMCm8nuSuDoawWIP6s/tUEpy8NnFzAQned2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fta8+0e6UUqJv4EdrFHymmWFDpNIxydJnyKMfTInjP8=; b=Yn/igQO671cG4+DGq4aELueRRXoskKWwqItM/3uhYqQ40u3sxqpvCRquGxYDUbH/XufW8WOpa64cN1rah6EMkSfZUi98hCRnTGpqY/jVfw1R4rsvqp6hlF6wA4ep5poXVkov8wr6Daduth42knUajECus9hJlXnPLdz0P6qpPyM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; Received: from SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) by SA0PR21MB1883.namprd21.prod.outlook.com (2603:10b6:806:e9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.9; Thu, 4 May 2023 22:54:56 +0000 Received: from SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274]) by SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274%4]) with mapi id 15.20.6387.011; Thu, 4 May 2023 22:54:56 +0000 From: Dexuan Cui To: ak@linux.intel.com, arnd@arndb.de, bp@alien8.de, brijesh.singh@amd.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, haiyangz@microsoft.com, hpa@zytor.com, jane.chu@oracle.com, kirill.shutemov@linux.intel.com, kys@microsoft.com, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com, tglx@linutronix.de, tony.luck@intel.com, wei.liu@kernel.org, x86@kernel.org, mikelley@microsoft.com Cc: linux-kernel@vger.kernel.org, Tianyu.Lan@microsoft.com, Dexuan Cui Subject: [PATCH v6 5/6] Drivers: hv: vmbus: Support TDX guests Date: Thu, 4 May 2023 15:53:50 -0700 Message-Id: <20230504225351.10765-6-decui@microsoft.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230504225351.10765-1-decui@microsoft.com> References: <20230504225351.10765-1-decui@microsoft.com> X-ClientProxiedBy: CYXPR03CA0033.namprd03.prod.outlook.com (2603:10b6:930:d2::10) To SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR2101MB1101:EE_|SA0PR21MB1883:EE_ X-MS-Office365-Filtering-Correlation-Id: 37130880-6321-45be-cb6f-08db4cf29486 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hnyDPcjG5FoKN4ulnqqR3C6CoSIKa3vpHECnn4eJh/7/Bh+Dd4y17mN+47NC2bwy3uKvka7HFvWbu5FEdSwOVG4hgWvaCvGAdoFg6hbWAIwGDFbQdJYVB+RdXeNAjNRqJBEsq7whAWfueZCl8MoeU+fgvMfx/KQIYHsM7vxR+s0KijEJ0/dZW7L8X7HD7SPhMO2budvOH+hqgAGsPfQAX/mnhMPfvv9HjMS5TRLyEH67Hex9QfSpm/8Ak9sHT1Bi+HUf5sGxt1smVRcuS7NqG1kdD/oJ/ceydG/SWFW256+aZDzzuCfZ1R5mECft65LbZX181nPTlogntESefkimwLcjy6sDEEvM0BLvZiTy9t9hszGWLu03KnswHrkQlY0/FnB6SmBFN9bqWb0pRQDM3kyxFwwGpQg+hof98m1vcNgXZl6kv7QXsFMuADoYClQ7mrKsX5nsIsoDjXCK/gzF+99r1vuqFyCl5YUkGPfkUo8dqER1obv3jSOZJ4XUegVE03kqNSVC5oNSw7kWSAV9ox7bvmSPaASo4aW09nZTkAt95znJL+8ETRzUt2u5AMIRpZ04LrGFciRaxMSKrr5GOGo8c3hL4RiS+c+UYH0VwZVFh9ObvpGHIVb78BDTFg3DujkBxtdLh/ySHXpmAuh5xw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR2101MB1101.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(36756003)(86362001)(66946007)(786003)(316002)(66476007)(6666004)(66556008)(52116002)(478600001)(4326008)(6636002)(6486002)(10290500003)(2906002)(82960400001)(8936002)(5660300002)(8676002)(7416002)(38100700002)(921005)(186003)(82950400001)(107886003)(6512007)(1076003)(6506007)(2616005)(41300700001)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?USHDpZoWOM+cnTxl2gyLMBSlYKnLP3YaJW2rVDwvFa3E3ybXEFcmdwtoCT5+?= =?us-ascii?Q?FK+fTyMvv8rtjXZI9IiaU7XFxcOLIxVMZ7hWGpcIX64l6TnNfGx85S9NSsh7?= =?us-ascii?Q?pxyUOscKErwH6cDxObnMMc7lSNw3WIo4Tm+gKg+gb94fQkhAjFKuBE0+cj7D?= =?us-ascii?Q?Dbh8TTmgPNDNP/DdzEdiak/09W1jO3m1d05FLf+UDKTyc05I11x3YcItr7sS?= =?us-ascii?Q?azN8hq8IBhvHVw/WOTcwPpjLt9KQG9RwQ2Z/FAizfljJ4H1G7LH01cLNMJ/H?= =?us-ascii?Q?gAYiua5xdgZGzD5ZY4zqYsPslSOHaPoBxQGBsbPaUwZ5K+dCBLzQeed7jrST?= =?us-ascii?Q?lORHKfOpNWHejRCO8MS8UgsvwW7+ZkMpLpClPw3XlQE+0jK9tzONTsH/tjuD?= =?us-ascii?Q?NmDRggNMXHO0UACU5sXAEmb2BE1+RQTStmXwzH5sD67mT+cWmtkeL1fCy/oq?= =?us-ascii?Q?FFQsgYQ21LFSYDqRp0ngSz14U2Bwq2DL0C/T0SG2Im/Z2LAbS+2r+3crrnS4?= =?us-ascii?Q?wGI9ViSVOiMbTHV9Qmpf/UDefvrye0ZkRrqikdBK9z3QaGmCbwB7ly0C90RT?= =?us-ascii?Q?oZmlJZb0pVU3ClS7cP139y2sdJdHlqDBRCkkbSCEKT3NzaBtZtHBduJAudZH?= =?us-ascii?Q?4SnKY1Y/gBj2gIdnp2RkH9e3+VF7klizSBrYNeBOPXYXV0BustgttyBF/e+I?= =?us-ascii?Q?caCDZGzS9rBXuMTD2fmiC7ovzEM2QBdir+bWZCqrmctdrTyk0PXAlKvr362O?= =?us-ascii?Q?FRJvTxYMg8r+mT2Bs1Io0R53OuSYCSrVrDp/2T7bEw7m+XdfKOJ5ZrBKaDcl?= =?us-ascii?Q?OTVxGmFO38dTJ8iMZ/YopqjzOEHnl/tj4Oxa6rkkJSLLoOB7yvBj2znVE0Ea?= =?us-ascii?Q?RFnMTZdNVbjH3jR/S+nXivZkp2Ruv/4JOWAqmUBdIY8pQVmCXNugZ1hvMA6j?= =?us-ascii?Q?OPA5HcbIJzSHfIQ2Cllri1izPagNVHkJil1nybCxQqf+ZSFBEEym0L4IHMWI?= =?us-ascii?Q?Nm37JZPPGKL2uQpoBElfTY35gT8i8NuPZUg7eY5/nVfwMGDW8jAJDrLYhWHC?= =?us-ascii?Q?z2OfqlfhUt1Scq83xSsLMoCvKBK7R6FSMOUxqhK6U3X9j1DV0qY7rKV0X0/1?= =?us-ascii?Q?2ThXksB/eO5ByMqT2tnnplD16zQkfdq29vdXzublmOm0J7FMl+uYcoAMCJiJ?= =?us-ascii?Q?spT4nu70pYxyzG+HbXZ+DveZGmSwMw6kTWwx89xj+JCjIyjXFSvcIN7mnR+p?= =?us-ascii?Q?k7vl+x4QvBw6jh5gJv3IPaM8+NbTzy1+YJkwXM2daQmO3l05Cv8wpBmGhu1N?= =?us-ascii?Q?TDbyCT7pASAanb6Q4P0JeFawg3MY9IWkPZm2wSvi+1LPb17JWnBiGs7IuSc9?= =?us-ascii?Q?RVVR9dN+PYrRTi9p6q8i5KqEHrrhNIheWwfH/G1FW6WLG0OsNHHH6eA+wuiT?= =?us-ascii?Q?OdwFv4iP11ud1Dmh19Em3j2k5CC3TZ99juvvXkcDWXNC/sZLBuqjahhfZWcN?= =?us-ascii?Q?SGn+KkDsKd8CBbxhDhZFf6OoxOlkZQZHCNUPHs0wRfvNOtCo1oMcgG0EqlR2?= =?us-ascii?Q?srn0FAyyFAISNnBH4oRAWpq0HI1698euSvsOq0BnRipyv4R9YY/juW1+92xi?= =?us-ascii?Q?24D/QqA1KfLpaFfF1p5g1nqtVqPcDroagALg0O/Xs5wb?= X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37130880-6321-45be-cb6f-08db4cf29486 X-MS-Exchange-CrossTenant-AuthSource: SN6PR2101MB1101.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 22:54:56.2236 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0XIzoJKDt+qUJp3bSaCMDHgOfoJ2H4eUye1rohX5jkUikoVU9BIhVl9H1PkA0tG8Zf7UcJoM9DKRHIMVhpoKIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR21MB1883 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add Hyper-V specific code so that a TDX guest can run on Hyper-V: No need to use hv_vp_assist_page. Don't use the unsafe Hyper-V TSC page. Don't try to use HV_REGISTER_CRASH_CTL. Don't trust Hyper-V's TLB-flushing hypercalls. Don't use lazy EOI. Signed-off-by: Dexuan Cui Reviewed-by: Michael Kelley --- Changes in v2: Used a new function hv_set_memory_enc_dec_needed() in __set_memory_enc_pgtable(). Added the missing set_memory_encrypted() in hv_synic_free(). Changes in v3: Use pgprot_decrypted(PAGE_KERNEL)in hv_ringbuffer_init(). (Do not use PAGE_KERNEL_NOENC, which doesn't exist for ARM64). Used cc_mkdec() in hv_synic_enable_regs(). ms_hyperv_init_platform(): Explicitly do not use HV_X64_REMOTE_TLB_FLUSH_RECOMMENDED. Explicitly do not use HV_X64_APIC_ACCESS_RECOMMENDED. Enabled __send_ipi_mask() and __send_ipi_one() for TDX guests. Changes in v4: A minor rebase to Michael's v7 DDA patchset. I'm very happy that I can drop my v3 change to arch/x86/mm/pat/set_memory.c due to Michael's work. Changes in v5: Added memset() to clear synic_message_page and synic_event_page() after set_memory_decrypted(). Rebased the patch since "post_msg_page" has been removed in hyperv-next. Improved the error handling in hv_synic_alloc()/free() [Michael Kelley] Changes in v6: Adressed Michael Kelley's comments on patch 5: Removed 2 unnecessary lines of messages from the commit log. Fixed the error handling path for hv_synic_alloc()/free(). Printed the 'ret' in hv_synic_alloc()/free(). arch/x86/hyperv/hv_apic.c | 6 ++-- arch/x86/hyperv/hv_init.c | 19 +++++++--- arch/x86/kernel/cpu/mshyperv.c | 21 ++++++++++- drivers/hv/hv.c | 65 ++++++++++++++++++++++++++++++++-- 4 files changed, 101 insertions(+), 10 deletions(-) diff --git a/arch/x86/hyperv/hv_apic.c b/arch/x86/hyperv/hv_apic.c index 1fbda2f94184..b28da8b41b45 100644 --- a/arch/x86/hyperv/hv_apic.c +++ b/arch/x86/hyperv/hv_apic.c @@ -177,7 +177,8 @@ static bool __send_ipi_mask(const struct cpumask *mask,= int vector, (exclude_self && weight =3D=3D 1 && cpumask_test_cpu(this_cpu, mask))) return true; =20 - if (!hv_hypercall_pg) + /* A TDX guest doesn't use hv_hypercall_pg. */ + if (!hv_isolation_type_tdx() && !hv_hypercall_pg) return false; =20 if ((vector < HV_IPI_LOW_VECTOR) || (vector > HV_IPI_HIGH_VECTOR)) @@ -231,7 +232,8 @@ static bool __send_ipi_one(int cpu, int vector) =20 trace_hyperv_send_ipi_one(cpu, vector); =20 - if (!hv_hypercall_pg || (vp =3D=3D VP_INVAL)) + /* A TDX guest doesn't use hv_hypercall_pg. */ + if ((!hv_isolation_type_tdx() && !hv_hypercall_pg) || (vp =3D=3D VP_INVAL= )) return false; =20 if ((vector < HV_IPI_LOW_VECTOR) || (vector > HV_IPI_HIGH_VECTOR)) diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c index f175e0de821c..f28357ecad7d 100644 --- a/arch/x86/hyperv/hv_init.c +++ b/arch/x86/hyperv/hv_init.c @@ -79,7 +79,7 @@ static int hyperv_init_ghcb(void) static int hv_cpu_init(unsigned int cpu) { union hv_vp_assist_msr_contents msr =3D { 0 }; - struct hv_vp_assist_page **hvp =3D &hv_vp_assist_page[cpu]; + struct hv_vp_assist_page **hvp; int ret; =20 ret =3D hv_common_cpu_init(cpu); @@ -89,6 +89,7 @@ static int hv_cpu_init(unsigned int cpu) if (!hv_vp_assist_page) return 0; =20 + hvp =3D &hv_vp_assist_page[cpu]; if (hv_root_partition) { /* * For root partition we get the hypervisor provided VP assist @@ -398,11 +399,21 @@ void __init hyperv_init(void) if (hv_common_init()) return; =20 - hv_vp_assist_page =3D kcalloc(num_possible_cpus(), - sizeof(*hv_vp_assist_page), GFP_KERNEL); + /* + * The VP assist page is useless to a TDX guest: the only use we + * would have for it is lazy EOI, which can not be used with TDX. + */ + if (hv_isolation_type_tdx()) + hv_vp_assist_page =3D NULL; + else + hv_vp_assist_page =3D kcalloc(num_possible_cpus(), + sizeof(*hv_vp_assist_page), + GFP_KERNEL); if (!hv_vp_assist_page) { ms_hyperv.hints &=3D ~HV_X64_ENLIGHTENED_VMCS_RECOMMENDED; - goto common_free; + + if (!hv_isolation_type_tdx()) + goto common_free; } =20 if (hv_isolation_type_snp()) { diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index 2fd687a80033..b95b689efa07 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -404,8 +404,27 @@ static void __init ms_hyperv_init_platform(void) =20 if (hv_get_isolation_type() =3D=3D HV_ISOLATION_TYPE_SNP) static_branch_enable(&isolation_type_snp); - else if (hv_get_isolation_type() =3D=3D HV_ISOLATION_TYPE_TDX) + else if (hv_get_isolation_type() =3D=3D HV_ISOLATION_TYPE_TDX) { static_branch_enable(&isolation_type_tdx); + + /* + * The GPAs of SynIC Event/Message pages and VMBus + * Moniter pages need to be added by this offset. + */ + ms_hyperv.shared_gpa_boundary =3D cc_mkdec(0); + + /* Don't use the unsafe Hyper-V TSC page */ + ms_hyperv.features &=3D ~HV_MSR_REFERENCE_TSC_AVAILABLE; + + /* HV_REGISTER_CRASH_CTL is unsupported */ + ms_hyperv.misc_features &=3D ~HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE; + + /* Don't trust Hyper-V's TLB-flushing hypercalls */ + ms_hyperv.hints &=3D ~HV_X64_REMOTE_TLB_FLUSH_RECOMMENDED; + + /* A TDX VM must use x2APIC and doesn't use lazy EOI */ + ms_hyperv.hints &=3D ~HV_X64_APIC_ACCESS_RECOMMENDED; + } } =20 if (hv_max_functions_eax >=3D HYPERV_CPUID_NESTED_FEATURES) { diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index de6708dbe0df..af959e87b6e7 100644 --- a/drivers/hv/hv.c +++ b/drivers/hv/hv.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include "hyperv_vmbus.h" @@ -80,6 +81,7 @@ int hv_synic_alloc(void) { int cpu; struct hv_per_cpu_context *hv_cpu; + int ret =3D -ENOMEM; =20 /* * First, zero all per-cpu memory areas so hv_synic_free() can @@ -120,9 +122,42 @@ int hv_synic_alloc(void) (void *)get_zeroed_page(GFP_ATOMIC); if (hv_cpu->synic_event_page =3D=3D NULL) { pr_err("Unable to allocate SYNIC event page\n"); + + free_page((unsigned long)hv_cpu->synic_message_page); + hv_cpu->synic_message_page =3D NULL; + goto err; } } + + /* It's better to leak the page if the decryption fails. */ + if (hv_isolation_type_tdx()) { + ret =3D set_memory_decrypted( + (unsigned long)hv_cpu->synic_message_page, 1); + if (ret) { + pr_err("Failed to decrypt SYNIC msg page: %d\n", ret); + hv_cpu->synic_message_page =3D NULL; + + /* + * Free the event page so that a TDX VM won't + * try to encrypt the page in hv_synic_free(). + */ + free_page((unsigned long)hv_cpu->synic_event_page); + hv_cpu->synic_event_page =3D NULL; + goto err; + } + + ret =3D set_memory_decrypted( + (unsigned long)hv_cpu->synic_event_page, 1); + if (ret) { + pr_err("Failed to decrypt SYNIC event page: %d\n", ret); + hv_cpu->synic_event_page =3D NULL; + goto err; + } + + memset(hv_cpu->synic_message_page, 0, PAGE_SIZE); + memset(hv_cpu->synic_event_page, 0, PAGE_SIZE); + } } =20 return 0; @@ -131,18 +166,40 @@ int hv_synic_alloc(void) * Any memory allocations that succeeded will be freed when * the caller cleans up by calling hv_synic_free() */ - return -ENOMEM; + return ret; } =20 =20 void hv_synic_free(void) { int cpu; + int ret; =20 for_each_present_cpu(cpu) { struct hv_per_cpu_context *hv_cpu =3D per_cpu_ptr(hv_context.cpu_context, cpu); =20 + /* It's better to leak the page if the encryption fails. */ + if (hv_isolation_type_tdx()) { + if (hv_cpu->synic_message_page) { + ret =3D set_memory_encrypted((unsigned long) + hv_cpu->synic_message_page, 1); + if (ret) { + pr_err("Failed to encrypt SYNIC msg page: %d\n", ret); + hv_cpu->synic_message_page =3D NULL; + } + } + + if (hv_cpu->synic_event_page) { + ret =3D set_memory_encrypted((unsigned long) + hv_cpu->synic_event_page, 1); + if (ret) { + pr_err("Failed to encrypt SYNIC event page: %d\n", ret); + hv_cpu->synic_event_page =3D NULL; + } + } + } + free_page((unsigned long)hv_cpu->synic_event_page); free_page((unsigned long)hv_cpu->synic_message_page); } @@ -179,7 +236,8 @@ void hv_synic_enable_regs(unsigned int cpu) if (!hv_cpu->synic_message_page) pr_err("Fail to map synic message page.\n"); } else { - simp.base_simp_gpa =3D virt_to_phys(hv_cpu->synic_message_page) + simp.base_simp_gpa =3D + cc_mkdec(virt_to_phys(hv_cpu->synic_message_page)) >> HV_HYP_PAGE_SHIFT; } =20 @@ -198,7 +256,8 @@ void hv_synic_enable_regs(unsigned int cpu) if (!hv_cpu->synic_event_page) pr_err("Fail to map synic event page.\n"); } else { - siefp.base_siefp_gpa =3D virt_to_phys(hv_cpu->synic_event_page) + siefp.base_siefp_gpa =3D + cc_mkdec(virt_to_phys(hv_cpu->synic_event_page)) >> HV_HYP_PAGE_SHIFT; } =20 --=20 2.25.1 From nobody Fri Sep 12 22:33:58 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43822C7EE21 for ; Thu, 4 May 2023 22:55:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229671AbjEDWzS (ORCPT ); Thu, 4 May 2023 18:55:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjEDWzB (ORCPT ); Thu, 4 May 2023 18:55:01 -0400 Received: from DM5PR00CU002.outbound.protection.outlook.com (mail-centralusazon11021016.outbound.protection.outlook.com [52.101.62.16]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A355C11D80; Thu, 4 May 2023 15:55:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eUUxYgSPOQ6gBHLL8mrJLyODeI7hSxL0NvZPTOmEM2EId0T9J83XNDhoYGhzK5kKKgZfmKrjQHLKv8xSPDDGgvGgdA3sZdmex2qmN2bOdGOvF9/Sseyzns0Fl5XBMhZmZx7lS+kEsHOKhVFLQMaiurJssgo6FHyHphj5iaGcKHlYw38j4dA3cDvUa+I6aZsgKYp1hcIYr8KS7HfQRxpSSS0gPaJMIiGT2+aSsqar05uaZZ1XGFYv7ey20rQ1aoseNPSNZNSeQqYiiSSvm7W9ZMluHXH5uf50jypQ5Gc9O3MoO259gw3HOTzzI89hLvVJzUxZhZyj5DTQTmpD0k3oiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gYTwF3ysij5dBJdPszhBGN2we1FO+93mfEPlBFvWdXg=; b=j49jUn4pitL4m+98pEvK+Zw5nkDqqzbIea5n2JVe2eEUKz67w5wev2uJTJL1urPRpjReI+0FZ0VoOgjLmrRjdsr+XD9dCPe/LLWLi43gj+/xdBN7we/fMe78MiI6ZMWulzCI/rmMyO3p2jrYjX2p3he0uuqjVP+Q+1K1Fvgn8CohY0zgFCMz3PJmJusViIT6dGzPTOgRMr1l3cxGv1diUJCvF7S1sfJ/NeCW4j+86e5zAKjPoI8EV+dN2y5yVVGbPJs1bGiouUBklx23va9uLBywSqJ7+LvPsSyVgMnKPBrlzsy250IqStDf5tiMMt5z71IMxZReWXHse9Dzlz+dtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gYTwF3ysij5dBJdPszhBGN2we1FO+93mfEPlBFvWdXg=; b=FD9Ib+U/RzqjOSs2BhuEybcJYIS4bBEzCXb+YwudwGW4LtbBFjCCOx9eYfyelEso5ihdijcwrgLFHIUK8QXnmLHhU7l6XoKBFteXo6sboL7lv2wpaNqu1fyMxOvgM8tZDbDco6H34vmEEjREuiBtCsxtlzQT4roj/aZi/D0VYY4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; Received: from SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) by SA0PR21MB1883.namprd21.prod.outlook.com (2603:10b6:806:e9::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.9; Thu, 4 May 2023 22:54:58 +0000 Received: from SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274]) by SN6PR2101MB1101.namprd21.prod.outlook.com ([fe80::b2eb:246c:555a:b274%4]) with mapi id 15.20.6387.011; Thu, 4 May 2023 22:54:58 +0000 From: Dexuan Cui To: ak@linux.intel.com, arnd@arndb.de, bp@alien8.de, brijesh.singh@amd.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, haiyangz@microsoft.com, hpa@zytor.com, jane.chu@oracle.com, kirill.shutemov@linux.intel.com, kys@microsoft.com, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, rostedt@goodmis.org, sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com, tglx@linutronix.de, tony.luck@intel.com, wei.liu@kernel.org, x86@kernel.org, mikelley@microsoft.com Cc: linux-kernel@vger.kernel.org, Tianyu.Lan@microsoft.com, Dexuan Cui Subject: [PATCH v6 6/6] x86/hyperv: Fix serial console interrupts for TDX guests Date: Thu, 4 May 2023 15:53:51 -0700 Message-Id: <20230504225351.10765-7-decui@microsoft.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230504225351.10765-1-decui@microsoft.com> References: <20230504225351.10765-1-decui@microsoft.com> X-ClientProxiedBy: CYXPR03CA0033.namprd03.prod.outlook.com (2603:10b6:930:d2::10) To SN6PR2101MB1101.namprd21.prod.outlook.com (2603:10b6:805:6::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR2101MB1101:EE_|SA0PR21MB1883:EE_ X-MS-Office365-Filtering-Correlation-Id: f3293166-61be-40d2-a6a8-08db4cf2958a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LAJcCdgylsL89XcP7cmTJO4YkNXdz854a1jID+JQKeWnrUXcMpxvENQp+L5z2c8IXesWtdQMJLEsT2tZBVT2n6IyPx5sDFsA9/JRE81zXRVjBFRYIwExMYRn9r19+0OvHbKxQ/HyuL9ovaJRDG2eOUCvwTiiM326kAaTAzXM9UwLKHMQ/GFgItf1NB9WYjGHjO72gSxY0rtXy+nTeWW1fx/d07Gsl1BukFSylp0uog10oq3LU8UqUXJW0Nuq2ry9lu/56W8C1JjKzXRMuYmAErdXGVcIPLZRmQ/rNzHTDabDOKQcdoMAUMLfq1Maig9XJ21UczAQ1qmZ3ptIAC6h0zILbFGUF4zL3TU+ABfFTxQclwmcau0WwwPJjt1g0z19+z/Dj8h7NpfiU/Lg/2JFU/JjuzyoNJZrnexA6mJl1x2gADzqQRqSELugdwMUYypAtQhVwVu0sCHirRfivbQHKJbufzp8DGjHfeijwyaiToA50vqhr6R9BF/rBaCdaRbgbrhiyQSXWFmFCyD6AbXMwEHEcPc5I8XEqBUvF58MuY1y+2eNiQGIuRtrFUFHH0yaEI0G8naiTNoAq/SRJkXVrLFN7z31bF1cNxYKBndmRaBnf+/lBQtvc3OYSj1JXUl/Krk1lgdyU85qXZcQYZ7y6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR2101MB1101.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(451199021)(36756003)(86362001)(66946007)(786003)(316002)(66476007)(6666004)(66556008)(52116002)(478600001)(4326008)(6636002)(6486002)(10290500003)(2906002)(82960400001)(8936002)(5660300002)(8676002)(7416002)(38100700002)(921005)(186003)(82950400001)(107886003)(6512007)(1076003)(6506007)(2616005)(41300700001)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1WKmsivE/J79iGEW1IXzXaH607YVDPCGnOTRrrMDCjsiW8SJz1oF+u/y2cHV?= =?us-ascii?Q?icQ8ngiJTLIDnIrK/qQDdF53TiG2HQ66OJwGQzbTkYWlIPSRqQO2FmXx8HYX?= =?us-ascii?Q?3dUMeo5f+FPZg+kccn/kwrgrn6MFnwHEfuWJ5RkQA9+riPcgt9o5Il2pJmZJ?= =?us-ascii?Q?sVqHZJCjTrE4cOy1GsrGha+KUr9VAmoTxTk6tUtmcyZTl9XxeLQnQFKu4lY+?= =?us-ascii?Q?vczIMCfh2nR+cgLxcQe+jNUkEPShqeCTCtpwZAnST0rzmEr+E9xICKIgl7J4?= =?us-ascii?Q?c6R2rISnFpzioAn7meaOKoOv2izU/BZJqXdmEd20KaDCClUCxkcPbTI0mSyJ?= =?us-ascii?Q?6yP4LBHUWyJtS7+985BsW9qviwnWx73SQ0dim7qU692z4Ajvs3yKugjiCy+e?= =?us-ascii?Q?SsRWlkXOaSGl2tKZXPKaNei6wd36YXJsByqc5awQmRb9saWwh3hijsjqXUwL?= =?us-ascii?Q?1e3fEzw0UCbkIrsrgEpgAnDJsIXHhhPt73yDdjlAtrRxM/1qaTyw/etBt7vH?= =?us-ascii?Q?WjGEeP6m2sI5XoH1WLYGkJtg4xDSe2uy8a4+jHxFbtZ6zCqUDT8WquiVZpnd?= =?us-ascii?Q?ZUiNEg3mZCkk0oJrWY9OCtg3rdxHUleidA20Oxt0vHuEQ55aH3w+Q5Tuk8Em?= =?us-ascii?Q?ZyUYPKnyqz7mxpSLtcKHneA31KYe1JjYLHu5kdiSVCD4Ffhs7XUyp5FuYLHw?= =?us-ascii?Q?zrDuIIGIyp+ji+5HcS4OUg+/VJojByjFGmSzAen0DGW8QSo4Tc289qbp7t9v?= =?us-ascii?Q?PkoJ5QjM020VZgq7WK25DQpew2SzkWUmhAkt+HLRHOX9guodKbqfwfqt5iGC?= =?us-ascii?Q?85WO2+DMWQtx1zsin6Mwp4UfE25nJZz1dVpihg1shCZmmca1Ppr6hXYuRGer?= =?us-ascii?Q?l4bgheDfVzrVBzumw3Lshlq2UwpRBjDXwR6D6KbXpW07ZmwUz8UP7nlNPqK2?= =?us-ascii?Q?M2EJ0TGl8FyLeXk2f0fAs36Tu08ttn70A4YClzENBi0/KEt1Cp2irPwEmOAO?= =?us-ascii?Q?88/X9rvS8dZD54g/MW4X0G9OWYhhpHsmHRnFFiobJD4mPY/pwgdGSx4KTWVd?= =?us-ascii?Q?kj97443wGWvOzBeZP8OdZ37tqdvBy1GEhUftXSeGIQsuHSvXk3LrV/1eA6ho?= =?us-ascii?Q?GTjWHHAVpl4mX8SrXVocG6Xt1W7A4Fz36TaKNGekaGMuM0dgH/5rOkya32Oi?= =?us-ascii?Q?gvaCFvhUGbiEIeYQJM4ONeqNcXKHkVLqe1zJIICbxmXXdEUDYhtbpBqYJhGK?= =?us-ascii?Q?Gs1ydV5qC6dQkJKs5EQMX0v6D7v36+AwQVPWdxhHfVvN3B24h7X25jITUKeI?= =?us-ascii?Q?4WQayFxNiq95+29i4PUxSaibDk9KhA+5joqks6lGtuRw+kRGMVSPu8qKf2zh?= =?us-ascii?Q?Xwy3RtUIv9OHCu13b/g4aX+JlXHUP6VDNCSg0Yh0Rq7Ezr/lvgff7r1Q4HAz?= =?us-ascii?Q?4uwVCNfpTZf8XcHcGvVxIzD1Psq8wmCgihxLs5S9k2BAI3bsUtaSU3ILkoyr?= =?us-ascii?Q?lOvPYoj6P2rxHl0qGYyxB6aN7M7N0UNVaWmfagJuvQoxmMEpy1WUCbcFWqSY?= =?us-ascii?Q?BHVwiixGpZ0kWm61ZEtXrkKRZrmHRSMgKAdKPZg46JxnHJvvwhMBdADMhk5s?= =?us-ascii?Q?cF0ogG67zlu69XOnvfkICQh9IqMRMoxCaSlnrhI1CTVY?= X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3293166-61be-40d2-a6a8-08db4cf2958a X-MS-Exchange-CrossTenant-AuthSource: SN6PR2101MB1101.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 22:54:57.9232 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JjgrHM01i2VG3p6XPKEonYXleZiyTcLmld6iJSE1Kq/YpKlSMMJ5CByQe/+ODOplZAA7paata2Fv7CN2UuG46Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR21MB1883 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When a TDX guest runs on Hyper-V, the UEFI firmware sets the HW_REDUCED flag, and consequently ttyS0 interrupts can't work. Fix the issue by overriding x86_init.acpi.reduced_hw_early_init(). Reviewed-by: Michael Kelley Signed-off-by: Dexuan Cui --- Changes since v1: None. Changes in v5: Improved the comment [Michael Kelley] Added Michael's Reviewed-by. Changes in v6: None. arch/x86/kernel/cpu/mshyperv.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c index b95b689efa07..d642e3624286 100644 --- a/arch/x86/kernel/cpu/mshyperv.c +++ b/arch/x86/kernel/cpu/mshyperv.c @@ -313,6 +313,26 @@ static void __init hv_smp_prepare_cpus(unsigned int ma= x_cpus) } #endif =20 +/* + * When a TDX guest runs on Hyper-V, the firmware sets the HW_REDUCED flag= : see + * acpi_tb_create_local_fadt(). Consequently ttyS0 interrupts can't work b= ecause + * request_irq() -> ... -> irq_to_desc() returns NULL for ttyS0. This happ= ens + * because mp_config_acpi_legacy_irqs() sees a nr_legacy_irqs() of 0, so it + * doesn't initialize the array 'mp_irqs[]', and later setup_IO_APIC_irqs(= ) -> + * find_irq_entry() fails to find the legacy irqs from the array, and hence + * doesn't create the necessary irq description info. + * + * Clone arch/x86/kernel/acpi/boot.c: acpi_generic_reduced_hw_init() here, + * except don't change 'legacy_pic'. It keeps its default value + * 'default_legacy_pic'. mp_config_acpi_legacy_irqs() sees a non-zero + * nr_legacy_irqs(), and eventually serial console interrupts works proper= ly. + */ +static void __init reduced_hw_init(void) +{ + x86_init.timers.timer_init =3D x86_init_noop; + x86_init.irqs.pre_vector_init =3D x86_init_noop; +} + static void __init ms_hyperv_init_platform(void) { int hv_max_functions_eax; @@ -424,6 +444,8 @@ static void __init ms_hyperv_init_platform(void) =20 /* A TDX VM must use x2APIC and doesn't use lazy EOI */ ms_hyperv.hints &=3D ~HV_X64_APIC_ACCESS_RECOMMENDED; + + x86_init.acpi.reduced_hw_early_init =3D reduced_hw_init; } } =20 --=20 2.25.1