From nobody Wed Feb 11 08:12:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F4F0C77B7F for ; Wed, 3 May 2023 16:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbjECQI6 (ORCPT ); Wed, 3 May 2023 12:08:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230425AbjECQIu (ORCPT ); Wed, 3 May 2023 12:08:50 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A497282 for ; Wed, 3 May 2023 09:08:48 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-b9a7553f95dso10691475276.2 for ; Wed, 03 May 2023 09:08:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683130127; x=1685722127; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=UpESMHY3dXiGunARd4Ma9HdMNvInCBKyCNCSaFRW6Ms=; b=wWTeQSe9JCCJ9pUvrrbudQKOTYO/i38kVcvsNhjPCCSRQyOR13ZqBKkCsMKvJO8ipA AUAokED4NY2vc/H9pYe41Pg+X5hIPEcIQpIJWr5NnqmigGPerJ3MtUKWbPYztN+VUJrr mnJUA/qxNDAR0r0LekD481sPNikHnSVY+cqmYJvxgd6hKMwNbcrUoOTlCKNA6uNMWSbE Q0BCvmEIiP24OXh3p2PhMIKcMV4Y4BqTZdm9ZSzMqEMhkrrlKNqVwXQ+sHqtsetsvlRc TZQdxlteiV2+NmkMidg9DbvStomj13XW9N1RgcA+4728Emo1iRtpcSbPxqfI6jxMZRnW JSqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683130127; x=1685722127; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UpESMHY3dXiGunARd4Ma9HdMNvInCBKyCNCSaFRW6Ms=; b=cqcjSbELncpiC1u/ZV33xDwzZRqeNWRe2/14+O23Dw0G1Rg3/fQ1jm9qrMTjpnD3O4 LogGdVLztOEOu6g4jCeEwJlmEAZE3FXsWt52otlzcMMwBDs86VotjgwtHc04mjZbqIgy oUCfN+T+ITQqm6S2Qy3RtaV5Rj2KLz46K1y4p1LS3o4IwyHXBJtYhuJEsp4wRQXPyVRg vDzBr2EyTOLBLuXqEAoHx0TFgqjKw3K0xi1QPqZ5fM+zh8IgBCWeM6/t4HsEkRPkgxgb h1QqLQgSL4Iwr2rPunwkILhQN0wZxQ2D59nuQHf6Cx9E6j7vHrr7baKWosk0ulcl3BpR pPIQ== X-Gm-Message-State: AC+VfDwqigYrvHnAcqF4h514RWrSK2t8y+2grprWAaFnCgW/GTil1Esi WMRRVaBQp2O2oyWZZjAb1NKmd5lxRJk= X-Google-Smtp-Source: ACHHUZ7j5zBqK9ftbtMARRCXZsD6o77fHe+mRNhKP0knX56m2HlOhQ0cuPXd09xE5zp2sQBZS4Mv7o9IH9U= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:5e03:0:b0:b9e:91e0:ea0a with SMTP id s3-20020a255e03000000b00b9e91e0ea0amr2705234ybb.13.1683130127369; Wed, 03 May 2023 09:08:47 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 3 May 2023 09:08:38 -0700 In-Reply-To: <20230503160838.3412617-1-seanjc@google.com> Mime-Version: 1.0 References: <20230503160838.3412617-1-seanjc@google.com> X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog Message-ID: <20230503160838.3412617-4-seanjc@google.com> Subject: [PATCH v2 3/3] KVM: x86: Open code supported XCR0 calculation in kvm_vcpu_after_set_cpuid() From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Kai Huang Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop cpuid_get_supported_xcr0() now that its bastardized usage in __kvm_update_cpuid_runtime() is gone, and open code the logic in its sole caller, kvm_vcpu_after_set_cpuid(). No functional change intended. Reviewed-by: Kai Huang Tested-by: Kai Huang Signed-off-by: Sean Christopherson --- arch/x86/kvm/cpuid.c | 27 ++++++++++----------------- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index 0c9660a07b23..491c88e196c1 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -234,21 +234,6 @@ void kvm_update_pv_runtime(struct kvm_vcpu *vcpu) vcpu->arch.pv_cpuid.features =3D best->eax; } =20 -/* - * Calculate guest's supported XCR0 taking into account guest CPUID data a= nd - * KVM's supported XCR0 (comprised of host's XCR0 and KVM_SUPPORTED_XCR0). - */ -static u64 cpuid_get_supported_xcr0(struct kvm_cpuid_entry2 *entries, int = nent) -{ - struct kvm_cpuid_entry2 *best; - - best =3D cpuid_entry2_find(entries, nent, 0xd, 0); - if (!best) - return 0; - - return (best->eax | ((u64)best->edx << 32)) & kvm_caps.supported_xcr0; -} - static void __kvm_update_cpuid_runtime(struct kvm_vcpu *vcpu, struct kvm_c= puid_entry2 *entries, int nent) { @@ -323,8 +308,16 @@ static void kvm_vcpu_after_set_cpuid(struct kvm_vcpu *= vcpu) kvm_apic_set_version(vcpu); } =20 - vcpu->arch.guest_supported_xcr0 =3D - cpuid_get_supported_xcr0(vcpu->arch.cpuid_entries, vcpu->arch.cpuid_nent= ); + /* + * Calculate guest's supported XCR0 taking into account guest CPUID data = and + * KVM's supported XCR0 (comprised of host's XCR0 and KVM_SUPPORTED_XCR0). + */ + best =3D kvm_find_cpuid_entry_index(vcpu, 0xd, 0); + if (!best) + vcpu->arch.guest_supported_xcr0 =3D 0; + else + vcpu->arch.guest_supported_xcr0 =3D (best->eax | ((u64)best->edx << 32))= & + kvm_caps.supported_xcr0; =20 /* * FP+SSE can always be saved/restored via KVM_{G,S}ET_XSAVE, even if --=20 2.40.1.495.gc816e09b53d-goog