From nobody Thu Feb 12 01:24:59 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34252C77B73 for ; Tue, 2 May 2023 05:36:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233481AbjEBFgG (ORCPT ); Tue, 2 May 2023 01:36:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233128AbjEBFgA (ORCPT ); Tue, 2 May 2023 01:36:00 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE08144BA for ; Mon, 1 May 2023 22:35:58 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1aad55244b7so23224475ad.2 for ; Mon, 01 May 2023 22:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683005758; x=1685597758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iFZDahJ1qpozC1mCB3SvMK7u+IXOSO5tIIA+RIrQqiA=; b=PXBUVLnKWk2RaXst7QwTMi1l9Rv/rZ7fvx6nBC2A7JYlc9CmFKC1EIu5jPJ7QIMS6c SKBgq7TC7bfFQ3DZ8fRgyKKQmJcetwsJ9mDIXWYPJ783niOTh4uZAEarQwAipaexzE9E v06qvOlD7KfUV8xoHnqYlrWm7qGTaYbKPROQaCjZ8U2SGJSDl2tymA/QRrDnIaHWmOs6 TEJS0Rj86YSD/n+Z/lQvRc462Nao5miMC6QyEbQo1nCUcybxIwC0pkK34q5GYH48cXt8 /FoR+F4PVJyQQpmpqzudEgAY8Rm8G20gDb/X2jKrPoNAlZ+bxxZi1U0zu0Pw7MXT0e/A VR2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683005758; x=1685597758; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iFZDahJ1qpozC1mCB3SvMK7u+IXOSO5tIIA+RIrQqiA=; b=G53lBIP6nvgxOYkCpyjqx0qXSTV2iKPfsndDCkwobLcKNG/YCHtEXh5M+3JJjG4Ggt jUAn01eLKxKWUGC1AAckBYnCHjiDvOm/q/JjwUcivGkMFvIB4b/OhA0JDxIPoKLLmHys JPzvSrQU+E9u3uizCWtBjGR8SOv3GNnycg/fNEU8AH+5YfnQGLATiVBH9g9QhuXJBXmO RaHGF3lWDRvPQZ18sJ9mDhfaFyCfuPwgJjQhV+u7Ic6EN4huEINW1bJmPoBdIGfjM0tG c4ki1jO7Yj2+4s9y17eB57uLeoPO/mJ6cOkUKN8A4qyQO/hANO2fA4U6uwjHkyE3tMg6 Qv3g== X-Gm-Message-State: AC+VfDxtrn678jCP3q8G8U64u4tIh6Fg+hgoKtn6Vt+4H7J3AM/1zq1A ezIOuzVRkktE1ZecgvsrzQebHg== X-Google-Smtp-Source: ACHHUZ4IYyg9BKrQ3QtFVFftnxGNHKN1hOh6WGGkoaaJ/c4bAbcJoGke3k1Hyv12eU5+xl9gieSzVw== X-Received: by 2002:a17:903:2350:b0:1aa:e0c9:7e77 with SMTP id c16-20020a170903235000b001aae0c97e77mr11209898plh.36.1683005758260; Mon, 01 May 2023 22:35:58 -0700 (PDT) Received: from localhost.localdomain ([2401:4900:1f3b:58fa:39f6:37e1:bb9a:a094]) by smtp.gmail.com with ESMTPSA id j12-20020a170902690c00b001a6a6169d45sm18870369plk.168.2023.05.01.22.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 22:35:57 -0700 (PDT) From: Bhupesh Sharma To: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org Cc: agross@kernel.org, linux-kernel@vger.kernel.org, andersson@kernel.org, bhupesh.sharma@linaro.org, bhupesh.linux@gmail.com, krzysztof.kozlowski@linaro.org, robh+dt@kernel.org, konrad.dybcio@linaro.org, kishon@kernel.org, vkoul@kernel.org, krzysztof.kozlowski+dt@linaro.org, dmitry.baryshkov@linaro.org Subject: [PATCH v10 2/4] phy: qcom-qmp-usb: add support for updated qcm2290 / sm6115 binding Date: Tue, 2 May 2023 11:05:32 +0530 Message-Id: <20230502053534.1240553-3-bhupesh.sharma@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230502053534.1240553-1-bhupesh.sharma@linaro.org> References: <20230502053534.1240553-1-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add support for the new qcm2290 / sm6115 binding. The USB QMP phy on these devices supports 2 lanes. Note that the binding now does not describe every register subregion and instead the driver holds the corresponding offsets. While at it also include support for PCS_MISC region which was left out earlier. Signed-off-by: Bhupesh Sharma Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm= /phy-qcom-qmp-usb.c index a49711c5a63d..ae4710f08bfb 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c @@ -1411,9 +1411,13 @@ static const struct qmp_phy_init_tbl sc8280xp_usb3_u= niphy_pcs_tbl[] =3D { struct qmp_usb_offsets { u16 serdes; u16 pcs; + u16 pcs_misc; u16 pcs_usb; u16 tx; u16 rx; + /* for PHYs with >=3D 2 lanes */ + u16 tx2; + u16 rx2; }; =20 /* struct qmp_phy_cfg - per-PHY initialization config */ @@ -1558,6 +1562,16 @@ static const char * const qmp_phy_vreg_l[] =3D { "vdda-phy", "vdda-pll", }; =20 +static const struct qmp_usb_offsets qmp_usb_offsets_v3 =3D { + .serdes =3D 0, + .pcs =3D 0xc00, + .pcs_misc =3D 0xa00, + .tx =3D 0x200, + .rx =3D 0x400, + .tx2 =3D 0x600, + .rx2 =3D 0x800, +}; + static const struct qmp_usb_offsets qmp_usb_offsets_v5 =3D { .serdes =3D 0, .pcs =3D 0x0200, @@ -1922,6 +1936,8 @@ static const struct qmp_phy_cfg sm8350_usb3_uniphy_cf= g =3D { static const struct qmp_phy_cfg qcm2290_usb3phy_cfg =3D { .lanes =3D 2, =20 + .offsets =3D &qmp_usb_offsets_v3, + .serdes_tbl =3D qcm2290_usb3_serdes_tbl, .serdes_tbl_num =3D ARRAY_SIZE(qcm2290_usb3_serdes_tbl), .tx_tbl =3D qcm2290_usb3_tx_tbl, @@ -2493,10 +2509,16 @@ static int qmp_usb_parse_dt(struct qmp_usb *qmp) =20 qmp->serdes =3D base + offs->serdes; qmp->pcs =3D base + offs->pcs; + qmp->pcs_misc =3D base + offs->pcs_misc; qmp->pcs_usb =3D base + offs->pcs_usb; qmp->tx =3D base + offs->tx; qmp->rx =3D base + offs->rx; =20 + if (cfg->lanes >=3D 2) { + qmp->tx2 =3D base + offs->tx2; + qmp->rx2 =3D base + offs->rx2; + } + qmp->pipe_clk =3D devm_clk_get(dev, "pipe"); if (IS_ERR(qmp->pipe_clk)) { return dev_err_probe(dev, PTR_ERR(qmp->pipe_clk), --=20 2.38.1