From nobody Thu Dec 18 19:42:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0B43C77B73 for ; Mon, 1 May 2023 02:57:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232135AbjEAC5C (ORCPT ); Sun, 30 Apr 2023 22:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjEAC46 (ORCPT ); Sun, 30 Apr 2023 22:56:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFB3419D for ; Sun, 30 Apr 2023 19:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682909767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=P71hh1hVX94ThG5yTOof07dnMP25hXjA33Fj1bRqY+8=; b=MTdAEWV1pOEGwpMUvVFulKRazUa/bi4k9+6kiXB+lZbnaLVEYg/7SsHEUQUKXxz8rKx68v 2zEeA4ItZ84XzG9/yYrsqLrAfMJxDQ3kx2tuv1266gSfhR24EfAtezbI9zedqnCNSnc3Pf GMXAD5errsZyA0JYMTJsD4att+rN0H8= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-202-A5AJ4H1zNJCReyvgn4rlOQ-1; Sun, 30 Apr 2023 22:56:05 -0400 X-MC-Unique: A5AJ4H1zNJCReyvgn4rlOQ-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-3ef65714d24so27614331cf.1 for ; Sun, 30 Apr 2023 19:56:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682909765; x=1685501765; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P71hh1hVX94ThG5yTOof07dnMP25hXjA33Fj1bRqY+8=; b=bPqdPDRM67IzeTXFyWauFKgZC5P0juq40XM4brZh4tvoJp0E8GqM9KSOkKNpFYto0O 0lwtWKC3hlFnPRRlArRkwYVQ84triBFVQsxSQSJoPWoPO4BC9GRF3WEIkCjA0fKH9d8u IP4FnpTBY2CaA99lYy0LSY911yeVkZ6ywqJLpw3gp6AlYrDhQWge9FA2VYodVClnRmEN bh2uOd7DpkLixvlUk7mbwen1RxJcHekckV2j+SySFulePa7kSMX+BvyNM98loiOlv1Bc BUmflaXup6PjW6Fkbh2u6gz2776dkBlzDvwUDU0dEdyu83Z0YsKZGQqiqSI4nS2/zIwX 6t5A== X-Gm-Message-State: AC+VfDxUFn8GWHKSYRxpX3x81X9ZSCMB0JabajKIjPtavgxIhvJcvdnc qw+nNEOn8E9ZvtFYHALiC3DRoFv7M5S4tELqwWR4+o34JWr63abl3h5RErLL91OICrF/2TxgAaK PJ20Te7xEU+ipaZinWxK1bDhv X-Received: by 2002:ac8:5dd1:0:b0:3ef:54c9:9869 with SMTP id e17-20020ac85dd1000000b003ef54c99869mr20599171qtx.31.1682909765217; Sun, 30 Apr 2023 19:56:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ62YgtU1mxsZmkSlSss9+q+sO2G3Y4kjPIDvU2+bP5ieOPhlyiMmbSysV2BD1rj091m1GXrjg== X-Received: by 2002:ac8:5dd1:0:b0:3ef:54c9:9869 with SMTP id e17-20020ac85dd1000000b003ef54c99869mr20599159qtx.31.1682909764947; Sun, 30 Apr 2023 19:56:04 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id x8-20020ac86b48000000b003e39106bdb2sm9062696qts.31.2023.04.30.19.56.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Apr 2023 19:56:04 -0700 (PDT) From: Tom Rix To: gregkh@linuxfoundation.org, jirislaby@kernel.org Cc: linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] tty: define hung_up_tty_compat_ioctl with CONFIG_COMPAT Date: Sun, 30 Apr 2023 22:56:02 -0400 Message-Id: <20230501025602.2905173-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org gcc reports drivers/tty/tty_io.c:446:13: error: =E2=80=98hung_up_tty_compat_ioctl=E2=80= =99 defined but not used [-Werror=3Dunused-function] 446 | static long hung_up_tty_compat_ioctl(struct file *file, | ^~~~~~~~~~~~~~~~~~~~~~~~ hung_up_tty_compat_ioctl is used conditionally with CONFIG_COMPAT, so it should be likewise defined. Signed-off-by: Tom Rix --- drivers/tty/tty_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 553182753098..7fe404d56ce7 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c @@ -443,11 +443,13 @@ static long hung_up_tty_ioctl(struct file *file, unsi= gned int cmd, return cmd =3D=3D TIOCSPGRP ? -ENOTTY : -EIO; } =20 +#ifdef CONFIG_COMPAT static long hung_up_tty_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg) { return cmd =3D=3D TIOCSPGRP ? -ENOTTY : -EIO; } +#endif =20 static int hung_up_tty_fasync(int fd, struct file *file, int on) { --=20 2.27.0