From nobody Thu Dec 18 10:35:56 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A3C2C7EE2C for ; Mon, 1 May 2023 12:57:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232509AbjEAM5Z (ORCPT ); Mon, 1 May 2023 08:57:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232421AbjEAM5V (ORCPT ); Mon, 1 May 2023 08:57:21 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1783A10E4 for ; Mon, 1 May 2023 05:57:18 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2a8c51ba511so23067681fa.1 for ; Mon, 01 May 2023 05:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682945836; x=1685537836; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uHlUeuh/pHwqLKIz8o/1xZKZmLDz+WudWNOBRqRlbus=; b=X7cxIG9tiNOMWLsNhQ4cTuHzOz/dWFUxC6qoG4JfJZxnsewQ41oZV5FmwYZ4O+wn+r y1tTflf7wUkQTO9zVPeYfyv6PgmgIWQ7MsLGbd1h5nU0x9vuHlsY8qgnEJt2lsNbb1oO 0z9mcyk8fdA04pgS6IHoKbjnGLB01UVvsXpxOZwrlq6WX26rxpAzBRO1YmQr989nrXsf ZYOAR9EZPvkwI7IDmbgC6CJWxPzWo1tnc4WfCo7HGl1hZXNtjX1Ab99umUy7YS0skz3g cysZR6j38nuVepj28bCuJBHW34w6UJOZ53KDDRzegW1/Ixduk5U9EFlXfiArs2kFPgwt e7Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682945836; x=1685537836; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uHlUeuh/pHwqLKIz8o/1xZKZmLDz+WudWNOBRqRlbus=; b=PFfCT7skKZEKoYFdExCw4RS5E7BI606Zyl4E4ufrAi0/NoqomdBNSzwQLUJDfDFCwo asmttCDG3qEgC42lxFaPO+r6NxgJxa4yAwzdvNeP1za97QyH8Gjwt5g7ZDc5HBfU58OB liISz+kzy51l4ra2nsRVq65MEn9jLRzChcI5fE4266rarg49dBezhgTx7x761Iff6yI4 auP5LfE8/lacLbLCXnLKV4kMfF2b1g2xJt8q3nkTnbxDp+IB6PA369O9keur83iNSnKD i7u5z2X546RBYkP5JXFYNbA/Q6WuLUibBhZ0mSxTGfiGdXx/o4DnFMlUkZePOCd/Ealo 5rdw== X-Gm-Message-State: AC+VfDzwvdJRv3fqVC+7vVx4/oaylV4klsJr5JO1q82bcJ2NVLEe7QA5 Vjai+6OG4ZA6N4zIb0KdNkzFkw== X-Google-Smtp-Source: ACHHUZ6Yvaz7TkENMDZRwmk7T31tuBf6DQlIn4I/2P08OK4irLc5OgrKftJEJdZLr7Wu2ovKW0ggLQ== X-Received: by 2002:a05:651c:238:b0:2a9:f584:659a with SMTP id z24-20020a05651c023800b002a9f584659amr4013592ljn.23.1682945836262; Mon, 01 May 2023 05:57:16 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id y6-20020a2e95c6000000b002a77ab1d73dsm58332ljh.96.2023.05.01.05.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 05:57:15 -0700 (PDT) From: Konrad Dybcio Date: Mon, 01 May 2023 14:57:11 +0200 Subject: [PATCH 1/3] clk: qcom: smd-rpm_ Make __DEFINE_CLK_SMD_RPM_BRANCH_PREFIX accept flags MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230501-topic-rpmcc_xo_a-v1-1-93f18e47b607@linaro.org> References: <20230501-topic-rpmcc_xo_a-v1-0-93f18e47b607@linaro.org> In-Reply-To: <20230501-topic-rpmcc_xo_a-v1-0-93f18e47b607@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1682945834; l=2532; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=Mq5bwFOL9cmaK290SYW2KDaNzLEfPikSHhS+lIezcWY=; b=1ViYumVyzv2y3lEP6jFG3+C5sctZEwY4wUfcjBh34sBwMp5IELQ43UNPr2V4ZTceG/jgWt635//Z PoSGoGJEBMX5nQFpp/8sJyYSEvpUsSmgS48+iY31qzzBDL8vGWuX X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation for supporting keepalive clocks which can never be shut off (as the platform would fall apart otherwise), make the __DEFINE_CLK_SMD_RPM_BRANCH_PREFIX macro accept clock flags for the active-only clock. Signed-off-by: Konrad Dybcio Tested-by: Matti Lehtim=C3=A4ki --- drivers/clk/qcom/clk-smd-rpm.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c index 887b945a6fb7..e559755a86e0 100644 --- a/drivers/clk/qcom/clk-smd-rpm.c +++ b/drivers/clk/qcom/clk-smd-rpm.c @@ -67,7 +67,7 @@ type, r_id, key) =20 #define __DEFINE_CLK_SMD_RPM_BRANCH_PREFIX(_prefix, _name, _active,\ - type, r_id, r, key) \ + type, r_id, r, key, ao_flags) \ static struct clk_smd_rpm clk_smd_rpm_##_prefix##_active; \ static struct clk_smd_rpm clk_smd_rpm_##_prefix##_name =3D { \ .rpm_res_type =3D (type), \ @@ -102,12 +102,13 @@ .name =3D "xo_board", \ }, \ .num_parents =3D 1, \ + .flags =3D (ao_flags), \ }, \ } =20 #define __DEFINE_CLK_SMD_RPM_BRANCH(_name, _active, type, r_id, r, key) = \ __DEFINE_CLK_SMD_RPM_BRANCH_PREFIX(/* empty */, \ - _name, _active, type, r_id, r, key) + _name, _active, type, r_id, r, key, 0) =20 #define DEFINE_CLK_SMD_RPM(_name, type, r_id) \ __DEFINE_CLK_SMD_RPM(_name##_clk, _name##_a_clk, \ @@ -126,12 +127,12 @@ #define DEFINE_CLK_SMD_RPM_BRANCH(_name, type, r_id, r) \ __DEFINE_CLK_SMD_RPM_BRANCH_PREFIX(branch_, \ _name##_clk, _name##_a_clk, \ - type, r_id, r, QCOM_RPM_SMD_KEY_ENABLE) + type, r_id, r, QCOM_RPM_SMD_KEY_ENABLE, 0) =20 #define DEFINE_CLK_SMD_RPM_BRANCH_A(_name, type, r_id, r) \ __DEFINE_CLK_SMD_RPM_BRANCH_PREFIX(branch_, \ _name, _name##_a, type, \ - r_id, r, QCOM_RPM_SMD_KEY_ENABLE) + r_id, r, QCOM_RPM_SMD_KEY_ENABLE, 0) =20 #define DEFINE_CLK_SMD_RPM_QDSS(_name, type, r_id) \ __DEFINE_CLK_SMD_RPM(_name##_clk, _name##_a_clk, \ @@ -146,7 +147,7 @@ __DEFINE_CLK_SMD_RPM_BRANCH_PREFIX(_prefix, \ _name, _name##_a, \ QCOM_SMD_RPM_CLK_BUF_A, r_id, r, \ - QCOM_RPM_KEY_SOFTWARE_ENABLE) + QCOM_RPM_KEY_SOFTWARE_ENABLE, 0) =20 #define DEFINE_CLK_SMD_RPM_XO_BUFFER_PINCTRL(_name, r_id, r) \ DEFINE_CLK_SMD_RPM_XO_BUFFER(_name, r_id, r); \ --=20 2.40.1 From nobody Thu Dec 18 10:35:56 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57946C77B61 for ; Mon, 1 May 2023 12:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232702AbjEAM5b (ORCPT ); Mon, 1 May 2023 08:57:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232679AbjEAM5W (ORCPT ); Mon, 1 May 2023 08:57:22 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F401A10F7 for ; Mon, 1 May 2023 05:57:18 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2a8b1b51dbdso23179791fa.0 for ; Mon, 01 May 2023 05:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682945837; x=1685537837; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=28S63ma6Nc4wW+jWaKui5HjUs7at3nzDPT9xYvZc0Iw=; b=iVhpir8kH8Y7P8d4uXIJs00hmKzJ3IXqak4Dl/VXaTZjIvf1dTySSlkb661qv/AW3e kUjLNqugCcJASpaAsEEfcK1FzLT3CulsPYIxsYm/+JVZdVuR5HOr8sZrYhOAYkiC13PS uhVncwyjAabPbEJNqE+5razoCoZ/rXy9faRks8kqtnUkcKYg9ebMSiu2mY0b1aDkrB6+ XObQokZdSFrOvyx7R+ZQYwk7yrHra3Rs24IpLb563MaTP3cETFjeCgQIKTO6/RFyPRna mW5KZ9+Mk1NCllWTYjZTfCORN13TECBhEHaI/2ujazJ3xiwT06Lk/Xh0+yiabB4z5RVL 8rhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682945837; x=1685537837; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=28S63ma6Nc4wW+jWaKui5HjUs7at3nzDPT9xYvZc0Iw=; b=N7SgluIzL3sL9LwjXZcGKTQnjq+y0WVLvRfIi3twxUg0ql65p3ALxcqBpElVr0cRYH ji9sJw84l7znA5Is/H6AeIirohkvLCFAOSnAwhLbAdX+VeRudCHQ+A8qoIeg4XnjLycj K4E3X3BjZT2gsbkdwFwm+hIkmHiej/VtlIv5Gne5QQByRPrLrthBOGdreYGwq3fp0/x6 96L4gTtawQMkXCoXgU/tq8XmLnFmRD9MNIq4KHy721HTeLmDIddjqx1ieyU1rdyQkqa7 t6qkjd1tYefyQDJKOwDPbmJxSVWW6kZnTCubz5jDncuQOjISFyREBgNIrT6Vgt24jVsF 6GHA== X-Gm-Message-State: AC+VfDyfEwJ2JTGSFvIoh2M6XqsH/X0tuP1/S3pyHvBfMd3XwPF9Ri26 gDlrGccyoQmK9dNLLx04hFFrXw== X-Google-Smtp-Source: ACHHUZ6+umAAMqwRjvJ/oiDM9fYAgfb5U6cnoVx/DfbfyWbszkC/lj1I4lwXCcb4Pw+3xw3VLxlujw== X-Received: by 2002:a2e:b61c:0:b0:29a:1f7d:38b1 with SMTP id r28-20020a2eb61c000000b0029a1f7d38b1mr3884374ljn.28.1682945837300; Mon, 01 May 2023 05:57:17 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id y6-20020a2e95c6000000b002a77ab1d73dsm58332ljh.96.2023.05.01.05.57.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 05:57:17 -0700 (PDT) From: Konrad Dybcio Date: Mon, 01 May 2023 14:57:12 +0200 Subject: [PATCH 2/3] clk: qcom: smd-rpm: Make DEFINE_CLK_SMD_RPM_BRANCH_A accept flags MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230501-topic-rpmcc_xo_a-v1-2-93f18e47b607@linaro.org> References: <20230501-topic-rpmcc_xo_a-v1-0-93f18e47b607@linaro.org> In-Reply-To: <20230501-topic-rpmcc_xo_a-v1-0-93f18e47b607@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1682945834; l=1813; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=9Jacz1Yu9Sh2wayMooJRt9aLJtA6AgNtuaR8+zaLHzY=; b=HcEVnGLvfBMKeXtYOzYtd/gAfzaeZQQdZIAv2yNiEV19Q/mVPoKngIpZ5ftjRB2h9COLbjtXNAwp SInBx/g/CMzw5aRLCXI6/iye66GBxozDjEGzYM35Ay9Yt/wQmgpi X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation for supporting keepalive clocks which can never be shut off (as the platform would fall apart otherwise), make the DEFINE_CLK_SMD_RPM_BRANCH_A macro accept clock flags for the active-only clock. Signed-off-by: Konrad Dybcio Tested-by: Matti Lehtim=C3=A4ki --- drivers/clk/qcom/clk-smd-rpm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c index e559755a86e0..e00889fddc7b 100644 --- a/drivers/clk/qcom/clk-smd-rpm.c +++ b/drivers/clk/qcom/clk-smd-rpm.c @@ -129,10 +129,10 @@ _name##_clk, _name##_a_clk, \ type, r_id, r, QCOM_RPM_SMD_KEY_ENABLE, 0) =20 -#define DEFINE_CLK_SMD_RPM_BRANCH_A(_name, type, r_id, r) \ +#define DEFINE_CLK_SMD_RPM_BRANCH_A(_name, type, r_id, r, ao_flags) \ __DEFINE_CLK_SMD_RPM_BRANCH_PREFIX(branch_, \ _name, _name##_a, type, \ - r_id, r, QCOM_RPM_SMD_KEY_ENABLE, 0) + r_id, r, QCOM_RPM_SMD_KEY_ENABLE, ao_flags) =20 #define DEFINE_CLK_SMD_RPM_QDSS(_name, type, r_id) \ __DEFINE_CLK_SMD_RPM(_name##_clk, _name##_a_clk, \ @@ -439,10 +439,10 @@ static const struct clk_ops clk_smd_rpm_branch_ops = =3D { .recalc_rate =3D clk_smd_rpm_recalc_rate, }; =20 -DEFINE_CLK_SMD_RPM_BRANCH_A(bi_tcxo, QCOM_SMD_RPM_MISC_CLK, 0, 19200000); +DEFINE_CLK_SMD_RPM_BRANCH_A(bi_tcxo, QCOM_SMD_RPM_MISC_CLK, 0, 19200000, 0= ); DEFINE_CLK_SMD_RPM_BRANCH(qdss, QCOM_SMD_RPM_MISC_CLK, 1, 19200000); DEFINE_CLK_SMD_RPM_QDSS(qdss, QCOM_SMD_RPM_MISC_CLK, 1); -DEFINE_CLK_SMD_RPM_BRANCH_A(bimc_freq_log, QCOM_SMD_RPM_MISC_CLK, 4, 1); +DEFINE_CLK_SMD_RPM_BRANCH_A(bimc_freq_log, QCOM_SMD_RPM_MISC_CLK, 4, 1, 0); =20 DEFINE_CLK_SMD_RPM_BRANCH(mss_cfg_ahb, QCOM_SMD_RPM_MCFG_CLK, 0, 19200000); =20 --=20 2.40.1 From nobody Thu Dec 18 10:35:56 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12A83C77B73 for ; Mon, 1 May 2023 12:57:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232695AbjEAM52 (ORCPT ); Mon, 1 May 2023 08:57:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232683AbjEAM5W (ORCPT ); Mon, 1 May 2023 08:57:22 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11B4A10F9 for ; Mon, 1 May 2023 05:57:20 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4f0025f4686so3114900e87.3 for ; Mon, 01 May 2023 05:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682945838; x=1685537838; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mVxPqZEZqxT/xble5HJfq8Vj9DqelOFd4DLS6YwEQRk=; b=qAwu+pVrhIlLgf33SSBK3DoiYgjhCcfLThZcPo0eXws58slERBFYB7TmvXZLNqBbum GDigKGjE/m87a2yBWbzTcliEntbid58PWp03W7mC674y6S9p9Z3L/hu3evKT/Ig/m5xn E5D2jxk5IoBkNyuycWgmf4JRZsbM2xdRMsHoZQX3rLvWiodt1C2GyzWlFk0R/atiXXXX F/sFUOz50S+8FtYsCzpSekCdpzvHPHpE477hJvXJcSq2vtQcpGMs+2uY+ZVYfJzfnPTD fDsjqXf+lQ7/+v/5hs70g5iUxRyfh5a5I1BdZtlXIrvNSa1OFK/lViVvL91diGUGjfLJ 0Rrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682945838; x=1685537838; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mVxPqZEZqxT/xble5HJfq8Vj9DqelOFd4DLS6YwEQRk=; b=LeRyT0i8meVIb4MNT0o7etyP35bgZntwndz0ytjclOwN5Ev/wNttAiUEPDHM0TeuGY aysPA1mgpXTCi1lZMzcjZSjOYHbsT+Wa25u1lzXP5akM06jtBdqS62ptHl9A0sH+VsUj L6zlXz+6dWbVl1rLxHsuogk0t22C6v2UKctcn41Bs/tmtzbmuWlAL3RF2CtdP1H3KNOd k0jLnt93HXTJum8DMKLn3B8vblbR84mvZ8HozYlaXkbHbcef+i0H8zbILRYABSXf0KAB 3jtOgp6roXf7T8rVrPIFRJBM0ikpeZrsJsKjkvHOrChVygskGS8Q5JJV6timtbpzqLwj kMiA== X-Gm-Message-State: AC+VfDzQhzTeSbt1+Y+NRkbY2Di+QZO8wVBWpHvvQwz2dtnc+cVHh6L+ gxDH4ATc7Xl/vQuhz+7pMaj7dA== X-Google-Smtp-Source: ACHHUZ7FWE59lx7yU+Wa2gadJl0mGy4rdJrhFE4r17mW/89mIM8KAeaBV6pHzRuhk32djHcDpc2AbA== X-Received: by 2002:ac2:4c8c:0:b0:4ef:e6a1:6cc2 with SMTP id d12-20020ac24c8c000000b004efe6a16cc2mr4290688lfl.47.1682945838345; Mon, 01 May 2023 05:57:18 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id y6-20020a2e95c6000000b002a77ab1d73dsm58332ljh.96.2023.05.01.05.57.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 05:57:18 -0700 (PDT) From: Konrad Dybcio Date: Mon, 01 May 2023 14:57:13 +0200 Subject: [PATCH 3/3] clk: qcom: smd-rpm: Make BI_TCXO_AO critical MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230501-topic-rpmcc_xo_a-v1-3-93f18e47b607@linaro.org> References: <20230501-topic-rpmcc_xo_a-v1-0-93f18e47b607@linaro.org> In-Reply-To: <20230501-topic-rpmcc_xo_a-v1-0-93f18e47b607@linaro.org> To: Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1682945834; l=1210; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=l8l7+8uAcDF71yxaJqogJmWLjOCgIdZPw3YgQE8kOBk=; b=A0ur+z7Q0fpXelwJBH7Z48fWErgxHPy74GDXgwcZ1IjmPo+Fao6wDfDdxyTt0aiYs8jNGG0gQzEF dR2R0BvDBkQ+uhidoh10ufW1jQPXcK8hqKJBTAsxyhWNMRKlQsUS X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should never let go of the active-only XO vote, as otherwise the RPM may decide that there are no online users and it can be shut down, resulting in a total, uncontrolled system collapse. Guarantee this through adding the CLK_IS_CRITICAL flag. Signed-off-by: Konrad Dybcio Tested-by: Matti Lehtim=C3=A4ki --- drivers/clk/qcom/clk-smd-rpm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c index e00889fddc7b..9649f4644d71 100644 --- a/drivers/clk/qcom/clk-smd-rpm.c +++ b/drivers/clk/qcom/clk-smd-rpm.c @@ -439,7 +439,8 @@ static const struct clk_ops clk_smd_rpm_branch_ops =3D { .recalc_rate =3D clk_smd_rpm_recalc_rate, }; =20 -DEFINE_CLK_SMD_RPM_BRANCH_A(bi_tcxo, QCOM_SMD_RPM_MISC_CLK, 0, 19200000, 0= ); +/* Disabling BI_TCXO_AO could gate the root clock source of the entire sys= tem. */ +DEFINE_CLK_SMD_RPM_BRANCH_A(bi_tcxo, QCOM_SMD_RPM_MISC_CLK, 0, 19200000, C= LK_IS_CRITICAL); DEFINE_CLK_SMD_RPM_BRANCH(qdss, QCOM_SMD_RPM_MISC_CLK, 1, 19200000); DEFINE_CLK_SMD_RPM_QDSS(qdss, QCOM_SMD_RPM_MISC_CLK, 1); DEFINE_CLK_SMD_RPM_BRANCH_A(bimc_freq_log, QCOM_SMD_RPM_MISC_CLK, 4, 1, 0); --=20 2.40.1