From nobody Thu Feb 12 02:59:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDCDCC7618E for ; Sat, 29 Apr 2023 06:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230477AbjD2GC2 (ORCPT ); Sat, 29 Apr 2023 02:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230345AbjD2GCZ (ORCPT ); Sat, 29 Apr 2023 02:02:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD721BEE for ; Fri, 28 Apr 2023 23:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=6A8KygD+nWhp85vzQWwODAMm9Ud9p1UZ/7RQ/xwUgJg=; b=T485eIWOUc/qq6c3NgSPOTDFef +XtTwdUo7V0foOxGsU++Wken+a+pdPd8eHzK32zyao2DR17WWm21sYLu69akOtTypmuF0G4633nA2 47amNnQSVSFvgBX3iO4xQHweBnsRBxWwa4sOS92jcu7m48581xt0Q//KkRtWOtxfWFHWuAkye2aAi aK+ri2lUN0yuCaa6r1ApPB3SsfWD4xHA2cZp94REUXB12ypjg6cGXaLdV42WRJbqsiVmjPreOEtuU WJapkQcy8twKHG9HOT1UqPWdx8Gk9rDZjeJhOdECS8LYtFWlask+Ix7zRdXbki1QuvQqmsbD8WDQb 3aTGNQ+A==; Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1psdf0-00CIJ8-2J; Sat, 29 Apr 2023 06:02:18 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Grant Likely , Mark Brown , Liam Girdwood , Shengjiu Wang , Xiubo Li , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, Jaroslav Kysela , Takashi Iwai Subject: [PATCH] ASoC: fsl MPC52xx drivers require PPC_BESTCOMM Date: Fri, 28 Apr 2023 23:02:17 -0700 Message-Id: <20230429060217.2950-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Both SND_MPC52xx_SOC_PCM030 and SND_MPC52xx_SOC_EFIKA select SND_SOC_MPC5200_AC97. The latter symbol depends on PPC_BESTCOMM, so the 2 former symbols should also depend on PPC_BESTCOMM since "select" does not follow any dependency chains. This prevents a kconfig warning and build errors: WARNING: unmet direct dependencies detected for SND_SOC_MPC5200_AC97 Depends on [n]: SOUND [=3Dy] && !UML && SND [=3Dm] && SND_SOC [=3Dm] && S= ND_POWERPC_SOC [=3Dm] && PPC_MPC52xx [=3Dy] && PPC_BESTCOMM [=3Dn] Selected by [m]: - SND_MPC52xx_SOC_PCM030 [=3Dm] && SOUND [=3Dy] && !UML && SND [=3Dm] && = SND_SOC [=3Dm] && SND_POWERPC_SOC [=3Dm] && PPC_MPC5200_SIMPLE [=3Dy] - SND_MPC52xx_SOC_EFIKA [=3Dm] && SOUND [=3Dy] && !UML && SND [=3Dm] && S= ND_SOC [=3Dm] && SND_POWERPC_SOC [=3Dm] && PPC_EFIKA [=3Dy] ERROR: modpost: "mpc5200_audio_dma_destroy" [sound/soc/fsl/mpc5200_psc_ac97= .ko] undefined! ERROR: modpost: "mpc5200_audio_dma_create" [sound/soc/fsl/mpc5200_psc_ac97.= ko] undefined! Fixes: 40d9ec14e7e1 ("ASoC: remove BROKEN from Efika and pcm030 fabric driv= ers") Signed-off-by: Randy Dunlap Cc: Grant Likely Cc: Mark Brown Cc: Liam Girdwood Cc: Shengjiu Wang Cc: Xiubo Li Cc: alsa-devel@alsa-project.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Jaroslav Kysela Cc: Takashi Iwai --- sound/soc/fsl/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -- a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -243,7 +243,7 @@ config SND_SOC_MPC5200_AC97 =20 config SND_MPC52xx_SOC_PCM030 tristate "SoC AC97 Audio support for Phytec pcm030 and WM9712" - depends on PPC_MPC5200_SIMPLE + depends on PPC_MPC5200_SIMPLE && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_WM9712 help @@ -252,7 +252,7 @@ config SND_MPC52xx_SOC_PCM030 =20 config SND_MPC52xx_SOC_EFIKA tristate "SoC AC97 Audio support for bbplan Efika and STAC9766" - depends on PPC_EFIKA + depends on PPC_EFIKA && PPC_BESTCOMM select SND_SOC_MPC5200_AC97 select SND_SOC_STAC9766 help