From nobody Thu Feb 12 02:59:37 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FACCC77B73 for ; Thu, 27 Apr 2023 07:57:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243176AbjD0H5U (ORCPT ); Thu, 27 Apr 2023 03:57:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242987AbjD0H5R (ORCPT ); Thu, 27 Apr 2023 03:57:17 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 759DFDE for ; Thu, 27 Apr 2023 00:57:16 -0700 (PDT) Received: from localhost.localdomain (unknown [219.141.250.2]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id 3EBBA1801193B1; Thu, 27 Apr 2023 15:57:14 +0800 (CST) X-MD-Sfrom: zeming@nfschina.com X-MD-SrcIP: 219.141.250.2 From: Li zeming To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, Li zeming Subject: [PATCH] sched: core: Simplify sched_can_stop_tick() Date: Sat, 29 Apr 2023 08:28:31 +0800 Message-Id: <20230429002831.2875-1-zeming@nfschina.com> X-Mailer: git-send-email 2.18.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Remove useless intermediate variable "fifo_nr_running". Signed-off-by: Li zeming --- kernel/sched/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 3249c1272e57..1bab401920e8 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1176,8 +1176,6 @@ static void nohz_csd_func(void *info) #ifdef CONFIG_NO_HZ_FULL bool sched_can_stop_tick(struct rq *rq) { - int fifo_nr_running; - /* Deadline tasks, even if single, need the tick */ if (rq->dl.dl_nr_running) return false; @@ -1197,8 +1195,7 @@ bool sched_can_stop_tick(struct rq *rq) * If there's no RR tasks, but FIFO tasks, we can skip the tick, no * forced preemption between FIFO tasks. */ - fifo_nr_running =3D rq->rt.rt_nr_running - rq->rt.rr_nr_running; - if (fifo_nr_running) + if (rq->rt.rt_nr_running - rq->rt.rr_nr_running) return true; =20 /* --=20 2.18.2