From nobody Thu Feb 12 06:02:50 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDED6C77B73 for ; Thu, 27 Apr 2023 12:13:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243826AbjD0MNS (ORCPT ); Thu, 27 Apr 2023 08:13:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243828AbjD0MMq (ORCPT ); Thu, 27 Apr 2023 08:12:46 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB43159F8; Thu, 27 Apr 2023 05:12:19 -0700 (PDT) Received: from kwepemm600012.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Q6ZKX56PyzLnsf; Thu, 27 Apr 2023 20:09:20 +0800 (CST) Received: from build.huawei.com (10.175.101.6) by kwepemm600012.china.huawei.com (7.193.23.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 20:12:04 +0800 From: Wenchao Hao To: "James E . J . Bottomley" , "Martin K . Petersen" , Douglas Gilbert , , CC: , , Wenchao Hao Subject: [PATCH v2 3/6] scsi:scsi_debug: Define grammar to remove added error injection Date: Fri, 28 Apr 2023 09:33:17 +0800 Message-ID: <20230428013320.347050-4-haowenchao2@huawei.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20230428013320.347050-1-haowenchao2@huawei.com> References: <20230428013320.347050-1-haowenchao2@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600012.china.huawei.com (7.193.23.74) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The grammar to remove error injection is a line with fixed 3 columns separated by spaces. First column is fixed to "-". It tells this is a removal operation. Second column is the error code to match. Third column is the scsi command to match. For example the following command would remove timeout injection of inquiry command. echo "- 0 0x12" > /sys/kernel/debug/scsi_debug/0:0:0:1/error Signed-off-by: Wenchao Hao --- drivers/scsi/scsi_debug.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index 1d19a2f1f5f2..2c380cddcb84 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -925,6 +925,33 @@ static void sdebug_err_add(struct scsi_device *sdev, s= truct sdebug_err_inject *n list_add_tail(&new->list, &devip->inject_err_list); } =20 +static int sdebug_err_remove(struct scsi_device *sdev, const char *buf, si= ze_t count) +{ + struct sdebug_dev_info *devip =3D (struct sdebug_dev_info *)sdev->hostdat= a; + struct sdebug_err_inject *tmp, *err; + int type; + unsigned char cmd; + + if (sscanf(buf, "- %d %hhx", &type, &cmd) !=3D 2) { + kfree(buf); + return -EINVAL; + } + + list_for_each_entry_safe(err, tmp, &devip->inject_err_list, list) { + if (err->type =3D=3D type && err->cmd =3D=3D cmd) { + sdev_printk(KERN_INFO, sdev, "Remove %d 0x%x\n", + err->type, err->cmd); + list_del(&err->list); + kfree(err); + kfree(buf); + return count; + } + } + + kfree(buf); + return -EINVAL; +} + static int sdebug_error_show(struct seq_file *m, void *p) { struct scsi_device *sdev =3D (struct scsi_device *)m->private; @@ -980,6 +1007,9 @@ static ssize_t sdebug_error_write(struct file *file, c= onst char __user *ubuf, return -EFAULT; } =20 + if (buf[0] =3D=3D '-') + return sdebug_err_remove(sdev, buf, count); + if (sscanf(buf, "%d", &inject_type) !=3D 1) { kfree(buf); return -EINVAL; --=20 2.32.0