From nobody Thu Dec 18 08:54:17 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8197C77B60 for ; Thu, 27 Apr 2023 01:30:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242778AbjD0Bax (ORCPT ); Wed, 26 Apr 2023 21:30:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232094AbjD0Bav (ORCPT ); Wed, 26 Apr 2023 21:30:51 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0D7F26BC; Wed, 26 Apr 2023 18:30:49 -0700 (PDT) Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Q6J4F70RtzpTCX; Thu, 27 Apr 2023 09:26:53 +0800 (CST) Received: from localhost.localdomain (10.67.174.95) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 27 Apr 2023 09:30:47 +0800 From: Yang Jihong To: , , , , , , , , , , , , CC: Subject: [PATCH] perf symbols: Fix return incorrect build_id size in elf_read_build_id() Date: Thu, 27 Apr 2023 01:28:41 +0000 Message-ID: <20230427012841.231729-1-yangjihong1@huawei.com> X-Mailer: git-send-email 2.30.GIT MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.67.174.95] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In elf_read_build_id(), if gnu build_id is found, should return the size of the actually copied data. If descsz is greater thanBuild_ID_SIZE, write_buildid data access may occur. Fixes: be96ea8ffa78 ("perf symbols: Fix issue with binaries using 16-bytes = buildids (v2)") Reported-by: Will Ochowicz Link: https://lore.kernel.org/lkml/CWLP265MB49702F7BA3D6D8F13E4B1A719C649@C= WLP265MB4970.GBRP265.PROD.OUTLOOK.COM/T/ Tested-by: Will Ochowicz Signed-off-by: Yang Jihong Acked-by: Adrian Hunter --- tools/perf/util/symbol-elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 41882ae8452e..059f88eca630 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -903,7 +903,7 @@ static int elf_read_build_id(Elf *elf, void *bf, size_t= size) size_t sz =3D min(size, descsz); memcpy(bf, ptr, sz); memset(bf + sz, 0, size - sz); - err =3D descsz; + err =3D sz; break; } } --=20 2.30.GIT