From nobody Wed Feb 11 00:59:32 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C87D8C6FD18 for ; Tue, 25 Apr 2023 13:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233424AbjDYN2h (ORCPT ); Tue, 25 Apr 2023 09:28:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233308AbjDYN2e (ORCPT ); Tue, 25 Apr 2023 09:28:34 -0400 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37296CC08; Tue, 25 Apr 2023 06:28:31 -0700 (PDT) Received: from localhost.localdomain ([172.16.0.254]) (user=ziqin_l@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33PDQ3id031077-33PDQ3ie031077 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Tue, 25 Apr 2023 21:26:21 +0800 From: Ziqin Liu To: dzm91@hust.edu.cn, Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno Cc: hust-os-kernel-patches@googlegroups.com, Ziqin Liu , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] clk: mediatek: clk-mt8173: fix memory leak in clk_mt8173_apmixed_probe Date: Tue, 25 Apr 2023 21:26:00 +0800 Message-Id: <20230425132601.106181-1-ziqin_l@hust.edu.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: ziqin_l@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 'base' from of_iomap() is not released until the prode function returns, a memory leak will occur in some case, so use devm_of_iomap() instead of of_iomap() to automatically handle the unused ioremap region. Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock drivers and a= llow module build") Signed-off-by: Ziqin Liu --- drivers/clk/mediatek/clk-mt8173-apmixedsys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/med= iatek/clk-mt8173-apmixedsys.c index a56c5845d07a..f80de9e60b21 100644 --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c @@ -90,7 +90,7 @@ static int clk_mt8173_apmixed_probe(struct platform_devic= e *pdev) struct clk_hw *hw; int r; =20 - base =3D of_iomap(node, 0); + base =3D devm_of_iomap(pdev->dev, node, 0, NULL); if (!base) return PTR_ERR(base); =20 --=20 2.25.1