From nobody Thu Dec 18 04:50:50 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D7B1C7618E for ; Mon, 24 Apr 2023 03:40:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbjDXDkf (ORCPT ); Sun, 23 Apr 2023 23:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230419AbjDXDju (ORCPT ); Sun, 23 Apr 2023 23:39:50 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7C3C2D50; Sun, 23 Apr 2023 20:39:46 -0700 (PDT) Received: from dggpeml500021.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Q4W7r5ZzxzKtYv; Mon, 24 Apr 2023 11:38:48 +0800 (CST) Received: from huawei.com (10.175.127.227) by dggpeml500021.china.huawei.com (7.185.36.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 24 Apr 2023 11:39:44 +0800 From: Baokun Li To: CC: , , , , , , , , Subject: [PATCH v4 10/12] ext4: make ext4_es_insert_delayed_block() return void Date: Mon, 24 Apr 2023 11:38:44 +0800 Message-ID: <20230424033846.4732-11-libaokun1@huawei.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230424033846.4732-1-libaokun1@huawei.com> References: <20230424033846.4732-1-libaokun1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500021.china.huawei.com (7.185.36.21) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Now it never fails when inserting a delay extent, so the return value in ext4_es_insert_delayed_block is no longer necessary, let it return void. Signed-off-by: Baokun Li Reviewed-by: Jan Kara --- fs/ext4/extents_status.c | 10 ++++------ fs/ext4/extents_status.h | 4 ++-- fs/ext4/inode.c | 10 ++-------- 3 files changed, 8 insertions(+), 16 deletions(-) diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c index 2a394c40f4b7..b12c5cfdf601 100644 --- a/fs/ext4/extents_status.c +++ b/fs/ext4/extents_status.c @@ -2020,11 +2020,9 @@ bool ext4_is_pending(struct inode *inode, ext4_lblk_= t lblk) * @lblk - logical block to be added * @allocated - indicates whether a physical cluster has been allocated for * the logical cluster that contains the block - * - * Returns 0 on success, negative error code on failure. */ -int ext4_es_insert_delayed_block(struct inode *inode, ext4_lblk_t lblk, - bool allocated) +void ext4_es_insert_delayed_block(struct inode *inode, ext4_lblk_t lblk, + bool allocated) { struct extent_status newes; int err1 =3D 0; @@ -2033,7 +2031,7 @@ int ext4_es_insert_delayed_block(struct inode *inode,= ext4_lblk_t lblk, struct extent_status *es2 =3D NULL; =20 if (EXT4_SB(inode->i_sb)->s_mount_state & EXT4_FC_REPLAY) - return 0; + return; =20 es_debug("add [%u/1) delayed to extent status tree of inode %lu\n", lblk, inode->i_ino); @@ -2075,7 +2073,7 @@ int ext4_es_insert_delayed_block(struct inode *inode,= ext4_lblk_t lblk, =20 ext4_es_print_tree(inode); ext4_print_pending_tree(inode); - return 0; + return; } =20 /* diff --git a/fs/ext4/extents_status.h b/fs/ext4/extents_status.h index 526a68890aa6..c22edb931f1b 100644 --- a/fs/ext4/extents_status.h +++ b/fs/ext4/extents_status.h @@ -249,8 +249,8 @@ extern void ext4_exit_pending(void); extern void ext4_init_pending_tree(struct ext4_pending_tree *tree); extern void ext4_remove_pending(struct inode *inode, ext4_lblk_t lblk); extern bool ext4_is_pending(struct inode *inode, ext4_lblk_t lblk); -extern int ext4_es_insert_delayed_block(struct inode *inode, ext4_lblk_t l= blk, - bool allocated); +extern void ext4_es_insert_delayed_block(struct inode *inode, ext4_lblk_t = lblk, + bool allocated); extern unsigned int ext4_es_delayed_clu(struct inode *inode, ext4_lblk_t l= blk, ext4_lblk_t len); extern void ext4_clear_inode_es(struct inode *inode); diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index a0bfe77d5537..4221b2dafeb5 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -1641,9 +1641,8 @@ static void ext4_print_free_blocks(struct inode *inod= e) static int ext4_insert_delayed_block(struct inode *inode, ext4_lblk_t lblk) { struct ext4_sb_info *sbi =3D EXT4_SB(inode->i_sb); - int ret; + int ret =3D 0; bool allocated =3D false; - bool reserved =3D false; =20 /* * If the cluster containing lblk is shared with a delayed, @@ -1660,7 +1659,6 @@ static int ext4_insert_delayed_block(struct inode *in= ode, ext4_lblk_t lblk) ret =3D ext4_da_reserve_space(inode); if (ret !=3D 0) /* ENOSPC */ goto errout; - reserved =3D true; } else { /* bigalloc */ if (!ext4_es_scan_clu(inode, &ext4_es_is_delonly, lblk)) { if (!ext4_es_scan_clu(inode, @@ -1673,7 +1671,6 @@ static int ext4_insert_delayed_block(struct inode *in= ode, ext4_lblk_t lblk) ret =3D ext4_da_reserve_space(inode); if (ret !=3D 0) /* ENOSPC */ goto errout; - reserved =3D true; } else { allocated =3D true; } @@ -1683,10 +1680,7 @@ static int ext4_insert_delayed_block(struct inode *i= node, ext4_lblk_t lblk) } } =20 - ret =3D ext4_es_insert_delayed_block(inode, lblk, allocated); - if (ret && reserved) - ext4_da_release_space(inode, 1); - + ext4_es_insert_delayed_block(inode, lblk, allocated); errout: return ret; } --=20 2.31.1