From nobody Tue Dec 16 12:21:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F9BC77B60 for ; Mon, 24 Apr 2023 02:43:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230300AbjDXCnu (ORCPT ); Sun, 23 Apr 2023 22:43:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjDXCnr (ORCPT ); Sun, 23 Apr 2023 22:43:47 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81A4F114; Sun, 23 Apr 2023 19:43:45 -0700 (PDT) Received: from dd-virtual-machine.localdomain ([60.247.94.10]) (user=u202110722@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33O2fgfs005788-33O2fgft005788 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 24 Apr 2023 10:42:03 +0800 From: Jianuo Kuang To: Krzysztof Kozlowski , Thierry Escande , Samuel Ortiz Cc: hust-os-kernel-patches@googlegroups.com, Jianuo Kuang , Dongliang Mu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] drivers: nfc: nfcsim: remove return value check of `dev_dir` Date: Mon, 24 Apr 2023 10:41:40 +0800 Message-Id: <20230424024140.34607-1-u202110722@hust.edu.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: u202110722@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Smatch complains that: nfcsim_debugfs_init_dev() warn: 'dev_dir' is an error pointer or valid According to the documentation of the debugfs_create_dir() function, there is no need to check the return value of this function. Just delete the dead code. Fixes: f9ac6273e5b8 ("NFC: nfcsim: Add support for sysfs control entry") Signed-off-by: Jianuo Kuang Reviewed-by: Dongliang Mu Reviewed-by: Krzysztof Kozlowski --- drivers/nfc/nfcsim.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/nfc/nfcsim.c b/drivers/nfc/nfcsim.c index 85bf8d586c70..44eeb17ae48d 100644 --- a/drivers/nfc/nfcsim.c +++ b/drivers/nfc/nfcsim.c @@ -367,11 +367,6 @@ static void nfcsim_debugfs_init_dev(struct nfcsim *dev) } =20 dev_dir =3D debugfs_create_dir(devname, nfcsim_debugfs_root); - if (!dev_dir) { - NFCSIM_ERR(dev, "Could not create debugfs entries for nfc%d\n", - idx); - return; - } =20 debugfs_create_u8("dropframe", 0664, dev_dir, &dev->dropframe); } --=20 2.25.1