From nobody Tue Dec 16 16:38:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E00B6C77B7E for ; Mon, 24 Apr 2023 19:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232308AbjDXTsP (ORCPT ); Mon, 24 Apr 2023 15:48:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231625AbjDXTsM (ORCPT ); Mon, 24 Apr 2023 15:48:12 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E55D5FDC for ; Mon, 24 Apr 2023 12:48:10 -0700 (PDT) Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pr2AS-0005X3-UH for linux-kernel@vger.kernel.org; Mon, 24 Apr 2023 21:48:08 +0200 Received: from dspam.blackshift.org (localhost [127.0.0.1]) by bjornoya.blackshift.org (Postfix) with SMTP id 5E9471B65D6 for ; Mon, 24 Apr 2023 19:48:08 +0000 (UTC) Received: from hardanger.blackshift.org (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by bjornoya.blackshift.org (Postfix) with ESMTPS id 1451D1B65C6; Mon, 24 Apr 2023 19:48:04 +0000 (UTC) Received: from blackshift.org (localhost [::1]) by hardanger.blackshift.org (OpenSMTPD) with ESMTP id 915ffa8e; Mon, 24 Apr 2023 19:48:03 +0000 (UTC) From: Marc Kleine-Budde To: Mikhail Golubev-Ciuchea Cc: virtio-dev@lists.oasis-open.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Wolfgang Grandegger , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Michael S . Tsirkin" , Jason Wang , Harald Mommer , Marc Kleine-Budde Subject: [PATCH] can: virtio-can: cleanups Date: Mon, 24 Apr 2023 21:47:58 +0200 Message-Id: <20230424-modular-rebate-e54ac16374c8-mkl@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:b01:1d::7b X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Address the topics raised in https://lore.kernel.org/20230424-footwear-daily-9339bd0ec428-mkl@pengutroni= x.de Signed-off-by: Marc Kleine-Budde --- drivers/net/can/Makefile | 4 +-- drivers/net/can/virtio_can.c | 56 ++++++++++++++------------------- include/uapi/linux/virtio_can.h | 4 +-- 3 files changed, 28 insertions(+), 36 deletions(-) diff --git a/drivers/net/can/Makefile b/drivers/net/can/Makefile index e409f61d8e93..19314adaff59 100644 --- a/drivers/net/can/Makefile +++ b/drivers/net/can/Makefile @@ -17,8 +17,8 @@ obj-$(CONFIG_CAN_AT91) +=3D at91_can.o obj-$(CONFIG_CAN_BXCAN) +=3D bxcan.o obj-$(CONFIG_CAN_CAN327) +=3D can327.o obj-$(CONFIG_CAN_CC770) +=3D cc770/ -obj-$(CONFIG_CAN_C_CAN) +=3D c_can/ obj-$(CONFIG_CAN_CTUCANFD) +=3D ctucanfd/ +obj-$(CONFIG_CAN_C_CAN) +=3D c_can/ obj-$(CONFIG_CAN_FLEXCAN) +=3D flexcan/ obj-$(CONFIG_CAN_GRCAN) +=3D grcan.o obj-$(CONFIG_CAN_IFI_CANFD) +=3D ifi_canfd/ @@ -30,7 +30,7 @@ obj-$(CONFIG_CAN_PEAK_PCIEFD) +=3D peak_canfd/ obj-$(CONFIG_CAN_SJA1000) +=3D sja1000/ obj-$(CONFIG_CAN_SUN4I) +=3D sun4i_can.o obj-$(CONFIG_CAN_TI_HECC) +=3D ti_hecc.o -obj-$(CONFIG_CAN_XILINXCAN) +=3D xilinx_can.o obj-$(CONFIG_CAN_VIRTIO_CAN) +=3D virtio_can.o +obj-$(CONFIG_CAN_XILINXCAN) +=3D xilinx_can.o =20 subdir-ccflags-$(CONFIG_CAN_DEBUG_DEVICES) +=3D -DDEBUG diff --git a/drivers/net/can/virtio_can.c b/drivers/net/can/virtio_can.c index 23f9c1b6446d..c11a652613d0 100644 --- a/drivers/net/can/virtio_can.c +++ b/drivers/net/can/virtio_can.c @@ -312,13 +312,12 @@ static netdev_tx_t virtio_can_start_xmit(struct sk_bu= ff *skb, struct scatterlist sg_in[1]; struct scatterlist *sgs[2]; unsigned long flags; - size_t len; u32 can_flags; int err; netdev_tx_t xmit_ret =3D NETDEV_TX_OK; const unsigned int hdr_size =3D offsetof(struct virtio_can_tx_out, sdu); =20 - if (can_dropped_invalid_skb(dev, skb)) + if (can_dev_dropped_skb(dev, skb)) goto kick; /* No way to return NET_XMIT_DROP here */ =20 /* Virtio CAN does not support error message frames */ @@ -338,27 +337,25 @@ static netdev_tx_t virtio_can_start_xmit(struct sk_bu= ff *skb, =20 can_tx_msg->tx_out.msg_type =3D cpu_to_le16(VIRTIO_CAN_TX); can_flags =3D 0; - if (cf->can_id & CAN_EFF_FLAG) + + if (cf->can_id & CAN_EFF_FLAG) { can_flags |=3D VIRTIO_CAN_FLAGS_EXTENDED; + can_tx_msg->tx_out.can_id =3D cpu_to_le32(cf->can_id & CAN_EFF_MASK); + } else { + can_tx_msg->tx_out.can_id =3D cpu_to_le32(cf->can_id & CAN_SFF_MASK); + } if (cf->can_id & CAN_RTR_FLAG) can_flags |=3D VIRTIO_CAN_FLAGS_RTR; + else + memcpy(can_tx_msg->tx_out.sdu, cf->data, cf->len); if (can_is_canfd_skb(skb)) can_flags |=3D VIRTIO_CAN_FLAGS_FD; + can_tx_msg->tx_out.flags =3D cpu_to_le32(can_flags); - can_tx_msg->tx_out.can_id =3D cpu_to_le32(cf->can_id & CAN_EFF_MASK); - len =3D cf->len; - can_tx_msg->tx_out.length =3D len; - if (len > sizeof(cf->data)) - len =3D sizeof(cf->data); - if (len > sizeof(can_tx_msg->tx_out.sdu)) - len =3D sizeof(can_tx_msg->tx_out.sdu); - if (!(can_flags & VIRTIO_CAN_FLAGS_RTR)) { - /* Copy if not a RTR frame. RTR frames have a DLC but no payload */ - memcpy(can_tx_msg->tx_out.sdu, cf->data, len); - } + can_tx_msg->tx_out.length =3D cpu_to_le16(cf->len); =20 /* Prepare sending of virtio message */ - sg_init_one(&sg_out[0], &can_tx_msg->tx_out, hdr_size + len); + sg_init_one(&sg_out[0], &can_tx_msg->tx_out, hdr_size + cf->len); sg_init_one(&sg_in[0], &can_tx_msg->tx_in, sizeof(can_tx_msg->tx_in)); sgs[0] =3D sg_out; sgs[1] =3D sg_in; @@ -895,8 +892,8 @@ static int virtio_can_probe(struct virtio_device *vdev) priv->tx_putidx_list =3D kcalloc(echo_skb_max, sizeof(struct list_head), GFP_KERNEL); if (!priv->tx_putidx_list) { - free_candev(dev); - return -ENOMEM; + err =3D -ENOMEM; + goto on_failure; } =20 INIT_LIST_HEAD(&priv->tx_putidx_free); @@ -914,7 +911,6 @@ static int virtio_can_probe(struct virtio_device *vdev) vdev->priv =3D priv; =20 priv->can.do_set_mode =3D virtio_can_set_mode; - priv->can.state =3D CAN_STATE_STOPPED; /* Set Virtio CAN supported operations */ priv->can.ctrlmode_supported =3D CAN_CTRLMODE_BERR_REPORTING; if (virtio_has_feature(vdev, VIRTIO_CAN_F_CAN_FD)) { @@ -968,11 +964,10 @@ static int virtio_can_probe(struct virtio_device *vde= v) return err; } =20 -#ifdef CONFIG_PM_SLEEP /* Compare with m_can.c/m_can_suspend(), virtio_net.c/virtnet_freeze() and * virtio_card.c/virtsnd_freeze() */ -static int virtio_can_freeze(struct virtio_device *vdev) +static int __maybe_unused virtio_can_freeze(struct virtio_device *vdev) { struct virtio_can_priv *priv =3D vdev->priv; struct net_device *ndev =3D priv->dev; @@ -996,7 +991,7 @@ static int virtio_can_freeze(struct virtio_device *vdev) /* Compare with m_can.c/m_can_resume(), virtio_net.c/virtnet_restore() and * virtio_card.c/virtsnd_restore() */ -static int virtio_can_restore(struct virtio_device *vdev) +static int __maybe_unused virtio_can_restore(struct virtio_device *vdev) { struct virtio_can_priv *priv =3D vdev->priv; struct net_device *ndev =3D priv->dev; @@ -1020,7 +1015,6 @@ static int virtio_can_restore(struct virtio_device *v= dev) =20 return 0; } -#endif /* #ifdef CONFIG_PM_SLEEP */ =20 static struct virtio_device_id virtio_can_id_table[] =3D { { VIRTIO_ID_CAN, VIRTIO_DEV_ANY_ID }, @@ -1037,18 +1031,16 @@ static unsigned int features[] =3D { static struct virtio_driver virtio_can_driver =3D { .feature_table =3D features, .feature_table_size =3D ARRAY_SIZE(features), - .feature_table_legacy =3D NULL, - .feature_table_size_legacy =3D 0, - .driver.name =3D KBUILD_MODNAME, - .driver.owner =3D THIS_MODULE, - .id_table =3D virtio_can_id_table, - .validate =3D virtio_can_validate, - .probe =3D virtio_can_probe, - .remove =3D virtio_can_remove, + .driver.name =3D KBUILD_MODNAME, + .driver.owner =3D THIS_MODULE, + .id_table =3D virtio_can_id_table, + .validate =3D virtio_can_validate, + .probe =3D virtio_can_probe, + .remove =3D virtio_can_remove, .config_changed =3D virtio_can_config_changed, #ifdef CONFIG_PM_SLEEP - .freeze =3D virtio_can_freeze, - .restore =3D virtio_can_restore, + .freeze =3D virtio_can_freeze, + .restore =3D virtio_can_restore, #endif }; =20 diff --git a/include/uapi/linux/virtio_can.h b/include/uapi/linux/virtio_ca= n.h index de85918aa7dc..f59a2ca6ebd1 100644 --- a/include/uapi/linux/virtio_can.h +++ b/include/uapi/linux/virtio_can.h @@ -35,7 +35,7 @@ struct virtio_can_config { struct virtio_can_tx_out { #define VIRTIO_CAN_TX 0x0001 __le16 msg_type; - __le16 length; /* 0..8 CC, 0..64 CAN=C2=ADFD, 0..2048 CAN=C2=ADXL, 12 bit= s */ + __le16 length; /* 0..8 CC, 0..64 CAN-FD, 0..2048 CAN-XL, 12 bits */ __le32 reserved; /* May be needed in part for CAN XL priority */ __le32 flags; __le32 can_id; @@ -50,7 +50,7 @@ struct virtio_can_tx_in { struct virtio_can_rx { #define VIRTIO_CAN_RX 0x0101 __le16 msg_type; - __le16 length; /* 0..8 CC, 0..64 CAN=C2=ADFD, 0..2048 CAN=C2=ADXL, 12 bit= s */ + __le16 length; /* 0..8 CC, 0..64 CAN-FD, 0..2048 CAN-XL, 12 bits */ __le32 reserved; /* May be needed in part for CAN XL priority */ __le32 flags; __le32 can_id; --=20 2.39.2