From nobody Tue Dec 16 11:50:04 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A82C77B78 for ; Fri, 21 Apr 2023 18:34:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233316AbjDUSec (ORCPT ); Fri, 21 Apr 2023 14:34:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233276AbjDUSe3 (ORCPT ); Fri, 21 Apr 2023 14:34:29 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 629861FDF; Fri, 21 Apr 2023 11:34:25 -0700 (PDT) Received: from liber-MS-7D42.. ([10.12.190.56]) (user=gangecen@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33LIXGFS021888-33LIXGFT021888 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 22 Apr 2023 02:33:21 +0800 From: Gencen Gan To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Gan Gecen Cc: hust-os-kernel-patches@googlegroups.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3] net: amd: Fix link leak when verifying config failed Date: Sat, 22 Apr 2023 02:33:03 +0800 Message-Id: <20230421183304.155460-1-gangecen@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: gangecen@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After failing to verify configuration, it returns directly without releasing link, which may cause memory leak. Paolo Abeni thinks that the whole code of this driver is quite=20 "suboptimal" and looks unmainatained since at least ~15y, so he=20 suggests that we could simply remove the whole driver, please=20 take it into consideration. Fixes: 2b3af54dc373 ("net: amd: Fix link leak when verifying config failed") Signed-off-by: Gan Gecen Reviewed-by: Paolo Abeni --- v2->v3: Add Fixes tag and add a suggestion about this driver. drivers/net/ethernet/amd/nmclan_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/am= d/nmclan_cs.c index 823a329a921f..0dd391c84c13 100644 --- a/drivers/net/ethernet/amd/nmclan_cs.c +++ b/drivers/net/ethernet/amd/nmclan_cs.c @@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link) } else { pr_notice("mace id not found: %x %x should be 0x40 0x?9\n", sig[0], sig[1]); - return -ENODEV; + goto failed; } } =20 --=20 2.34.1