From nobody Wed Dec 17 11:50:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CA5C77B78 for ; Thu, 20 Apr 2023 09:45:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229709AbjDTJpZ (ORCPT ); Thu, 20 Apr 2023 05:45:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234592AbjDTJoy (ORCPT ); Thu, 20 Apr 2023 05:44:54 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9D0B59C6; Thu, 20 Apr 2023 02:43:39 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-63b64a32fd2so1096046b3a.2; Thu, 20 Apr 2023 02:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681983819; x=1684575819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=22leYJ3fAb4IkKSKuxkJCnb9O++TiihTGfleYhQ+ChY=; b=If5DiSAjADKIt80CoPoUC7iaYoGdq5Nj5LLX+iGoVlCAZ2X5aNSHBb8xfEix3dC2JP D7NwB+Y+b6ExmBuaF78sOefmi8Yolc9RKHBwNWZMPPJ9C9cBcFQnnIluJXUdU7N9xlMz Og29T+R3u+33FLsc+NKrv7XNo7k7GCpsoGrjfWvKMrouBBCcJAKV3CAcOSCx0LGqruD4 vGgl+cRKRegFAabNJ2T5iAgE6ObmpVrdxw/2S5IfxpPYYh/81f7g/+7iHJetwHmZB8Tv Y0W1wlvLWm+n2Ja6/AB4SyupmbkeJkjXOIShJzT+fUGx8h/3M2+gqcNO4sOrmiO4UaYU iruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681983819; x=1684575819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=22leYJ3fAb4IkKSKuxkJCnb9O++TiihTGfleYhQ+ChY=; b=LeOl8n4xLYdGJvrLKCR/8Sn1G0rRqznQWIJo5nUfaZIjZZzXMupPz2yhsHgOusapbN CrhyuNOBFeTHVVhJkszLf9Rxq3FDseehxgBwZsQszPDoApieUERWwgN/x1NobNKo6rQJ StEFrONNScpWy7jzRUAKOSU9MF6M1iWjdgGvgC/VRhEW+oF2PE+3jdMlGSqXyD4eZojC K+gUwDonZCh3Y+Qu20JA67PkDgXH1dsjz8d8eTbugxMCtjaR1utaM+N9C5K42HkOegP5 5xmK1seTiSstGCtmaqyyhIfoeDmZmp2C+Zh+wXsLm5tcL15zQg22E4WNBBxvB7/dRCMo dppg== X-Gm-Message-State: AAQBX9fIn45hHiKOdo7B40mOok/Mtryt/LU+npvfcLBjm7KNImwuPnX5 jfaGeSjd2Ny915AKvWtbqQk= X-Google-Smtp-Source: AKy350aGNh2hdLifle8goSpF0ODdFVS27BI1Q0FBH3+lufe55qzou2nU9g+HcSbIZKEUn/ZR3zP7/Q== X-Received: by 2002:a05:6a00:1818:b0:63d:24e4:f9c with SMTP id y24-20020a056a00181800b0063d24e40f9cmr773922pfa.17.1681983819179; Thu, 20 Apr 2023 02:43:39 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id t1-20020a62d141000000b0063b8ce0e860sm874336pfl.21.2023.04.20.02.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 02:43:38 -0700 (PDT) From: korantwork@gmail.com To: dlemoal@kernel.org, helgaas@kernel.org, nirmal.patel@linux.intel.com, kbusch@kernel.org, jonathan.derrick@linux.dev, lpieralisi@kernel.org Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinghui Li , Dan Carpenter Subject: [PATCH v2 1/2] PCI: vmd: Fix one uninitialized symbol error reported by Smatch Date: Thu, 20 Apr 2023 17:43:31 +0800 Message-Id: <20230420094332.1507900-2-korantwork@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230420094332.1507900-1-korantwork@gmail.com> References: <20230420094332.1507900-1-korantwork@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Xinghui Li There is one uninitialized symbol error reported by smatch: "drivers/pci/controller/vmd.c:931 vmd_enable_domain() error: uninitialized symbol 'ret'." Fix it by assigning ret with pci_reset_bus return. Fixes: 0a584655ef89 ("PCI: vmd: Fix secondary bus reset for Intel bridges") Reported-by: Dan Carpenter Signed-off-by: Xinghui Li Reviewed-by: Nirmal Patel --- drivers/pci/controller/vmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 990630ec57c6..1a36e9a52b93 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -927,7 +927,8 @@ static int vmd_enable_domain(struct vmd_dev *vmd, unsig= ned long features) if (!list_empty(&child->devices)) { dev =3D list_first_entry(&child->devices, struct pci_dev, bus_list); - if (pci_reset_bus(dev)) + ret =3D pci_reset_bus(dev); + if (ret) pci_warn(dev, "can't reset device: %d\n", ret); =20 break; --=20 2.31.1 From nobody Wed Dec 17 11:50:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22BCC77B72 for ; Thu, 20 Apr 2023 09:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234479AbjDTJp3 (ORCPT ); Thu, 20 Apr 2023 05:45:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234609AbjDTJo4 (ORCPT ); Thu, 20 Apr 2023 05:44:56 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C14A1BE; Thu, 20 Apr 2023 02:43:42 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id d2e1a72fcca58-63b509fe13eso658017b3a.1; Thu, 20 Apr 2023 02:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681983822; x=1684575822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IT835FHNi4eC4qAmIN/OZRmU8iTSk2BDGuwcGxroAxI=; b=KYK+ePHNSqDAiv3omCR7zst85XghhmVd3WfUQmuLquIfIrv7OuXytSfqYxfT3MBYiC SxWiDkM+QZ1vRqv90s/96x/79QLaxahLgtAnubH+oOs1DlU6ZaMOOfbT4NIBlgZdWwV5 X6Q7GNNmYx5FU3uTxTHXECOHFAD+I2XN601tLvwc9BtGFVfCWyOItivAz457E66Bk/0/ 4JW9dP6BAap/XPhwD7h4LvHGFUoMmM+X1KrJcva5x7GZTs2m572il1M8jRAv8nwN0l3c NiC+o9mVNgID7RMqXI5C253jmAXMqPENI5TpASNwdY/fGe43RMeRQnUyjA9nzRDCk9nM w+QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681983822; x=1684575822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IT835FHNi4eC4qAmIN/OZRmU8iTSk2BDGuwcGxroAxI=; b=PxIXD2Yi2oV9mxEAVX1B8A4qPnSk/9DJldBr/QXcDmBZIAjzYdTv851uN3VjG857m8 TmYa16WY//fFvd7TZzYBeqPG0i2shJ8584VcfxOAV0Mq35c7zJ9773zCuXJUWIGoFBRg WidePaTk3W8cuSdGzszb3XwKjQdq6skHlrdhHLTu6Ng8cJXrFhfJkNlvHARtDiiXFf3c wCBf4cBZ9aL8jqfpnsJ6QYfLmu+bgtv7orgrRycvhksCB4mIsxNXHHwVf8vw4FyfsCQh 5jCrHcj0A3uXmFCiszv1/KnDCbHJq2b7E1B7MvWJvQKOKY3OOVOT5nX2Sh1Gfl5XPwm7 bIHg== X-Gm-Message-State: AAQBX9emqov8oS55RbWzaThILn92xykZu3byg1H9Tuk4Woz5rpodb2dt dsjtZ9ozdEN8crC67dhmtCI= X-Google-Smtp-Source: AKy350bghrZeQFXX0RutRlIwOIMLB3eyLNMwB+Kk4fzMrBqoeQsgB3djakmCSPppuLX0Qoa/O2WQIw== X-Received: by 2002:a05:6a00:1749:b0:63d:6228:6888 with SMTP id j9-20020a056a00174900b0063d62286888mr883906pfc.3.1681983821659; Thu, 20 Apr 2023 02:43:41 -0700 (PDT) Received: from localhost.localdomain ([43.132.141.8]) by smtp.gmail.com with ESMTPSA id t1-20020a62d141000000b0063b8ce0e860sm874336pfl.21.2023.04.20.02.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 02:43:41 -0700 (PDT) From: korantwork@gmail.com To: dlemoal@kernel.org, helgaas@kernel.org, nirmal.patel@linux.intel.com, kbusch@kernel.org, jonathan.derrick@linux.dev, lpieralisi@kernel.org Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinghui Li , Dan Carpenter Subject: [PATCH v2 2/2] PCI: vmd: Clean up one inconsistent indenting warn reported by Smatch Date: Thu, 20 Apr 2023 17:43:32 +0800 Message-Id: <20230420094332.1507900-3-korantwork@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230420094332.1507900-1-korantwork@gmail.com> References: <20230420094332.1507900-1-korantwork@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Xinghui Li There is one inconsistent indenting warning: "drivers/pci/controller/vmd.c:1058 vmd_resume() warn: inconsistent indenting" Fix it by formating its indenting. Reported-by: Dan Carpenter Signed-off-by: Xinghui Li Reviewed-by: Nirmal Patel --- drivers/pci/controller/vmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 1a36e9a52b93..1b68fa606bff 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -1056,10 +1056,10 @@ static int vmd_resume(struct device *dev) struct vmd_dev *vmd =3D pci_get_drvdata(pdev); int err, i; =20 - if (vmd->irq_domain) - vmd_set_msi_remapping(vmd, true); - else - vmd_set_msi_remapping(vmd, false); + if (vmd->irq_domain) + vmd_set_msi_remapping(vmd, true); + else + vmd_set_msi_remapping(vmd, false); =20 for (i =3D 0; i < vmd->msix_count; i++) { err =3D devm_request_irq(dev, vmd->irqs[i].virq, --=20 2.31.1