From nobody Wed Dec 17 11:53:33 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFD2C77B78 for ; Thu, 20 Apr 2023 08:20:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234395AbjDTIUc (ORCPT ); Thu, 20 Apr 2023 04:20:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233947AbjDTIU3 (ORCPT ); Thu, 20 Apr 2023 04:20:29 -0400 Received: from forwardcorp1c.mail.yandex.net (forwardcorp1c.mail.yandex.net [178.154.239.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B791635BB; Thu, 20 Apr 2023 01:20:26 -0700 (PDT) Received: from mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:3612:0:640:a8a8:0]) by forwardcorp1c.mail.yandex.net (Yandex) with ESMTP id 3AB675FA6A; Thu, 20 Apr 2023 11:20:22 +0300 (MSK) Received: from d-tatianin-nix.yandex-team.ru (unknown [2a02:6b8:b081:b409::1:14]) by mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id GKZned0OrSw0-ZMtL3jQ8; Thu, 20 Apr 2023 11:20:21 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1681978821; bh=9mp+pNldrwYKUsap4NBAwMn7ODY5PLISjDiGq37dX08=; h=Message-Id:Date:Cc:Subject:To:From; b=p+8OjW/Pwu2PIc8vaB50z4dLDff5X4bJ9YWx+S/Hjm711tgn+trXbY+HJlz7JU9Cg o8PzFCM3KY5rPAft0+3aELGcw8lmuNvEgDFIixh0+gCVVTIVM0ztQOyiiqq2aI1eLB 4g0XxHDpCXk2kT/4eAepg1G5ZnrbOJfBK8Fithak= Authentication-Results: mail-nwsmtp-smtp-corp-main-26.myt.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Daniil Tatianin To: Ariel Elior Cc: Daniil Tatianin , Manish Chopra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yuval Mintz , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] qed/qed_sriov: propagate errors from qed_init_run in enable_vf_access Date: Thu, 20 Apr 2023 11:20:16 +0300 Message-Id: <20230420082016.335314-1-d-tatianin@yandex-team.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The return value was silently ignored, and not propagated to the caller. Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Fixes: 1408cc1fa48c ("qed: Introduce VFs") Signed-off-by: Daniil Tatianin --- I'm not familiar enough with the code to know if there's anything we have to undo here in case qed_init_run returns an error. Any additional comments are appreciated. --- drivers/net/ethernet/qlogic/qed/qed_sriov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c b/drivers/net/ethe= rnet/qlogic/qed/qed_sriov.c index fa167b1aa019..5244d7208eb4 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c +++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c @@ -814,7 +814,7 @@ static int qed_iov_enable_vf_access(struct qed_hwfn *p_= hwfn, SET_FIELD(igu_vf_conf, IGU_VF_CONF_PARENT, p_hwfn->rel_pf_id); STORE_RT_REG(p_hwfn, IGU_REG_VF_CONFIGURATION_RT_OFFSET, igu_vf_conf); =20 - qed_init_run(p_hwfn, p_ptt, PHASE_VF, vf->abs_vf_id, + rc =3D qed_init_run(p_hwfn, p_ptt, PHASE_VF, vf->abs_vf_id, p_hwfn->hw_info.hw_mode); =20 /* unpretend */ --=20 2.25.1