From nobody Thu Feb 12 12:32:14 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 327B3C77B71 for ; Tue, 18 Apr 2023 07:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230086AbjDRHn3 (ORCPT ); Tue, 18 Apr 2023 03:43:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbjDRHn1 (ORCPT ); Tue, 18 Apr 2023 03:43:27 -0400 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6103A8; Tue, 18 Apr 2023 00:43:25 -0700 (PDT) Received: from zrt-virtual-machine.localdomain ([10.21.199.38]) (user=u202112078@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33I7d2Go022630-33I7d2Gp022630 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 18 Apr 2023 15:39:13 +0800 From: Ruting Zhang To: M Chetan Kumar , Intel Corporation , Loic Poulain , Sergey Ryazanov , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: hust-os-kernel-patches@googlegroups.com, Ruting Zhang , Dongliang Mu , M Chetan Kumar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: wwan: iosm: fix a resource leak in probe Date: Tue, 18 Apr 2023 15:38:57 +0800 Message-Id: <20230418073858.36507-1-u202112078@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: u202112078@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" drivers/net/wwan/iosm/iosm_ipc_pcie.c:298 ipc_pcie_probe() Smatch warn: missing unwind goto? There is a resource leak in this place. Fix it by changing "return ret" into "goto resources_req_fail". Fixes: 035e3befc191 ("net: wwan: iosm: fix driver not working with INTEL_IO= MMU disabled") Signed-off-by: Ruting Zhang Reviewed-by: Dongliang Mu --- The issue is found by static analysis and remains untested. --- drivers/net/wwan/iosm/iosm_ipc_pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wwan/iosm/iosm_ipc_pcie.c b/drivers/net/wwan/iosm/= iosm_ipc_pcie.c index 5bf5a93937c9..33339e8af1dc 100644 --- a/drivers/net/wwan/iosm/iosm_ipc_pcie.c +++ b/drivers/net/wwan/iosm/iosm_ipc_pcie.c @@ -295,7 +295,7 @@ static int ipc_pcie_probe(struct pci_dev *pci, ret =3D dma_set_mask(ipc_pcie->dev, DMA_BIT_MASK(64)); if (ret) { dev_err(ipc_pcie->dev, "Could not set PCI DMA mask: %d", ret); - return ret; + goto resources_req_fail; } =20 ipc_pcie_config_aspm(ipc_pcie); --=20 2.34.1