From nobody Wed Dec 17 21:16:04 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95844C77B75 for ; Tue, 18 Apr 2023 01:44:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231272AbjDRBoL (ORCPT ); Mon, 17 Apr 2023 21:44:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230280AbjDRBmz (ORCPT ); Mon, 17 Apr 2023 21:42:55 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 265557ED9 for ; Mon, 17 Apr 2023 18:41:54 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-54fde069e4aso98094617b3.3 for ; Mon, 17 Apr 2023 18:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681782101; x=1684374101; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ikqE+zYz1BXZh8mMNk5W0C4vdov8fukuxDv9VBrvDl0=; b=lWajx8mafW1seUIDD7+qIrKfh1VFBzwDUsLiwI++++Oz4bdMluxYPYY5tEsxAWa6CH vxq2L9Ahhr00QlIXhuRa3H0R5r+rycy5muTibHI7wt1orB3xYTatC8P/ujh+GxeJv/Ea /qsU11Dq37CWkGOvJwpF5+roapL50puA2pWR52NQY0wwb8g7QRm+EFltGejT5i4Jt/Y1 OXZxsrsSrppo/t9R3VKyB1ZTuREyblAyqTJ0f7YYvHtuCgBmBUieoHEv00v6QvsgLSJm 90ZuhZjoOrQHXNOmhPGdV9IuQx/Xj2Nnt6uh+MJyIttYHlPKKkqeKwTrP9CBD6HG1qXp E0dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681782101; x=1684374101; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ikqE+zYz1BXZh8mMNk5W0C4vdov8fukuxDv9VBrvDl0=; b=OutaYPA2yB1vs/evnmcrBwIqd3Xbv4qhO0OlMLB72U2WnrZ4DJW6as0U7fenyYxoXJ nbW8bYgqIe1YI6DoWX3b1JfOVVolVXP90BFRfYnaD8jJ3w9L5lzon+zqhkDelvMx4q1y mHgiWsXxS8UWBqn8hC6LpaQorOqGE7gY0tw7x2xB1M0xY2VGW4p3sHtS3hpTcnn8tlRo waVWVHzrx4s71hCURNaVJOYABJ1b1Z39WsbNo+XMRcyjak6S0Kmlbi7UrhdvLG+eRzym ZGCu64ddMqfDiV9AYfcZm5Yt3SgihlNtP2uRgmBPee2+sXiBZ43SCea/L8EjnZ2AFqLN bjiw== X-Gm-Message-State: AAQBX9cRHTZAAYclWyDlBMULBIAQE9Sd0eQ4cfvG9AIaQYoFW+cjsvtE Q4epH/0s6ZolENKZLgWxnMCaO/+Cmlo= X-Google-Smtp-Source: AKy350Y8W7u23ruYQztA6DVfVSc2+c8wyOOiKTHLOnbBM9IdQq81SwSucFeU6gGP5hv1qDXkZmp6krD4aBI= X-Received: from drosen.mtv.corp.google.com ([2620:15c:211:201:e67a:98b0:942d:86aa]) (user=drosen job=sendgmr) by 2002:a81:a807:0:b0:552:f777:88ce with SMTP id f7-20020a81a807000000b00552f77788cemr2101987ywh.3.1681782101478; Mon, 17 Apr 2023 18:41:41 -0700 (PDT) Date: Mon, 17 Apr 2023 18:40:22 -0700 In-Reply-To: <20230418014037.2412394-1-drosen@google.com> Mime-Version: 1.0 References: <20230418014037.2412394-1-drosen@google.com> X-Mailer: git-send-email 2.40.0.634.g4ca3ef3211-goog Message-ID: <20230418014037.2412394-23-drosen@google.com> Subject: [RFC PATCH v3 22/37] fuse-bpf: Add support for FUSE_COPY_FILE_RANGE From: Daniel Rosenberg To: Miklos Szeredi , bpf@vger.kernel.org, Alexei Starovoitov Cc: Amir Goldstein , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, Daniel Borkmann , John Fastabend , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Jonathan Corbet , Joanne Koong , Mykola Lysenko , kernel-team@android.com, Daniel Rosenberg , Paul Lawrence Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This adds backing support for FUSE_COPY_FILE_RANGE Signed-off-by: Daniel Rosenberg Signed-off-by: Paul Lawrence --- fs/fuse/backing.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++ fs/fuse/file.c | 4 +++ fs/fuse/fuse_i.h | 10 ++++++ 3 files changed, 101 insertions(+) diff --git a/fs/fuse/backing.c b/fs/fuse/backing.c index 6a6130a16d2b..928b24db2303 100644 --- a/fs/fuse/backing.c +++ b/fs/fuse/backing.c @@ -801,6 +801,93 @@ int fuse_bpf_lseek(loff_t *out, struct inode *inode, s= truct file *file, loff_t o file, offset, whence); } =20 +struct fuse_copy_file_range_args { + struct fuse_copy_file_range_in in; + struct fuse_write_out out; +}; + +static int fuse_copy_file_range_initialize_in(struct bpf_fuse_args *fa, + struct fuse_copy_file_range_args *args, + struct file *file_in, loff_t pos_in, struct file *file_out, + loff_t pos_out, size_t len, unsigned int flags) +{ + struct fuse_file *fuse_file_in =3D file_in->private_data; + struct fuse_file *fuse_file_out =3D file_out->private_data; + + args->in =3D (struct fuse_copy_file_range_in) { + .fh_in =3D fuse_file_in->fh, + .off_in =3D pos_in, + .nodeid_out =3D fuse_file_out->nodeid, + .fh_out =3D fuse_file_out->fh, + .off_out =3D pos_out, + .len =3D len, + .flags =3D flags, + }; + + *fa =3D (struct bpf_fuse_args) { + .info =3D (struct bpf_fuse_meta_info) { + .nodeid =3D get_node_id(file_in->f_inode), + .opcode =3D FUSE_COPY_FILE_RANGE, + }, + .in_numargs =3D 1, + .in_args[0].size =3D sizeof(args->in), + .in_args[0].value =3D &args->in, + }; + + return 0; +} + +static int fuse_copy_file_range_initialize_out(struct bpf_fuse_args *fa, + struct fuse_copy_file_range_args *args, + struct file *file_in, loff_t pos_in, struct file *file_out, + loff_t pos_out, size_t len, unsigned int flags) +{ + fa->out_numargs =3D 1; + fa->out_args[0].size =3D sizeof(args->out); + fa->out_args[0].value =3D &args->out; + + return 0; +} + +static int fuse_copy_file_range_backing(struct bpf_fuse_args *fa, ssize_t = *out, struct file *file_in, + loff_t pos_in, struct file *file_out, loff_t pos_out, size_t len, + unsigned int flags) +{ + const struct fuse_copy_file_range_in *fci =3D fa->in_args[0].value; + struct fuse_file *fuse_file_in =3D file_in->private_data; + struct file *backing_file_in =3D fuse_file_in->backing_file; + struct fuse_file *fuse_file_out =3D file_out->private_data; + struct file *backing_file_out =3D fuse_file_out->backing_file; + + /* TODO: Handle changing of in/out files */ + if (backing_file_out) + *out =3D vfs_copy_file_range(backing_file_in, fci->off_in, backing_file_= out, + fci->off_out, fci->len, fci->flags); + else + *out =3D generic_copy_file_range(file_in, pos_in, file_out, pos_out, len, + flags); + return 0; +} + +static int fuse_copy_file_range_finalize(struct bpf_fuse_args *fa, ssize_t= *out, struct file *file_in, + loff_t pos_in, struct file *file_out, loff_t pos_out, size_t len, + unsigned int flags) +{ + return 0; +} + +int fuse_bpf_copy_file_range(ssize_t *out, struct inode *inode, struct fil= e *file_in, + loff_t pos_in, struct file *file_out, loff_t pos_out, size_t len, + unsigned int flags) +{ + return bpf_fuse_backing(inode, struct fuse_copy_file_range_args, out, + fuse_copy_file_range_initialize_in, + fuse_copy_file_range_initialize_out, + fuse_copy_file_range_backing, + fuse_copy_file_range_finalize, + file_in, pos_in, file_out, pos_out, len, flags); +} + static int fuse_fsync_initialize_in(struct bpf_fuse_args *fa, struct fuse_= fsync_in *in, struct file *file, loff_t start, loff_t end, int datasync) { diff --git a/fs/fuse/file.c b/fs/fuse/file.c index a4a0aeb28e4a..8179afe28c6f 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -3199,6 +3199,10 @@ static ssize_t __fuse_copy_file_range(struct file *f= ile_in, loff_t pos_in, bool is_unstable =3D (!fc->writeback_cache) && ((pos_out + len) > inode_out->i_size); =20 + if (fuse_bpf_copy_file_range(&err, file_inode(file_in), file_in, pos_in, + file_out, pos_out, len, flags)) + return err; + if (fc->no_copy_file_range) return -EOPNOTSUPP; =20 diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h index 17899a1fe885..74540f308636 100644 --- a/fs/fuse/fuse_i.h +++ b/fs/fuse/fuse_i.h @@ -1421,6 +1421,9 @@ int fuse_bpf_release(int *out, struct inode *inode, s= truct file *file); int fuse_bpf_releasedir(int *out, struct inode *inode, struct file *file); int fuse_bpf_flush(int *out, struct inode *inode, struct file *file, fl_ow= ner_t id); int fuse_bpf_lseek(loff_t *out, struct inode *inode, struct file *file, lo= ff_t offset, int whence); +int fuse_bpf_copy_file_range(ssize_t *out, struct inode *inode, struct fil= e *file_in, loff_t pos_in, + struct file *file_out, loff_t pos_out, + size_t len, unsigned int flags); int fuse_bpf_fsync(int *out, struct inode *inode, struct file *file, loff_= t start, loff_t end, int datasync); int fuse_bpf_dir_fsync(int *out, struct inode *inode, struct file *file, l= off_t start, loff_t end, int datasync); int fuse_bpf_file_read_iter(ssize_t *out, struct inode *inode, struct kioc= b *iocb, struct iov_iter *to); @@ -1500,6 +1503,13 @@ static inline int fuse_bpf_lseek(loff_t *out, struct= inode *inode, struct file * return 0; } =20 +static inline int fuse_bpf_copy_file_range(ssize_t *out, struct inode *ino= de, struct file *file_in, loff_t pos_in, + struct file *file_out, loff_t pos_out, + size_t len, unsigned int flags) +{ + return 0; +} + static inline int fuse_bpf_fsync(int *out, struct inode *inode, struct fil= e *file, loff_t start, loff_t end, int datasync) { return 0; --=20 2.40.0.634.g4ca3ef3211-goog