From nobody Wed Dec 17 23:54:43 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E017C77B70 for ; Mon, 17 Apr 2023 06:02:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229804AbjDQGC4 (ORCPT ); Mon, 17 Apr 2023 02:02:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbjDQGCw (ORCPT ); Mon, 17 Apr 2023 02:02:52 -0400 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D9382D53 for ; Sun, 16 Apr 2023 23:02:50 -0700 (PDT) Received: from dd-virtual-machine.localdomain ([60.247.94.10]) (user=U202112190@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33H618GE027391-33H618GF027391 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 17 Apr 2023 14:01:10 +0800 From: Hongqi Chen To: Patrik Jakobsson , David Airlie , Daniel Vetter , Dave Airlie , Alan Cox Cc: hust-os-kernel-patches@googlegroups.com, Hongqi Chen , Dongliang Mu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpu: gma500: psb_drv: add missing unwind goto Date: Mon, 17 Apr 2023 14:01:05 +0800 Message-Id: <20230417060105.16411-1-U202112190@hust.edu.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: U202112190@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Smatch reports that missing unwind goto in psb_driver_load(). drivers/gpu/drm/gma500/psb_drv.c:350 psb_driver_load() warn: missing unwind goto? psb_driver_unload() and psb_driver_load() exist in correspondence,=20 and psb_driver_unload() should be executed when the psb_do_init()=20 fails to initialize. Fixes: 5c49fd3aa0ab ("gma500: Add the core DRM files and headers") Signed-off-by: Hongqi Chen Reviewed-by: Dongliang Mu --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_= drv.c index cd9c73f5a64a..b5a276342129 100644 --- a/drivers/gpu/drm/gma500/psb_drv.c +++ b/drivers/gpu/drm/gma500/psb_drv.c @@ -347,7 +347,7 @@ static int psb_driver_load(struct drm_device *dev, unsi= gned long flags) =20 ret =3D psb_do_init(dev); if (ret) - return ret; + goto out_err; =20 /* Add stolen memory to SGX MMU */ ret =3D psb_mmu_insert_pfn_sequence(psb_mmu_get_default_pd(dev_priv->mmu), --=20 2.25.1