From nobody Wed Dec 17 23:56:44 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20A9DC77B72 for ; Sun, 16 Apr 2023 08:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230130AbjDPIKV (ORCPT ); Sun, 16 Apr 2023 04:10:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229728AbjDPIKS (ORCPT ); Sun, 16 Apr 2023 04:10:18 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1C25198C for ; Sun, 16 Apr 2023 01:10:17 -0700 (PDT) Received: from liber-MS-7D42.. ([10.12.190.56]) (user=gangecen@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33G89Eu5003804-33G89Eu6003804 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 16 Apr 2023 16:09:20 +0800 From: Gencen Gan To: Emma Anholt , David Airlie , Daniel Vetter , Gan Gecen Cc: hust-os-kernel-patches@googlegroups.com, Cheng Ziqiu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PING PATCH] drm/pl111: fix drm and dev leak when irq request failed. Date: Sun, 16 Apr 2023 16:09:07 +0800 Message-Id: <20230416080907.3895808-1-gangecen@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: gangecen@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Smatch reports: pl111_amba_probe() warn: missing unwind goto? Code segment for dev_put is: dev_put: drm_dev_put(drm); of_reserved_mem_device_release(dev); When err happened, jumping to dev_put will release drm and dev resources allocated or initialized=20 before. But after devm_request_irq() failed, it returns directly without releasing drm and dev,=20 which may cause memory leak. Fixes: 3f9d6bccff6c ("drm/pl111: fix drm and dev leak when irq request fail= ed") Signed-off-by: Gan Gecen Reviewed-by: Cheng Ziqiu --- drivers/gpu/drm/pl111/pl111_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl11= 1_drv.c index 00deba0b7271..52945f7e0aef 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -297,7 +297,7 @@ static int pl111_amba_probe(struct amba_device *amba_de= v, variant->name, priv); if (ret !=3D 0) { dev_err(dev, "%s failed irq %d\n", __func__, ret); - return ret; + goto dev_put; } =20 ret =3D pl111_modeset_init(drm); --=20 2.34.1