From nobody Thu Dec 18 07:50:39 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2CACC77B71 for ; Sat, 15 Apr 2023 12:01:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229796AbjDOMBt (ORCPT ); Sat, 15 Apr 2023 08:01:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjDOMBr (ORCPT ); Sat, 15 Apr 2023 08:01:47 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4E2A4ED5 for ; Sat, 15 Apr 2023 05:01:45 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id si1so22008655ejb.10 for ; Sat, 15 Apr 2023 05:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681560104; x=1684152104; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=loYQo7M8BRPGuxyliqbEUne9rPks6JWwMjKdxM22SSs=; b=jGVB7otariHvjr7dnZp+PuOdufOikW2BI2GlBSWMchRZ/oWSZKSFOjFNHoRnRBMg1t nNAw7Wzxsi7+Lis/dyrW0cGw6pqTWLQ0u+Z3K3znc92K1AaKAolwEnuU3q1OKDkUhe5N NDbJ7VLGeiCuHcjkNpSrY+nMJ/YHAaI3rtL2S+9LaMhwqCbDFpmXzAI4pdZ1u6sL11bp IFPFDALNa4XEz0TQ8YVZEbW8cjsVaxW287NPOj7wdl/r3BEfulTpE2xkSaxhI1N+a6pN dmYUD/MJPssGuHVLPvmoNmAjP+7dESXdwTQ9SRRrOClps9xT1rf4icBZVBxjSgD+9ZBz TaPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681560104; x=1684152104; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=loYQo7M8BRPGuxyliqbEUne9rPks6JWwMjKdxM22SSs=; b=PBPee+YTqlQbntpvzT1A/y+1E4H/QBf5rDcee0Sk4MHxxjNlkD4Gdrm0dxD8zgwjr2 LAaCYuwn/pNJ+xJBJ9UIG4YQOr76hL+wCIgpjT0arAa9eqCBlAiWMdktiAS0lzexzz2f B4kVfyeC3pW6he7dWL/a3lQiQAfAO9ujqVm2nKNUBHMmn/6hsSDsOBIWOR0ITt4WUzZP vR62SvzdmDEy9DSqiNZujECz3t62Kj0Y1+HzdzE7kG/ps7cBnNk/d5vpNOrhwFBfek1V vH4HaTUU/Jd0SId43b84yrVs/CP83tM4xTraiZCii1r3c8DAIQEHzmS9gUT/WsZb01vn DdHQ== X-Gm-Message-State: AAQBX9dADB0dcIxrJRBPu1zFkIcaHf1E/22VkNmGDJyjJ62/3qNrpEPV KeDFwGBYQ/IdzE/dPYcxUlU6qNRPGA== X-Google-Smtp-Source: AKy350YmaFJs1/xmFhjwsAqRQVbz9nW/no3u7zgOjqOjWNPqPuCBTPhi2s2MDnm4zhfZCCNPVriEgw== X-Received: by 2002:a17:906:b756:b0:94a:82ca:12e5 with SMTP id fx22-20020a170906b75600b0094a82ca12e5mr1872166ejb.45.1681560104212; Sat, 15 Apr 2023 05:01:44 -0700 (PDT) Received: from koolguy (dslb-002-205-192-117.002.205.pools.vodafone-ip.de. [2.205.192.117]) by smtp.gmail.com with ESMTPSA id wz4-20020a170906fe4400b0094eeda0df09sm1930184ejb.179.2023.04.15.05.01.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 05:01:43 -0700 (PDT) Date: Sat, 15 Apr 2023 14:01:41 +0200 From: Dalvin-Ehinoma Noah Aiguobas To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2] staging: octeon: remove typedef declaration Message-ID: <20230415120141.GA6585@koolguy> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warning for enums. Change typedef cvmx_helper_interface_mode_t to enum cvmx_helper_interface_mode in ethernet.c Signed-off-by: Dalvin-Ehinoma Noah Aiguobas --- Changes in V2: -Remove Alignment fixes from previous version. drivers/staging/octeon/ethernet.c | 2 +- drivers/staging/octeon/octeon-stubs.h | 39 +++++++++++++-------------- 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/eth= ernet.c index 9eee28f2940c..023b107e077a 100644 --- a/drivers/staging/octeon/ethernet.c +++ b/drivers/staging/octeon/ethernet.c @@ -798,7 +798,7 @@ static int cvm_oct_probe(struct platform_device *pdev) =20 num_interfaces =3D cvmx_helper_get_number_of_interfaces(); for (interface =3D 0; interface < num_interfaces; interface++) { - cvmx_helper_interface_mode_t imode =3D + enum cvmx_helper_interface_mode imode =3D cvmx_helper_interface_get_mode(interface); int num_ports =3D cvmx_helper_ports_on_interface(interface); int port; diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon= /octeon-stubs.h index 3e7b92cd2e35..58708a7f727a 100644 --- a/drivers/staging/octeon/octeon-stubs.h +++ b/drivers/staging/octeon/octeon-stubs.h @@ -213,14 +213,14 @@ enum cvmx_fau_op_size { CVMX_FAU_OP_SIZE_64 =3D 3 }; =20 -typedef enum { +enum cvmx_spi_mode { CVMX_SPI_MODE_UNKNOWN =3D 0, CVMX_SPI_MODE_TX_HALFPLEX =3D 1, CVMX_SPI_MODE_RX_HALFPLEX =3D 2, CVMX_SPI_MODE_DUPLEX =3D 3 -} cvmx_spi_mode_t; +}; =20 -typedef enum { +enum cvmx_helper_interface_mode { CVMX_HELPER_INTERFACE_MODE_DISABLED, CVMX_HELPER_INTERFACE_MODE_RGMII, CVMX_HELPER_INTERFACE_MODE_GMII, @@ -231,20 +231,20 @@ typedef enum { CVMX_HELPER_INTERFACE_MODE_PICMG, CVMX_HELPER_INTERFACE_MODE_NPI, CVMX_HELPER_INTERFACE_MODE_LOOP, -} cvmx_helper_interface_mode_t; +}; =20 -typedef enum { +enum cvmx_pow_wait { CVMX_POW_WAIT =3D 1, CVMX_POW_NO_WAIT =3D 0, -} cvmx_pow_wait_t; +}; =20 -typedef enum { +enum cvmx_pko_lock { CVMX_PKO_LOCK_NONE =3D 0, CVMX_PKO_LOCK_ATOMIC_TAG =3D 1, CVMX_PKO_LOCK_CMD_QUEUE =3D 2, -} cvmx_pko_lock_t; +}; =20 -typedef enum { +enum cvmx_pko_status { CVMX_PKO_SUCCESS, CVMX_PKO_INVALID_PORT, CVMX_PKO_INVALID_QUEUE, @@ -252,7 +252,7 @@ typedef enum { CVMX_PKO_NO_MEMORY, CVMX_PKO_PORT_ALREADY_SETUP, CVMX_PKO_CMD_QUEUE_INIT_ERROR -} cvmx_pko_status_t; +}; =20 enum cvmx_pow_tag_type { CVMX_POW_TAG_TYPE_ORDERED =3D 0L, @@ -1265,8 +1265,7 @@ static inline void cvmx_pko_get_port_status(uint64_t = port_num, uint64_t clear, cvmx_pko_port_status_t *status) { } =20 -static inline cvmx_helper_interface_mode_t cvmx_helper_interface_get_mode(= int - interface) +static inline enum cvmx_helper_interface_mode cvmx_helper_interface_get_mo= de(int interface) { return 0; } @@ -1342,11 +1341,11 @@ static inline unsigned int cvmx_get_core_num(void) } =20 static inline void cvmx_pow_work_request_async_nocheck(int scr_addr, - cvmx_pow_wait_t wait) + enum cvmx_pow_wait wait) { } =20 static inline void cvmx_pow_work_request_async(int scr_addr, - cvmx_pow_wait_t wait) + enum cvmx_pow_wait wait) { } =20 static inline struct cvmx_wqe *cvmx_pow_work_response_async(int scr_addr) @@ -1356,13 +1355,13 @@ static inline struct cvmx_wqe *cvmx_pow_work_respon= se_async(int scr_addr) return wqe; } =20 -static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t = wait) +static inline struct cvmx_wqe *cvmx_pow_work_request_sync(enum cvmx_pow_wa= it wait) { return (void *)(unsigned long)wait; } =20 static inline int cvmx_spi_restart_interface(int interface, - cvmx_spi_mode_t mode, int timeout) + enum cvmx_spi_mode mode, int timeout) { return 0; } @@ -1381,12 +1380,12 @@ static inline union cvmx_gmxx_rxx_rx_inbnd cvmx_spi= 4000_check_speed(int interfac } =20 static inline void cvmx_pko_send_packet_prepare(uint64_t port, uint64_t qu= eue, - cvmx_pko_lock_t use_locking) + enum cvmx_pko_lock use_locking) { } =20 -static inline cvmx_pko_status_t cvmx_pko_send_packet_finish(uint64_t port, - uint64_t queue, union cvmx_pko_command_word0 pko_command, - union cvmx_buf_ptr packet, cvmx_pko_lock_t use_locking) +static inline enum cvmx_pko_status cvmx_pko_send_packet_finish(uint64_t po= rt, + uint64_t queue, union cvmx_pko_command_word0 pko_command, + union cvmx_buf_ptr packet, enum cvmx_pko_lock use_locking) { return 0; } --=20 2.25.1