From nobody Thu Dec 18 18:39:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66501C77B76 for ; Sat, 15 Apr 2023 10:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230243AbjDOKsG (ORCPT ); Sat, 15 Apr 2023 06:48:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230091AbjDOKsD (ORCPT ); Sat, 15 Apr 2023 06:48:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3148AF14; Sat, 15 Apr 2023 03:47:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 97FC061376; Sat, 15 Apr 2023 10:46:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14E07C433D2; Sat, 15 Apr 2023 10:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681555618; bh=R7SwTXxq4n6vsL5nvON8lNyUl7g6u9nqIP9ZCvDXMeQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Vm4+HXJ58/UX9/57jm4JxlWyQwuSKMa6I9jcjkcvoJQ9StIJw1dF21zYloiplq+Gb q+b9IDyjPBO8JigcByB7O8kLMQK9LUs9nOKtRi8yWpgiz9wJpsFpGUNhVKmtzkIEyi 40KVCO+BcwfgBT2fRRppdMIWLkBn6g2daqrvf/KGFTD3GSEclUhn4yUlMgcu4XWHdW M0mgpiM9IE9ILsV3oFylUOIR047zMb0a/jPCnd1WVeMe+GiO0Ty138VsE9p9hfgE7K h76r1vc8OjMGa6ExoOuoa/h6Yn61PETb0hlCYynTOUOyHjD1Jj0nOAA/IGxtVg9ThM 3kul41SlS7/sQ== From: Jisheng Zhang To: Eugeniy Paltsev , Vinod Koul Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 01/11] dmaengine: dw-axi-dmac: fix reading register when runtime suspended Date: Sat, 15 Apr 2023 18:35:51 +0800 Message-Id: <20230415103601.2979-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415103601.2979-1-jszhang@kernel.org> References: <20230415103601.2979-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" We should runtime resume the device before calling axi_chan_is_hw_enable(), otherwise we may see cpu aborts when accessing registers in axi_chan_is_hw_enable(). Signed-off-by: Jisheng Zhang --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/d= w-axi-dmac/dw-axi-dmac-platform.c index 7f3a60e28e38..23a10dbdecb7 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -462,13 +462,17 @@ static void dw_axi_dma_synchronize(struct dma_chan *d= chan) =20 static int dma_chan_alloc_chan_resources(struct dma_chan *dchan) { + int ret; struct axi_dma_chan *chan =3D dchan_to_axi_dma_chan(dchan); =20 + pm_runtime_get(chan->chip->dev); + /* ASSERT: channel is idle */ if (axi_chan_is_hw_enable(chan)) { dev_err(chan2dev(chan), "%s is non-idle!\n", axi_chan_name(chan)); - return -EBUSY; + ret =3D -EBUSY; + goto err_busy; } =20 /* LLI address must be aligned to a 64-byte boundary */ @@ -478,13 +482,16 @@ static int dma_chan_alloc_chan_resources(struct dma_c= han *dchan) 64, 0); if (!chan->desc_pool) { dev_err(chan2dev(chan), "No memory for descriptors\n"); - return -ENOMEM; + ret =3D -ENOMEM; + goto err_busy; } dev_vdbg(dchan2dev(dchan), "%s: allocating\n", axi_chan_name(chan)); =20 - pm_runtime_get(chan->chip->dev); - return 0; + +err_busy: + pm_runtime_put(chan->chip->dev); + return ret; } =20 static void dma_chan_free_chan_resources(struct dma_chan *dchan) --=20 2.39.2