From nobody Thu Dec 18 18:49:15 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B98E1C77B76 for ; Fri, 14 Apr 2023 15:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231309AbjDNP1g (ORCPT ); Fri, 14 Apr 2023 11:27:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231359AbjDNP1K (ORCPT ); Fri, 14 Apr 2023 11:27:10 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01F0910255 for ; Fri, 14 Apr 2023 08:26:37 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33E7k6Wk003961; Fri, 14 Apr 2023 10:26:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=K1cH0ZtWLCX8sI+lF/y9e1IRq9QfXxo07nEhVezuoz8=; b=KwdFeteYV3LvVQ4LwHXsqQ6/9A/ryuBJIE/ur0hLpjJfMliaxImDpIFPP+O/q8MDmiqF +kap4nqKA0GMNqbNqI0GsOUYOJay8DXhjJlReMg9BZXvby46xZLTr/lZkB/9sTSilknk mctQ6JUORS8RxXF++tQu/lxSPo/mc1XCf29o+6WQnAXdxQr6WTLm94AfUELMUEIC1a7e MTpEXcqUc1CZ2hiIvYPJ8ETTvftATAi4JO7kmPpPCb2jmGfDXJeYslO8kGOuUUTeuCBc KKZGr5YSNi+GgmK7ktyxQtr1cpyLjcIQWjKBsxASPXwJ+QGwQbbXYCwU4Yy/KeOXdJO4 iQ== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3pxm3qa2sv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 10:26:01 -0500 Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 14 Apr 2023 10:25:59 -0500 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 14 Apr 2023 10:25:59 -0500 Received: from sbinding-cirrus-dsktp2.ad.cirrus.com (unknown [198.90.238.135]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 8ED9545D; Fri, 14 Apr 2023 15:25:59 +0000 (UTC) From: Stefan Binding To: Mark Brown , Jaroslav Kysela , Takashi Iwai CC: , , , Stefan Binding Subject: [PATCH v1 2/4] ALSA: hda: cs35l41: Fix endian conversions Date: Fri, 14 Apr 2023 16:25:50 +0100 Message-ID: <20230414152552.574502-3-sbinding@opensource.cirrus.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230414152552.574502-1-sbinding@opensource.cirrus.com> References: <20230414152552.574502-1-sbinding@opensource.cirrus.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 5jipqptVmrcXanMYxa1yYbmgYy1HOgdG X-Proofpoint-GUID: 5jipqptVmrcXanMYxa1yYbmgYy1HOgdG X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Found during static analysis, ensure variables are correct types before endian conversion. Signed-off-by: Stefan Binding --- sound/pci/hda/cs35l41_hda.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/pci/hda/cs35l41_hda.c b/sound/pci/hda/cs35l41_hda.c index d100189e15b83..b02462ae21f04 100644 --- a/sound/pci/hda/cs35l41_hda.c +++ b/sound/pci/hda/cs35l41_hda.c @@ -308,8 +308,8 @@ static int cs35l41_request_firmware_files(struct cs35l4= 1_hda *cs35l41, } =20 #if IS_ENABLED(CONFIG_EFI) -static int cs35l41_apply_calibration(struct cs35l41_hda *cs35l41, unsigned= int ambient, - unsigned int r0, unsigned int status, unsigned int checksum) +static int cs35l41_apply_calibration(struct cs35l41_hda *cs35l41, __be32 a= mbient, __be32 r0, + __be32 status, __be32 checksum) { int ret; =20 @@ -379,10 +379,10 @@ static int cs35l41_save_calibration(struct cs35l41_hd= a *cs35l41) =20 /* Calibration can only be applied whilst the DSP is not running */ ret =3D cs35l41_apply_calibration(cs35l41, - cpu_to_be32(cl->calAmbient), - cpu_to_be32(cl->calR), - cpu_to_be32(cl->calStatus), - cpu_to_be32(cl->calR + 1)); + (__be32)cpu_to_be32(cl->calAmbient), + (__be32)cpu_to_be32(cl->calR), + (__be32)cpu_to_be32(cl->calStatus), + (__be32)cpu_to_be32(cl->calR + 1)); } } vfree(data); @@ -745,7 +745,7 @@ static int cs35l41_runtime_resume(struct device *dev) =20 static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41) { - int halo_sts; + __be32 halo_sts; int ret; =20 ret =3D cs35l41_init_dsp(cs35l41); @@ -773,7 +773,7 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l4= 1) &halo_sts, sizeof(halo_sts)); =20 if (ret) { - dev_err(cs35l41->dev, "Timeout waiting for HALO Core to start. State: %d= \n", + dev_err(cs35l41->dev, "Timeout waiting for HALO Core to start. State: %u= \n", halo_sts); goto clean_dsp; } --=20 2.34.1