From nobody Fri Sep 20 20:22:27 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B912C77B6E for ; Fri, 14 Apr 2023 09:23:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbjDNJXX (ORCPT ); Fri, 14 Apr 2023 05:23:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229746AbjDNJXU (ORCPT ); Fri, 14 Apr 2023 05:23:20 -0400 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D9121FD0 for ; Fri, 14 Apr 2023 02:23:18 -0700 (PDT) Received: from archlinux.localdomain ([10.12.190.56]) (user=zkhuang@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33E9JuZ5016647-33E9JuZ6016647 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 14 Apr 2023 17:19:59 +0800 From: zhengkang huang To: Matthias Brugger , AngeloGioacchino Del Regno Cc: zhengkang huang , Dongliang Mu , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] soc: mdediatek: devapc: use devm_platform_ioremap_resource() instead of of_iomap() Date: Fri, 14 Apr 2023 17:21:13 +0800 Message-Id: <20230414092113.64514-1-zkhuang@hust.edu.cn> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: zkhuang@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In mtk_devapc_probe(), if of_iomap succeeds and any following error occurs, it needs to deallocate the resource. Fix this by repalcing of_iomap with devm_platform_ioremap_resource, which automatically self-manages the resource. This can avoid modifying error handling code. Signed-off-by: zhengkang huang Reviewed-by: Dongliang Mu --- drivers/soc/mediatek/mtk-devapc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-d= evapc.c index bad139cb117e..bea3ec8ab015 100644 --- a/drivers/soc/mediatek/mtk-devapc.c +++ b/drivers/soc/mediatek/mtk-devapc.c @@ -268,7 +268,7 @@ static int mtk_devapc_probe(struct platform_device *pde= v) ctx->data =3D of_device_get_match_data(&pdev->dev); ctx->dev =3D &pdev->dev; =20 - ctx->infra_base =3D of_iomap(node, 0); + ctx->infra_base =3D devm_platform_ioremap_resource(pdev, 0); if (!ctx->infra_base) return -EINVAL; =20 --=20 2.40.0