From nobody Thu Feb 12 00:24:56 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D058C7619A for ; Wed, 12 Apr 2023 14:11:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231432AbjDLOLb (ORCPT ); Wed, 12 Apr 2023 10:11:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231317AbjDLOL2 (ORCPT ); Wed, 12 Apr 2023 10:11:28 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 937322708 for ; Wed, 12 Apr 2023 07:11:08 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id jx2-20020a17090b46c200b002469a9ff94aso9852015pjb.3 for ; Wed, 12 Apr 2023 07:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1681308668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/08sgLNHl+fvsLpz2QvFxww3IWnM9URQXV0BTGByAnM=; b=ah3FfTCwtmlj6FL1p8yzw2jYC7yFw0+4YehGEEbWBum7kI6Rd8emsG3gTnRLPIDlzh ATgUdGcX4JxsAU42Ffd9/mElLT1w8zU8H/mkPAnLKxngubSiYHWJMjyc6BnmshadOED1 LZRA0eOhn+4dYVysVIEjabVJqL7TfXQi4aW/yK5TwlI6V/GsuIqGPPVchpGQD6LGlPuA XyFSWOr6h00KIKAOv2ek3wwmT02wxHTToefvZLeXFZAMqdN8GEAmtubIAZcQMmiGqZ7R IjkMW4IB3+IzCJYsfTEj/31H02aplIOF8P5doPfLi6S/Tqk3AdLW2ZOz6rI2P4JmHPkR rHIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681308668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/08sgLNHl+fvsLpz2QvFxww3IWnM9URQXV0BTGByAnM=; b=Rjfv/d8fw61xn3yJcXBqxEgRKGmvBhhagPb2ewWbcHa2oax9hJ/tN7SVGOqUuWLO8R 0uKUUZpbWTN/f0qwfxNYX75dN5mFhgcW9y9lE6V7F9JUlS3uivX3+tY0LP0c4xtGCoiC PosaMfyDjevsQR+KqXeKQO3cytMN/aITXw+O6HE9hbk6DQdZpJ4A6HOtRRv7CBSlswaV uGKoa0LaRZLPpxREYJ1vMw7AYrOp5XTc5Rga/wLa+DPiMQrom0kW7D2P3880NLTQmtaB hPwenO3/3ta8mkbnk0HXS8WLLswr3fMpXl6aJhU3Lpeod1myWeZbQZi9fcK77k+I6qtR uzHA== X-Gm-Message-State: AAQBX9cd7D8tptLrIKW/4rZ++M13AVES+swsAyN8CTvnCbgJbSOdyMIj TMWXDxNEwMvrdWkPvwfizZ1R3A== X-Google-Smtp-Source: AKy350YdZubU5x7WHR5Ra7lyb5gK5DZdvAGIACucw2eA1QSl4JVAZfxjZzWbzpgx+BaceamCCqKDzw== X-Received: by 2002:a17:90b:1d04:b0:23d:3913:bc26 with SMTP id on4-20020a17090b1d0400b0023d3913bc26mr21902907pjb.2.1681308667917; Wed, 12 Apr 2023 07:11:07 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.253]) by smtp.gmail.com with ESMTPSA id gz2-20020a17090b0ec200b00246aa8b0e8csm1503359pjb.55.2023.04.12.07.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 07:11:07 -0700 (PDT) From: Gang Li To: John Hubbard , Jonathan Corbet , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Gang Li Subject: [PATCH v6 1/2] sched/numa: use static_branch_inc/dec for sched_numa_balancing Date: Wed, 12 Apr 2023 22:10:52 +0800 Message-Id: <20230412141053.59498-1-ligang.bdlg@bytedance.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20230412140701.58337-1-ligang.bdlg@bytedance.com> References: <20230412140701.58337-1-ligang.bdlg@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" per-process numa balancing use static_branch_inc/dec() to count how many enables in sched_numa_balancing. So here must be converted to inc/dec too. Cc: linux-api@vger.kernel.org Signed-off-by: Gang Li Acked-by: John Hubbard --- kernel/sched/core.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 94be4eebfa53..99cc1d5821a1 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4501,21 +4501,15 @@ DEFINE_STATIC_KEY_FALSE(sched_numa_balancing); =20 int sysctl_numa_balancing_mode; =20 -static void __set_numabalancing_state(bool enabled) -{ - if (enabled) - static_branch_enable(&sched_numa_balancing); - else - static_branch_disable(&sched_numa_balancing); -} - void set_numabalancing_state(bool enabled) { - if (enabled) + if (enabled) { sysctl_numa_balancing_mode =3D NUMA_BALANCING_NORMAL; - else + static_branch_enable(&sched_numa_balancing); + } else { sysctl_numa_balancing_mode =3D NUMA_BALANCING_DISABLED; - __set_numabalancing_state(enabled); + static_branch_disable(&sched_numa_balancing); + } } =20 #ifdef CONFIG_PROC_SYSCTL @@ -4549,8 +4543,14 @@ static int sysctl_numa_balancing(struct ctl_table *t= able, int write, if (!(sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING) && (state & NUMA_BALANCING_MEMORY_TIERING)) reset_memory_tiering(); - sysctl_numa_balancing_mode =3D state; - __set_numabalancing_state(state); + if (sysctl_numa_balancing_mode !=3D state) { + if (state =3D=3D NUMA_BALANCING_DISABLED) + static_branch_dec(&sched_numa_balancing); + else if (sysctl_numa_balancing_mode =3D=3D NUMA_BALANCING_DISABLED) + static_branch_inc(&sched_numa_balancing); + + sysctl_numa_balancing_mode =3D state; + } } return err; } --=20 2.20.1