From nobody Fri Sep 20 20:31:47 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD05C77B73 for ; Wed, 12 Apr 2023 06:25:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229586AbjDLGZj (ORCPT ); Wed, 12 Apr 2023 02:25:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229742AbjDLGZf (ORCPT ); Wed, 12 Apr 2023 02:25:35 -0400 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D0705253; Tue, 11 Apr 2023 23:25:31 -0700 (PDT) Received: from C512-C06.localdomain ([10.12.190.72]) (user=jiefeng_li@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 33C6MidG003133-33C6MidH003133 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 12 Apr 2023 14:22:48 +0800 From: Jiefeng Li To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno Cc: Jiefeng Li , Dongliang Mu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] wifi: mt76: mt7921: fix missing unwind goto in `mt7921u_probe` Date: Wed, 12 Apr 2023 14:22:34 +0800 Message-Id: <20230412062234.4810-1-jiefeng_li@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: jiefeng_li@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" `mt7921u_dma_init` can only return zero or negative number according to its definition. When it returns non-zero number, there exists an error and this function should handle this error rather than return directly. Fixes: 0d2afe09fad5 ("mt76: mt7921: add mt7921u driver") Signed-off-by: Jiefeng Li Reviewed-by: Dongliang Mu Reviewed-by: Sridhar Samudrala --- The issue is discovered by static analysis, and the patch is not tested yet. --- drivers/net/wireless/mediatek/mt76/mt7921/usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c b/drivers/net/= wireless/mediatek/mt76/mt7921/usb.c index 8fef09ed29c9..70c9bbdbf60e 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c @@ -272,7 +272,7 @@ static int mt7921u_probe(struct usb_interface *usb_intf, =20 ret =3D mt7921u_dma_init(dev, false); if (ret) - return ret; + goto error; =20 hw =3D mt76_hw(dev); /* check hw sg support in order to enable AMSDU */ --=20 2.34.1