From nobody Wed Feb 11 19:42:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 358D8C76196 for ; Mon, 10 Apr 2023 22:39:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229780AbjDJWjM (ORCPT ); Mon, 10 Apr 2023 18:39:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229523AbjDJWjI (ORCPT ); Mon, 10 Apr 2023 18:39:08 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B14C1BDB for ; Mon, 10 Apr 2023 15:39:07 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id v6so5687860wrv.8 for ; Mon, 10 Apr 2023 15:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681166346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dNwzE4KtIR7VA8WEdFR1Y325MnwjNn/HP5LmgOvBXjw=; b=F+gsdJ8fCjBl/In9VkEjngqOT7Yuy4rIlgNTgygFtjvwflyMXmqET1mjhlBYH4h/hK UapCpXSmCP5mAkgUJkJ9xtllBixS1M7NeDhQJzNyzoakQgm7T49tE4pNAEm1YTrWbn8f i0L9R2NTth5sj0N2S1NoFjUb4Z+83LqH5dScPFvzIIZIAZ+zcbO/S2lhE1DNKnh3e/rt G4WcjnxgSToUUhOPlLr1ZtKawVIYKB1ltq9/PZyILVBqdYT+bQr+5IjeCwCazzV9C+Rn HRkjTJ9HhANlIzvKd3TacCbtXRJAs59ZcBBTdJnMu/joEG4yIQZ5+6rigL2hvk2P84Lz pBWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681166346; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dNwzE4KtIR7VA8WEdFR1Y325MnwjNn/HP5LmgOvBXjw=; b=yLXtieJtkaztUXlZG/NE2pRRgWis8r9tG9gvJRbiAbrZgM6gIXaV9caU0KhpIsjKvx F3f0YaXoEpbK1xt7Tp8ubBPZfJl/HJ5lh3l+X0Mcm4YkGL3nV1buuC0W7D+V6JBD69cC TcFN7bJiIj/ZaJBKAjLmlQaGCncmU44Z0xV9IKBE87DWMrCiSpWPDQLdksLVz8j5rF+t 4ZyyVWvM0eU8RbKJ10jh3XyWUQHfTdtfkxHSw4OzNSV/PUPNsoK6cdZaex/XMT4fCrTt Bo8FpE6EO0VRTAY5np1tc40BLEF1p5ekgq2ewVZtkj5rdziMYVejOMZEPtzAqbOaXO8o +SHg== X-Gm-Message-State: AAQBX9dGUfmfkyputgbWGZtux9JnQbQZgYUT1RwFALzi5slGgafgXtIP 6lI3Lpk8I1TK2l1U6heTbmU= X-Google-Smtp-Source: AKy350Y/Jw0fJS5n1ttIDBcdNXFNA0aKae15RlsyioYA7N5Vk0r0ouA/4vMJ+EkD1ObVbRm/7DG4ew== X-Received: by 2002:adf:f3cf:0:b0:2d5:2c7b:bc5f with SMTP id g15-20020adff3cf000000b002d52c7bbc5fmr8960195wrp.58.1681166345763; Mon, 10 Apr 2023 15:39:05 -0700 (PDT) Received: from localhost ([2a02:1210:8629:800:82ee:73ff:feb8:99e3]) by smtp.gmail.com with UTF8SMTPSA id m8-20020adffe48000000b002c55521903bsm12862966wrs.51.2023.04.10.15.39.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Apr 2023 15:39:05 -0700 (PDT) From: Alexander Sverdlin To: alsa-devel@alsa-project.org Cc: Alexander Sverdlin , Nikita Shubin , David Rhodes , James Schulman , Jaroslav Kysela , Liam Girdwood , linux-kernel@vger.kernel.org, Lucas Tanure , Mark Brown , patches@opensource.cirrus.com, Richard Fitzgerald , Takashi Iwai Subject: [PATCH 1/3] ASoC: ep93xx: i2s: move enable call to startup callback Date: Tue, 11 Apr 2023 00:39:00 +0200 Message-Id: <20230410223902.2321834-2-alexander.sverdlin@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230410223902.2321834-1-alexander.sverdlin@gmail.com> References: <20230410223902.2321834-1-alexander.sverdlin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Make startup/shutdown callbacks symmetric to avoid clock subsystem warnings (reproduced with "aplay --dump-hw-params" + ctrl-c): WARNING: CPU: 0 PID: 102 at drivers/clk/clk.c:1048 clk_core_disable lrclk already disabled CPU: 0 PID: 102 Comm: aplay Not tainted 6.2.0-rc4 #1 Hardware name: Generic DT based system ... clk_core_disable from clk_core_disable_lock clk_core_disable_lock from ep93xx_i2s_shutdown ep93xx_i2s_shutdown from snd_soc_dai_shutdown snd_soc_dai_shutdown from soc_pcm_clean soc_pcm_clean from soc_pcm_close soc_pcm_close from snd_pcm_release_substream.part.0 snd_pcm_release_substream.part.0 from snd_pcm_release snd_pcm_release from __fput __fput from task_work_run ... WARNING: CPU: 0 PID: 102 at drivers/clk/clk.c:907 clk_core_unprepare lrclk already unprepared CPU: 0 PID: 102 Comm: aplay Tainted: G W 6.2.0-rc4 #1 Hardware name: Generic DT based system ... clk_core_unprepare from clk_unprepare clk_unprepare from ep93xx_i2s_shutdown ep93xx_i2s_shutdown from snd_soc_dai_shutdown snd_soc_dai_shutdown from soc_pcm_clean soc_pcm_clean from soc_pcm_close soc_pcm_close from snd_pcm_release_substream.part.0 snd_pcm_release_substream.part.0 from snd_pcm_release snd_pcm_release from __fput __fput from task_work_run ... Signed-off-by: Alexander Sverdlin --- sound/soc/cirrus/ep93xx-i2s.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/sound/soc/cirrus/ep93xx-i2s.c b/sound/soc/cirrus/ep93xx-i2s.c index 200d18060f7c..bbbb1065b2f1 100644 --- a/sound/soc/cirrus/ep93xx-i2s.c +++ b/sound/soc/cirrus/ep93xx-i2s.c @@ -209,6 +209,16 @@ static int ep93xx_i2s_dai_probe(struct snd_soc_dai *da= i) return 0; } =20 +static int ep93xx_i2s_startup(struct snd_pcm_substream *substream, + struct snd_soc_dai *dai) +{ + struct ep93xx_i2s_info *info =3D snd_soc_dai_get_drvdata(dai); + + ep93xx_i2s_enable(info, substream->stream); + + return 0; +} + static void ep93xx_i2s_shutdown(struct snd_pcm_substream *substream, struct snd_soc_dai *dai) { @@ -349,7 +359,6 @@ static int ep93xx_i2s_hw_params(struct snd_pcm_substrea= m *substream, if (err) return err; =20 - ep93xx_i2s_enable(info, substream->stream); return 0; } =20 @@ -398,6 +407,7 @@ static int ep93xx_i2s_resume(struct snd_soc_component *= component) #endif =20 static const struct snd_soc_dai_ops ep93xx_i2s_dai_ops =3D { + .startup =3D ep93xx_i2s_startup, .shutdown =3D ep93xx_i2s_shutdown, .hw_params =3D ep93xx_i2s_hw_params, .set_sysclk =3D ep93xx_i2s_set_sysclk, --=20 2.40.0