From nobody Fri Sep 20 20:35:50 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3069CC76196 for ; Fri, 7 Apr 2023 08:38:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239167AbjDGIiL (ORCPT ); Fri, 7 Apr 2023 04:38:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233146AbjDGIiI (ORCPT ); Fri, 7 Apr 2023 04:38:08 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7A25746BF; Fri, 7 Apr 2023 01:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=bvMeT VYjDyKEP8ZQMTHGrWbs6rZELtxOvEXtr+caOtg=; b=Y48temyT0/21qJteKk2rk s1ByLfixQXhq8XSvWsoiN7b3/nmJdRfFjA2EczXHyZ68Iz1ihOin55DaQWJC+WG4 BoMA96tUeD1WHi60zS8ZuBgtBqDLVKw+dpgTJVyy5fbfCDWZzL4r3Hj2+ooM7akC fSEjcmv8P/KyzKvgV24lq0= Received: from ubuntu.localdomain (unknown [115.156.140.143]) by zwqz-smtp-mta-g1-4 (Coremail) with SMTP id _____wCnrdpS1i9kggMuAw--.20049S4; Fri, 07 Apr 2023 16:37:39 +0800 (CST) From: Xinyi Hou To: Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno Cc: Xinyi Hou , Dongliang Mu , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH] clk: mediatek: clk-mt7986-infracfg: delete the code related to 'base' Date: Fri, 7 Apr 2023 16:37:28 +0800 Message-Id: <20230407083729.31498-1-Y_Ashley@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCnrdpS1i9kggMuAw--.20049S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrZF47Wry3uw48Zw48Xr4xWFg_yoWkWFX_Zr s5ur97Zr17KF4kGr47Wwn2vF9rtFs3Zr97Z3WYywn8JFyxKa1rJr1vqa95Aw47Ww4Svry5 Jrn7Kry7CF4rZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRLF4EPUUUUU== X-Originating-IP: [115.156.140.143] X-CM-SenderInfo: p1bd2xxoh1qiywtou0bp/1tbiShRKxGI0XrQwOgAAsm Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In clk_mt7986_infracfg_probe(), 'base' is allocated but never used, either not released on both success failure path. Fix this by deleting 'base' and the code related to it. Signed-off-by: Xinyi Hou Reviewed-by: Dongliang Mu Reviewed-by: Alexandre Mergnat --- drivers/clk/mediatek/clk-mt7986-infracfg.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt7986-infracfg.c b/drivers/clk/media= tek/clk-mt7986-infracfg.c index e80c92167c8f..76b32f3a16b2 100644 --- a/drivers/clk/mediatek/clk-mt7986-infracfg.c +++ b/drivers/clk/mediatek/clk-mt7986-infracfg.c @@ -174,16 +174,9 @@ static int clk_mt7986_infracfg_probe(struct platform_d= evice *pdev) struct clk_hw_onecell_data *clk_data; struct device_node *node =3D pdev->dev.of_node; int r; - void __iomem *base; int nr =3D ARRAY_SIZE(infra_divs) + ARRAY_SIZE(infra_muxes) + ARRAY_SIZE(infra_clks); =20 - base =3D of_iomap(node, 0); - if (!base) { - pr_err("%s(): ioremap failed\n", __func__); - return -ENOMEM; - } - clk_data =3D mtk_alloc_clk_data(nr); =20 if (!clk_data) --=20 2.25.1