From nobody Wed Feb 11 04:00:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B9D9C77B6E for ; Tue, 4 Apr 2023 17:38:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235346AbjDDRi2 (ORCPT ); Tue, 4 Apr 2023 13:38:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235833AbjDDRiY (ORCPT ); Tue, 4 Apr 2023 13:38:24 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75FA34C2C; Tue, 4 Apr 2023 10:38:15 -0700 (PDT) Received: from localhost (unknown [188.27.34.213]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id CE2826603182; Tue, 4 Apr 2023 18:38:13 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680629894; bh=KlijjLio97ihQkNKbDD0GN+ulVNt3WEfM5CnliYI74Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BVOB663gd/3mWfkxeUPSy0gPJN5Th6yxPq+eOYx1JKWzP9jGf5BdrataBkOfnmtUy eMnhIZWUYep9Et9AGLsYBHnuVvTSt+tnVsfr1fJ6V04NWjQYd0Dn/FEat1g9ZRHhjY 1l6xsMqYHBrSx8Q63UmcuxDAS5MWwDtHc2bgTe7LfTs4XBJoPTKR+cEDaJu+U/JQI3 iPKPmqusdWF2qq235soKndZn1f9RWt6f2rGwusI8MootKSREVtq38re/3gPWJpHWTo 6VY0++NYCCPsbTAhgUBhfB5I/EBxpLex4EjNquNlLwwmWdCCIkBkmJFlQtN6W6sEYY TxqsR1KjqUOJg== From: Cristian Ciocaltea To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com Subject: [PATCH v2 1/2] dt-bindings: hwmon: pwm-fan: Convert to DT schema Date: Tue, 4 Apr 2023 20:38:06 +0300 Message-Id: <20230404173807.490520-2-cristian.ciocaltea@collabora.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230404173807.490520-1-cristian.ciocaltea@collabora.com> References: <20230404173807.490520-1-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Convert the PWM fan bindings to DT schema format. Signed-off-by: Cristian Ciocaltea --- .../devicetree/bindings/hwmon/pwm-fan.txt | 68 +--------- .../devicetree/bindings/hwmon/pwm-fan.yaml | 119 ++++++++++++++++++ 2 files changed, 120 insertions(+), 67 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/pwm-fan.yaml diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Document= ation/devicetree/bindings/hwmon/pwm-fan.txt index 4509e688623a..48886f0ce415 100644 --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt @@ -1,67 +1 @@ -Bindings for a fan connected to the PWM lines - -Required properties: -- compatible : "pwm-fan" -- pwms : the PWM that is used to control the PWM fan -- cooling-levels : PWM duty cycle values in a range from 0 to 255 - which correspond to thermal cooling states - -Optional properties: -- fan-supply : phandle to the regulator that provides power to the fan -- interrupts : This contains an interrupt specifier for each fan - tachometer output connected to an interrupt source. - The output signal must generate a defined number of - interrupts per fan revolution, which require that - it must be self resetting edge interrupts. See - interrupt-controller/interrupts.txt for the format. -- pulses-per-revolution : define the number of pulses per fan revolution f= or - each tachometer input as an integer (default is 2 - interrupts per revolution). The value must be - greater than zero. - -Example: - fan0: pwm-fan { - compatible =3D "pwm-fan"; - #cooling-cells =3D <2>; - pwms =3D <&pwm 0 10000 0>; - cooling-levels =3D <0 102 170 230>; - }; - - thermal-zones { - cpu_thermal: cpu-thermal { - thermal-sensors =3D <&tmu 0>; - polling-delay-passive =3D <0>; - polling-delay =3D <0>; - trips { - cpu_alert1: cpu-alert1 { - temperature =3D <100000>; /* millicelsius */ - hysteresis =3D <2000>; /* millicelsius */ - type =3D "passive"; - }; - }; - cooling-maps { - map0 { - trip =3D <&cpu_alert1>; - cooling-device =3D <&fan0 0 1>; - }; - }; - }; - -Example 2: - fan0: pwm-fan { - compatible =3D "pwm-fan"; - pwms =3D <&pwm 0 40000 0>; - fan-supply =3D <®_fan>; - interrupt-parent =3D <&gpio5>; - interrupts =3D <1 IRQ_TYPE_EDGE_FALLING>; - pulses-per-revolution =3D <2>; - }; - -Example 3: - fan0: pwm-fan { - compatible =3D "pwm-fan"; - pwms =3D <&pwm1 0 25000 0>; - interrupts-extended =3D <&gpio1 1 IRQ_TYPE_EDGE_FALLING>, - <&gpio2 5 IRQ_TYPE_EDGE_FALLING>; - pulses-per-revolution =3D <2>, <1>; - }; +This file has moved to pwm-fan.yaml. diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml b/Documen= tation/devicetree/bindings/hwmon/pwm-fan.yaml new file mode 100644 index 000000000000..048b6ea794c7 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml @@ -0,0 +1,119 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/hwmon/pwm-fan.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Fan connected to PWM lines + +maintainers: + - Jean Delvare + - Guenter Roeck + +properties: + compatible: + const: pwm-fan + + cooling-levels: + description: PWM duty cycle values corresponding to thermal cooling st= ates. + items: + maximum: 255 + $ref: /schemas/types.yaml#/definitions/uint32-array + + fan-supply: + description: Phandle to the regulator that provides power to the fan. + + interrupts: + description: + This contains an interrupt specifier for each fan tachometer output + connected to an interrupt source. The output signal must generate a + defined number of interrupts per fan revolution, which require that + it must be self resetting edge interrupts. + minItems: 1 + maxItems: 5 + + pulses-per-revolution: + description: + Define the number of pulses per fan revolution for each tachometer + input as an integer. + items: + minimum: 1 + maximum: 4 + default: 2 + minItems: 1 + maxItems: 5 + $ref: /schemas/types.yaml#/definitions/uint32-array + + pwms: + description: The PWM that is used to control the fan. + maxItems: 1 + + pwm-names: true + + "#cooling-cells": + description: + Must be 2, in order to specify minimum and maximum cooling state use= d in + the cooling-maps reference. The first cell is the minimum cooling st= ate + and the second cell is the maximum cooling state requested. + const: 2 + +required: + - compatible + - pwms + +additionalProperties: false + +examples: + - | + pwm-fan { + compatible =3D "pwm-fan"; + cooling-levels =3D <0 102 170 230>; + pwms =3D <&pwm 0 10000 0>; + #cooling-cells =3D <2>; + }; + + thermal-zones { + cpu_thermal: cpu-thermal { + thermal-sensors =3D <&tmu 0>; + polling-delay-passive =3D <0>; + polling-delay =3D <0>; + + trips { + cpu_alert1: cpu-alert1 { + temperature =3D <100000>; /* millicelsius */ + hysteresis =3D <2000>; /* millicelsius */ + type =3D "passive"; + }; + }; + + cooling-maps { + map0 { + trip =3D <&cpu_alert1>; + cooling-device =3D <&fan0 0 1>; + }; + }; + }; + }; + + - | + #include + + pwm-fan { + compatible =3D "pwm-fan"; + pwms =3D <&pwm 0 40000 0>; + fan-supply =3D <®_fan>; + interrupt-parent =3D <&gpio5>; + interrupts =3D <1 IRQ_TYPE_EDGE_FALLING>; + pulses-per-revolution =3D <2>; + }; + + - | + #include + + pwm-fan { + compatible =3D "pwm-fan"; + pwms =3D <&pwm1 0 25000 0>; + interrupts-extended =3D <&gpio1 1 IRQ_TYPE_EDGE_FALLING>, + <&gpio2 5 IRQ_TYPE_EDGE_FALLING>; + pulses-per-revolution =3D <2>, <1>; + }; --=20 2.40.0 From nobody Wed Feb 11 04:00:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72466C77B62 for ; Tue, 4 Apr 2023 17:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236020AbjDDRik (ORCPT ); Tue, 4 Apr 2023 13:38:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235968AbjDDRie (ORCPT ); Tue, 4 Apr 2023 13:38:34 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87288170F; Tue, 4 Apr 2023 10:38:18 -0700 (PDT) Received: from localhost (unknown [188.27.34.213]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id A41E066031A5; Tue, 4 Apr 2023 18:38:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1680629896; bh=cdstoqxPWhvdMsWzWtAKva88nlEDFRiEFVi8qwXMjAU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nYFqgjzbtVADmMDipQDLIWdBpljOVNzX7Fk98T1+e8lpapf8vF8wgOiigtzGypbV+ SlM2wdOdpVb8aMPc9oZJns3JnBAHe3ZCSSnawHxALbmqOq3mkzadja0aPv0mknHq++ YXSie0py3d+cawXuTN1FONSHJ9/ltew/qNAkIyOSl5mReTuM7h1dawamDx2l01Ssj9 wD8UPnjraiSuud/1diImJTIamTnnViCHsCriBoFxWZrJ/JdOv9hJYXUPpTZ2jRIDB9 /ppbe6PYMYJXe7uY0WEiSgFzVBQf7+ze5vEHDnUFzvqbOf8bMH1UZqlE2jfs5bHWM0 i7HLrgnj27xyA== From: Cristian Ciocaltea To: Jean Delvare , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com, Christopher Obbard Subject: [PATCH v2 2/2] arm64: dts: rockchip: rk3588-rock-5b: Add pwm-fan Date: Tue, 4 Apr 2023 20:38:07 +0300 Message-Id: <20230404173807.490520-3-cristian.ciocaltea@collabora.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230404173807.490520-1-cristian.ciocaltea@collabora.com> References: <20230404173807.490520-1-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add the necessary DT changes for the Rock 5B board to enable support for the PWM controlled heat sink fan. Signed-off-by: Cristian Ciocaltea Reviewed-by: Christopher Obbard --- arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/b= oot/dts/rockchip/rk3588-rock-5b.dts index 95805cb0adfa..bd74d9da2c17 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts @@ -17,6 +17,14 @@ chosen { stdout-path =3D "serial2:1500000n8"; }; =20 + fan: pwm-fan { + compatible =3D "pwm-fan"; + cooling-levels =3D <0 95 145 195 255>; + fan-supply =3D <&vcc5v0_sys>; + pwms =3D <&pwm1 0 50000 0>; + #cooling-cells =3D <2>; + }; + vcc5v0_sys: vcc5v0-sys-regulator { compatible =3D "regulator-fixed"; regulator-name =3D "vcc5v0_sys"; @@ -27,6 +35,10 @@ vcc5v0_sys: vcc5v0-sys-regulator { }; }; =20 +&pwm1 { + status =3D "okay"; +}; + &sdhci { bus-width =3D <8>; no-sdio; --=20 2.40.0