From nobody Mon Feb 9 22:18:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5EBCC77B60 for ; Fri, 31 Mar 2023 07:46:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231265AbjCaHqx (ORCPT ); Fri, 31 Mar 2023 03:46:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbjCaHqW (ORCPT ); Fri, 31 Mar 2023 03:46:22 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9ECAD1A97C for ; Fri, 31 Mar 2023 00:46:19 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id a44so3487208ljr.10 for ; Fri, 31 Mar 2023 00:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680248779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Gpe4Snyz/bF2fGxRf14cYZlO6UgYfzmd/ba/DWV9Gk=; b=vPj7iUbeg6atcpAE6Rmc2T3cT1CuQ6hI5sL6TzGToU3udLUOVtkSFe4aAbQEDkauGg UOTaUcX/VA/YEwdi/Uv/0tHEEsz3my21x0o09Y5+MMxSeV3Y/+0nCm1n/za4OHVbejob il5LLGPceI3Dy2br6XN05H6fddm/OfImZXd4W4xidDzWOB6pt1sifY9JJ4uzltVdf7FO J+tUbVDGJkqyn4QRoMRN5GtuzXwaupf1wDIVjF+aIUdMXZHm5vOU8zpcRhXktOAREfan ctpopLklTeOkeiyciCJnb8Oydzxd2Okqvf75PKv8FGJe23RYfOBg6Vte/c5nRfrAkxfu xpDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680248779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1Gpe4Snyz/bF2fGxRf14cYZlO6UgYfzmd/ba/DWV9Gk=; b=W0RVcGcvLRuyp4pNQp2q4m2c6mKxyhTYdBZgxE9/IoinU5cuhFib9i5dtvGi1bLCy6 Kl0lYjaND9ZN7TKwDkGzvEPioUBly+W7OgfzmNAC3WdYadoTuzjnhx6126LCwH+AJLYn BuNsXswIsRu3PYrrZIXBhvuMvtOEdLgi70Mtcx2JvhZmJsWb8XptdW0ALmcUYijjqEkh YFu7Sm4f7fShALoaDwg6lhtkQSb4gU+0s//sJ6AsfWbyZDazFifw1LXMaYHrRY+q0AAd ik2iyPRTag7FZR3Uc8fq2D9HFngqu+Cd/PEFMC90IgvMUBtinVsV21x6oRyvD5M84LWr bMtw== X-Gm-Message-State: AAQBX9froOrLExfWGzPqVSvLlOvkiQQ/SmQsEZZU5PnG3WJRS0itb6sO vAOqobl1HChOtMB1xp+YivhMzQ== X-Google-Smtp-Source: AKy350bSzjL91WtFWl1PE43B7dIJUbkMTgBFFknQ0K7k/cM/h+/38F1qZmY/xMT76WPQrlNjZa1lJw== X-Received: by 2002:a2e:984e:0:b0:293:4b60:419c with SMTP id e14-20020a2e984e000000b002934b60419cmr2359613ljj.18.1680248779228; Fri, 31 Mar 2023 00:46:19 -0700 (PDT) Received: from ta1.c.googlers.com.com (61.215.228.35.bc.googleusercontent.com. [35.228.215.61]) by smtp.gmail.com with ESMTPSA id n20-20020a2e8794000000b0029573844d03sm241201lji.109.2023.03.31.00.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 00:46:18 -0700 (PDT) From: Tudor Ambarus To: michael@walle.cc, pratyush@kernel.org Cc: miquel.raynal@bootlin.com, richard@nod.at, Takahiro.Kuwano@infineon.com, bacem.daassi@infineon.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Tudor Ambarus , stable@vger.kernel.org Subject: [PATCH v5 08/10] mtd: spi-nor: core: Update flash's current address mode when changing address mode Date: Fri, 31 Mar 2023 07:46:04 +0000 Message-Id: <20230331074606.3559258-9-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.40.0.348.gf938b09366-goog In-Reply-To: <20230331074606.3559258-1-tudor.ambarus@linaro.org> References: <20230331074606.3559258-1-tudor.ambarus@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The bug was obswerved while reading code. There are not many users of addr_mode_nbytes. Anyway, we should update the flash's current address mode when changing the address mode, fix it. We don't care for now about the set_4byte_addr_mode(nor, false) from spi_nor_restore(), as it is used at driver remove and shutdown. Fixes: d7931a215063 ("mtd: spi-nor: core: Track flash's internal address mo= de") Signed-off-by: Tudor Ambarus Cc: stable@vger.kernel.org --- drivers/mtd/spi-nor/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c index 0517a61975e4..4f0d90d3dad5 100644 --- a/drivers/mtd/spi-nor/core.c +++ b/drivers/mtd/spi-nor/core.c @@ -3135,6 +3135,7 @@ static int spi_nor_quad_enable(struct spi_nor *nor) =20 static int spi_nor_init(struct spi_nor *nor) { + struct spi_nor_flash_parameter *params =3D nor->params; int err; =20 err =3D spi_nor_octal_dtr_enable(nor, true); @@ -3176,9 +3177,10 @@ static int spi_nor_init(struct spi_nor *nor) */ WARN_ONCE(nor->flags & SNOR_F_BROKEN_RESET, "enabling reset hack; may not recover from unexpected reboots\n"); - err =3D nor->params->set_4byte_addr_mode(nor, true); + err =3D params->set_4byte_addr_mode(nor, true); if (err && err !=3D -ENOTSUPP) return err; + params->addr_mode_nbytes =3D 4; } =20 return 0; --=20 2.40.0.348.gf938b09366-goog