From nobody Fri Apr 17 11:54:47 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA46CC74A5B for ; Wed, 29 Mar 2023 08:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230434AbjC2IVv (ORCPT ); Wed, 29 Mar 2023 04:21:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230454AbjC2IVb (ORCPT ); Wed, 29 Mar 2023 04:21:31 -0400 Received: from smtpbgau2.qq.com (smtpbgau2.qq.com [54.206.34.216]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78EB749C1; Wed, 29 Mar 2023 01:20:28 -0700 (PDT) X-QQ-mid: bizesmtp76t1680077956tsbj2yfo Received: from localhost.localdomain ( [1.202.39.170]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 29 Mar 2023 16:19:04 +0800 (CST) X-QQ-SSF: 01400000000000C0H000000A0000000 X-QQ-FEAT: I8hG9CuxGDKnF0zrM7FlPwImURR4VFgXj2Ah99m1dTebzaBSKMvDh3gWmjmwt YHGZDYcXolBTAwjmPaGVVFtZE5ycy/uHyO37aTmsa7kltZVKznjYptQFBAsNzq1NDq44CQu a1ZIQC0JSKAYYyTU1Ttw/czBir82blaFk2WTeFrbFIukP38V8hGVoQAj6nJ+XzALFT21sis unZyqHcelYzm7YraOpFPTkASYJrVknIrlRjrnmcU7LtsdOljd9rmtYgMA2WP9IWaEm9h2Vb Yakz2D/SpuX9rvXiEZulLNkuqjmUWvvmlbdljWo/877hHdjdE9wHRV3/Dn+fzd0ouS2V806 4DXyDn4LsphxnuviAb7RGEoWtCEcrrmAoMkt154Rq9TAvPe+s6WM/mX854z0s8hAWNwH+xa X-QQ-GoodBg: 1 X-BIZMAIL-ID: 9811005486938683475 From: Ke Guo To: seanjc@google.com, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, guoke@uniontech.com Subject: [PATCH] KVM: SVM: use kvm_pat_valid instead of kvm_mtrr_valid Date: Wed, 29 Mar 2023 16:18:59 +0800 Message-Id: <20230329081859.2571698-1-guoke@uniontech.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvr:qybglogicsvr4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Using kvm_pat_valid instead of kvm_mtrr_valid here is more appropriate. It does the same thing as calling kvm_mtrr_valid here without two useless check. MSR_IA32_CR_PAT is only related to PAT register but not the other MTRR related registers. Signed-off-by: Ke Guo --- arch/x86/kvm/svm/svm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 252e7f37e4e2..834bf9e6c158 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -2906,7 +2906,7 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, struct = msr_data *msr) =20 break; case MSR_IA32_CR_PAT: - if (!kvm_mtrr_valid(vcpu, MSR_IA32_CR_PAT, data)) + if (!kvm_pat_valid(data)) return 1; vcpu->arch.pat =3D data; svm->vmcb01.ptr->save.g_pat =3D data; --=20 2.25.1