From nobody Sun May 5 12:12:48 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE13C7EE24 for ; Fri, 2 Jun 2023 15:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236083AbjFBPVB (ORCPT ); Fri, 2 Jun 2023 11:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236554AbjFBPUy (ORCPT ); Fri, 2 Jun 2023 11:20:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 090B318C; Fri, 2 Jun 2023 08:20:53 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 96FF861913; Fri, 2 Jun 2023 15:20:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC5BBC433EF; Fri, 2 Jun 2023 15:20:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685719252; bh=8XaJXcozLlYKjV2jpZ+W8q+KArXiOK3wSFoJ+w0AxzE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=FGJ9XMyMb1Zxkfy55ebN+xqmcuowDl8VVdS1S8oivtIoGaOkIyf6ldVrnUtL/P0bM UMao67EfGbhlbYdERRnQy2bbylDUE0co3Yz7bVCRU433qFqr7P71bumyXAPTnSjCe+ dCuiE5XcAH+TNcmtjbqMWZ1nzx1dL6cFGinLrG+mJvStpYV5L+Lgy6/52O/XjfOOqj FuWRMaFD2PzL554taxCRqC/g3dRXFKprSuXGwX0neuJ4ATO4dg8SYQiXFcMGOz9fc3 p6PAF2aqJ2i8c1DdZGhx3eiUxfOiAyzqk4bkvnLDMnk0kJ/oNeWuqtPLbangZvh4CT Kr1NsBUcasSig== From: Maxime Ripard Date: Fri, 02 Jun 2023 17:20:43 +0200 Subject: [PATCH RESEND 1/2] drivers: base: Add basic devm tests for root devices MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230329-kunit-devm-inconsistencies-test-v1-1-015b1574d673@kernel.org> References: <20230329-kunit-devm-inconsistencies-test-v1-0-015b1574d673@kernel.org> In-Reply-To: <20230329-kunit-devm-inconsistencies-test-v1-0-015b1574d673@kernel.org> To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Brendan Higgins , David Gow , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.13-dev-02a79 X-Developer-Signature: v=1; a=openpgp-sha256; l=5347; i=mripard@kernel.org; h=from:subject:message-id; bh=ivcxwQWQcXWS/fXksYR14wmFIo787eFmeMtomO6iXEU=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDClVHOdsomK/3jLNc/mWpGLYnf920/5Pf5NKbggFW801Tsjb v+x1RykLgxgXg6yYIkuMsPmSuFOzXney8c2DmcPKBDKEgYtTACbCv5Phn37TqbjPJ0/mbOkO2vlG5G m9UVWVXu332ZIajjvVcvPvrWBkuDB7q+mqkj/rTgv8mvDFpdHt7uKZNnwylY8PzJn3/niYGQMA X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxime Ripard The root devices show some odd behaviours compared to regular "bus" devices that have been probed through the usual mechanism, so let's create kunit tests to exercise those paths and odd cases. Signed-off-by: Maxime Ripard --- drivers/base/test/.kunitconfig | 2 + drivers/base/test/Kconfig | 4 ++ drivers/base/test/Makefile | 2 + drivers/base/test/root-device-test.c | 120 +++++++++++++++++++++++++++++++= ++++ 4 files changed, 128 insertions(+) diff --git a/drivers/base/test/.kunitconfig b/drivers/base/test/.kunitconfig new file mode 100644 index 000000000000..473923f0998b --- /dev/null +++ b/drivers/base/test/.kunitconfig @@ -0,0 +1,2 @@ +CONFIG_KUNIT=3Dy +CONFIG_DM_KUNIT_TEST=3Dy diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig index 610a1ba7a467..9d42051f8f8e 100644 --- a/drivers/base/test/Kconfig +++ b/drivers/base/test/Kconfig @@ -9,6 +9,10 @@ config TEST_ASYNC_DRIVER_PROBE =20 If unsure say N. =20 +config DM_KUNIT_TEST + tristate "KUnit Tests for the device model" if !KUNIT_ALL_TESTS + depends on KUNIT + config DRIVER_PE_KUNIT_TEST bool "KUnit Tests for property entry API" if !KUNIT_ALL_TESTS depends on KUNIT=3Dy diff --git a/drivers/base/test/Makefile b/drivers/base/test/Makefile index 7f76fee6f989..d589ca3fa8fc 100644 --- a/drivers/base/test/Makefile +++ b/drivers/base/test/Makefile @@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE) +=3D test_async_driver_probe.o =20 +obj-$(CONFIG_DM_KUNIT_TEST) +=3D root-device-test.o + obj-$(CONFIG_DRIVER_PE_KUNIT_TEST) +=3D property-entry-test.o CFLAGS_property-entry-test.o +=3D $(DISABLE_STRUCTLEAK_PLUGIN) diff --git a/drivers/base/test/root-device-test.c b/drivers/base/test/root-= device-test.c new file mode 100644 index 000000000000..fcb55d8882aa --- /dev/null +++ b/drivers/base/test/root-device-test.c @@ -0,0 +1,120 @@ +// SPDX-License-Identifier: GPL-2.0 +// Copyright 2023 Maxime Ripard + +#include + +#include + +#define DEVICE_NAME "test" + +struct test_priv { + bool probe_done; + bool release_done; + wait_queue_head_t release_wq; + struct device *dev; +}; + +static void devm_device_action(void *ptr) +{ + struct test_priv *priv =3D ptr; + + priv->release_done =3D true; + wake_up_interruptible(&priv->release_wq); +} + +static void devm_put_device_action(void *ptr) +{ + struct test_priv *priv =3D ptr; + + put_device(priv->dev); + priv->release_done =3D true; + wake_up_interruptible(&priv->release_wq); +} + +#define RELEASE_TIMEOUT_MS 500 + +static void root_device_devm_register_unregister_test(struct kunit *test) +{ + struct test_priv *priv; + int ret; + + priv =3D kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); + init_waitqueue_head(&priv->release_wq); + + priv->dev =3D root_device_register(DEVICE_NAME); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev); + + ret =3D devm_add_action_or_reset(priv->dev, devm_device_action, priv); + KUNIT_ASSERT_EQ(test, ret, 0); + + root_device_unregister(priv->dev); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->release_= done, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_EXPECT_GT(test, ret, 0); +} + +static void root_device_devm_register_get_put_unregister_test(struct kunit= *test) +{ + struct test_priv *priv; + int ret; + + priv =3D kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); + init_waitqueue_head(&priv->release_wq); + + priv->dev =3D root_device_register(DEVICE_NAME); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev); + + get_device(priv->dev); + + ret =3D devm_add_action_or_reset(priv->dev, devm_device_action, priv); + KUNIT_ASSERT_EQ(test, ret, 0); + + put_device(priv->dev); + + root_device_unregister(priv->dev); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->release_= done, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_EXPECT_GT(test, ret, 0); +} + +static void root_device_devm_register_get_unregister_with_devm_test(struct= kunit *test) +{ + struct test_priv *priv; + int ret; + + priv =3D kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); + init_waitqueue_head(&priv->release_wq); + + priv->dev =3D root_device_register(DEVICE_NAME); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv->dev); + + get_device(priv->dev); + + ret =3D devm_add_action_or_reset(priv->dev, devm_put_device_action, priv); + KUNIT_ASSERT_EQ(test, ret, 0); + + root_device_unregister(priv->dev); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->release_= done, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_EXPECT_GT(test, ret, 0); +} + +static struct kunit_case root_device_devm_tests[] =3D { + KUNIT_CASE(root_device_devm_register_unregister_test), + KUNIT_CASE(root_device_devm_register_get_put_unregister_test), + KUNIT_CASE(root_device_devm_register_get_unregister_with_devm_test), + {} +}; + +static struct kunit_suite root_device_devm_test_suite =3D { + .name =3D "root-device-devm", + .test_cases =3D root_device_devm_tests, +}; + +kunit_test_suite(root_device_devm_test_suite); --=20 2.40.1 From nobody Sun May 5 12:12:48 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F412C77B7A for ; Fri, 2 Jun 2023 15:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236590AbjFBPVG (ORCPT ); Fri, 2 Jun 2023 11:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236560AbjFBPU6 (ORCPT ); Fri, 2 Jun 2023 11:20:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6343C1B7; Fri, 2 Jun 2023 08:20:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C89D6635D3; Fri, 2 Jun 2023 15:20:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4EF7C433D2; Fri, 2 Jun 2023 15:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1685719255; bh=4NRmaXZV297pCf/rzgJTExz6ocam8P1xhVXw4bHqhwg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CezCuPSP1yDJ7fqWIjHJEy2EY8N1mLl2hdhNeXNTmTDrBKVoFB77r5WU1ZKkyglbw XykNoFSLRHFAu62ySD2DSe2B0/ybHRQiKmTjyg8akhr8OSrb2Exyxa/17Zhw293Ong 6oA0bZDFkGEaIiyWqEpYCSaxKO/ws6vIKuQ2141KnF5qtt0m+USJDCAL7OQVoF4vga vzWYPsdXpH9rgi4Ae7QptezyWdXCIBAp4xkb7aQuoWSW7BqjanD08gnr1xBM/x6gUX 3FZHKm38GR5SEuwITddtN9pvpjAlU4WBNUErVGiyuT4CVQQ1Mrm1IL6In2MMhOwqXl osFmaqaNkh0aA== From: Maxime Ripard Date: Fri, 02 Jun 2023 17:20:44 +0200 Subject: [PATCH RESEND 2/2] drivers: base: Add basic devm tests for platform devices MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230329-kunit-devm-inconsistencies-test-v1-2-015b1574d673@kernel.org> References: <20230329-kunit-devm-inconsistencies-test-v1-0-015b1574d673@kernel.org> In-Reply-To: <20230329-kunit-devm-inconsistencies-test-v1-0-015b1574d673@kernel.org> To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Brendan Higgins , David Gow , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.13-dev-02a79 X-Developer-Signature: v=1; a=openpgp-sha256; l=9290; i=mripard@kernel.org; h=from:subject:message-id; bh=+upD3Qwmbf0hj4qFxXxO0So+EHopJEk8H+Mz64g5xMs=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDClVHOemsz3e+juBZXYFW6iFbXwQz51YtXPs6p1aSir+7wVf 9md3lLIwiHExyIopssQImy+JOzXrdScb3zyYOaxMIEMYuDgFYCKyAYwMx9sPMRz7yDhRqTjzi9Mv44 WcZ4XX/P3/hGdh06uF70r3qTIy9CbVn75aF6Q+p+DM8X278pX1brY+uHK08sF5l8SZ+slpbAA= X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maxime Ripard Platform devices show some inconsistencies with how devm resources are released when the device has been probed and when it hasn't. Let's add a few tests to exercise thos paths and odd cases. Signed-off-by: Maxime Ripard --- drivers/base/test/Makefile | 1 + drivers/base/test/platform-device-test.c | 278 +++++++++++++++++++++++++++= ++++ 2 files changed, 279 insertions(+) diff --git a/drivers/base/test/Makefile b/drivers/base/test/Makefile index d589ca3fa8fc..e321dfc7e922 100644 --- a/drivers/base/test/Makefile +++ b/drivers/base/test/Makefile @@ -2,6 +2,7 @@ obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE) +=3D test_async_driver_probe.o =20 obj-$(CONFIG_DM_KUNIT_TEST) +=3D root-device-test.o +obj-$(CONFIG_DM_KUNIT_TEST) +=3D platform-device-test.o =20 obj-$(CONFIG_DRIVER_PE_KUNIT_TEST) +=3D property-entry-test.o CFLAGS_property-entry-test.o +=3D $(DISABLE_STRUCTLEAK_PLUGIN) diff --git a/drivers/base/test/platform-device-test.c b/drivers/base/test/p= latform-device-test.c new file mode 100644 index 000000000000..2779c6dfac06 --- /dev/null +++ b/drivers/base/test/platform-device-test.c @@ -0,0 +1,278 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include + +#include +#include + +#define DEVICE_NAME "test" + +struct test_priv { + bool probe_done; + bool release_done; + wait_queue_head_t release_wq; + struct device *dev; +}; + +static void devm_device_action(void *ptr) +{ + struct test_priv *priv =3D ptr; + + priv->release_done =3D true; + wake_up_interruptible(&priv->release_wq); +} + +static void devm_put_device_action(void *ptr) +{ + struct test_priv *priv =3D ptr; + + put_device(priv->dev); + priv->release_done =3D true; + wake_up_interruptible(&priv->release_wq); +} + +#define RELEASE_TIMEOUT_MS 500 + +static void platform_device_devm_register_unregister_test(struct kunit *te= st) +{ + struct platform_device *pdev; + struct test_priv *priv; + int ret; + + priv =3D kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); + init_waitqueue_head(&priv->release_wq); + + pdev =3D platform_device_alloc(DEVICE_NAME, PLATFORM_DEVID_NONE); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + ret =3D platform_device_add(pdev); + KUNIT_ASSERT_EQ(test, ret, 0); + + priv->dev =3D &pdev->dev; + + ret =3D devm_add_action_or_reset(priv->dev, devm_device_action, priv); + KUNIT_ASSERT_EQ(test, ret, 0); + + platform_device_unregister(pdev); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->release_= done, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_EXPECT_GT(test, ret, 0); +} + +static void platform_device_devm_register_get_put_unregister_test(struct k= unit *test) +{ + struct platform_device *pdev; + struct test_priv *priv; + int ret; + + priv =3D kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); + init_waitqueue_head(&priv->release_wq); + + pdev =3D platform_device_alloc(DEVICE_NAME, PLATFORM_DEVID_NONE); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + ret =3D platform_device_add(pdev); + KUNIT_ASSERT_EQ(test, ret, 0); + + priv->dev =3D &pdev->dev; + + get_device(priv->dev); + + ret =3D devm_add_action_or_reset(priv->dev, devm_device_action, priv); + KUNIT_ASSERT_EQ(test, ret, 0); + + put_device(priv->dev); + + platform_device_unregister(pdev); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->release_= done, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_EXPECT_GT(test, ret, 0); +} + +static void platform_device_devm_register_get_unregister_with_devm_test(st= ruct kunit *test) +{ + struct platform_device *pdev; + struct test_priv *priv; + int ret; + + priv =3D kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); + init_waitqueue_head(&priv->release_wq); + + pdev =3D platform_device_alloc(DEVICE_NAME, PLATFORM_DEVID_NONE); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + ret =3D platform_device_add(pdev); + KUNIT_ASSERT_EQ(test, ret, 0); + + priv->dev =3D &pdev->dev; + + get_device(priv->dev); + + ret =3D devm_add_action_or_reset(priv->dev, devm_put_device_action, priv); + KUNIT_ASSERT_EQ(test, ret, 0); + + platform_device_unregister(pdev); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->release_= done, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_EXPECT_GT(test, ret, 0); +} + +static int fake_probe(struct platform_device *pdev) +{ + struct test_priv *priv =3D platform_get_drvdata(pdev); + + priv->probe_done =3D true; + wake_up_interruptible(&priv->release_wq); + + return 0; +} + +static struct platform_driver fake_driver =3D { + .probe =3D fake_probe, + .driver =3D { + .name =3D DEVICE_NAME, + }, +}; + +static void probed_platform_device_devm_register_unregister_test(struct ku= nit *test) +{ + struct platform_device *pdev; + struct test_priv *priv; + int ret; + + priv =3D kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); + init_waitqueue_head(&priv->release_wq); + + ret =3D platform_driver_register(&fake_driver); + KUNIT_ASSERT_EQ(test, ret, 0); + + pdev =3D platform_device_alloc(DEVICE_NAME, PLATFORM_DEVID_NONE); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + priv->dev =3D &pdev->dev; + platform_set_drvdata(pdev, priv); + + ret =3D platform_device_add(pdev); + KUNIT_ASSERT_EQ(test, ret, 0); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->probe_do= ne, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_ASSERT_GT(test, ret, 0); + + ret =3D devm_add_action_or_reset(priv->dev, devm_device_action, priv); + KUNIT_ASSERT_EQ(test, ret, 0); + + platform_device_unregister(pdev); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->release_= done, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_EXPECT_GT(test, ret, 0); + + platform_driver_unregister(&fake_driver); +} + +static void probed_platform_device_devm_register_get_put_unregister_test(s= truct kunit *test) +{ + struct platform_device *pdev; + struct test_priv *priv; + int ret; + + priv =3D kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); + init_waitqueue_head(&priv->release_wq); + + ret =3D platform_driver_register(&fake_driver); + KUNIT_ASSERT_EQ(test, ret, 0); + + pdev =3D platform_device_alloc(DEVICE_NAME, PLATFORM_DEVID_NONE); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + priv->dev =3D &pdev->dev; + platform_set_drvdata(pdev, priv); + + ret =3D platform_device_add(pdev); + KUNIT_ASSERT_EQ(test, ret, 0); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->probe_do= ne, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_ASSERT_GT(test, ret, 0); + + get_device(priv->dev); + + ret =3D devm_add_action_or_reset(priv->dev, devm_device_action, priv); + KUNIT_ASSERT_EQ(test, ret, 0); + + put_device(priv->dev); + + platform_device_unregister(pdev); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->release_= done, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_EXPECT_GT(test, ret, 0); + + platform_driver_unregister(&fake_driver); +} + +static void probed_platform_device_devm_register_get_unregister_with_devm_= test(struct kunit *test) +{ + struct platform_device *pdev; + struct test_priv *priv; + int ret; + + priv =3D kunit_kzalloc(test, sizeof(*priv), GFP_KERNEL); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, priv); + init_waitqueue_head(&priv->release_wq); + + ret =3D platform_driver_register(&fake_driver); + KUNIT_ASSERT_EQ(test, ret, 0); + + pdev =3D platform_device_alloc(DEVICE_NAME, PLATFORM_DEVID_NONE); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + priv->dev =3D &pdev->dev; + platform_set_drvdata(pdev, priv); + + ret =3D platform_device_add(pdev); + KUNIT_ASSERT_EQ(test, ret, 0); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->probe_do= ne, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_ASSERT_GT(test, ret, 0); + + get_device(priv->dev); + + ret =3D devm_add_action_or_reset(priv->dev, devm_put_device_action, priv); + KUNIT_ASSERT_EQ(test, ret, 0); + + platform_device_unregister(pdev); + + ret =3D wait_event_interruptible_timeout(priv->release_wq, priv->release_= done, + msecs_to_jiffies(RELEASE_TIMEOUT_MS)); + KUNIT_EXPECT_GT(test, ret, 0); + + platform_driver_unregister(&fake_driver); +} + +static struct kunit_case platform_device_devm_tests[] =3D { + KUNIT_CASE(platform_device_devm_register_unregister_test), + KUNIT_CASE(platform_device_devm_register_get_put_unregister_test), + KUNIT_CASE(platform_device_devm_register_get_unregister_with_devm_test), + KUNIT_CASE(probed_platform_device_devm_register_unregister_test), + KUNIT_CASE(probed_platform_device_devm_register_get_put_unregister_test), + KUNIT_CASE(probed_platform_device_devm_register_get_unregister_with_devm_= test), + {} +}; + +static struct kunit_suite platform_device_devm_test_suite =3D { + .name =3D "platform-device-devm", + .test_cases =3D platform_device_devm_tests, +}; + +kunit_test_suite(platform_device_devm_test_suite); --=20 2.40.1