From nobody Sun May 5 20:20:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F115AC76195 for ; Tue, 28 Mar 2023 07:34:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232355AbjC1Hen (ORCPT ); Tue, 28 Mar 2023 03:34:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232127AbjC1HeR (ORCPT ); Tue, 28 Mar 2023 03:34:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E61740D1 for ; Tue, 28 Mar 2023 00:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679988799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3RKROZr4GzDPgqMOFWqSLDrRs2RHwcu0c+oEbFcDZ1s=; b=VXLxhGwmdRMsdQ5YLXj/5mWi/XBO22/+EIiJ/GDTKvAHpnW5+rDn3S7rak9Ils/OnODCT7 jXlFRJkKJ+2aBYPMtyXUyeJWSS6nR/iPtWpObpFGB3cTp2uqIGSV7B04fMVhRwEZarZBJp rrYFw9MO9cS+ULOxXaa02BNTokD45Cs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-638-fTb0YieTMtCcuiRcoYXFtg-1; Tue, 28 Mar 2023 03:33:18 -0400 X-MC-Unique: fTb0YieTMtCcuiRcoYXFtg-1 Received: by mail-wm1-f72.google.com with SMTP id m5-20020a05600c4f4500b003ee8db23ef9so6681857wmq.8 for ; Tue, 28 Mar 2023 00:33:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679988796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3RKROZr4GzDPgqMOFWqSLDrRs2RHwcu0c+oEbFcDZ1s=; b=wT2l+sRbKDw9MF3yy1xz8UAZMj8vKXO6o7Bv+rSvJajMpv1Unj5Ty5+r47kcAeOCzh uUlzMIvGx4UkNqUelZuMVmJY8KwrDv2d9j8U6f+7v91vE7nEjBX5nqrl0kCL1JB++fxe yJDr7iphzzOfYOo00tDuc6yR5LsRsoN77VfxmAeE7OBcNCjlTXoAauWfpEgCscIN+i+e mjdGCtDXMNmFRfNe15nIBJljyN732EGQw2reukeu7sReDYoO7s64/tY7QzhJClOE2JN6 XITDxllrmDiitcftjTwYZfe9seOghW5nkANpwysC/hQOHQ2cYr5fp0dGJUaLmfw/crDR c5zA== X-Gm-Message-State: AO0yUKUmw6Kn9Q89crgh59VmX036Bwv7k6R1BkvFlT6zNG6W8LQ2Ow7V IF9uzbRMUjdQvGP3Bc0gfJrPGKVc5s0T0yO6UnKQ26wEFhSMNgDbDdLmb0pwyYpwEhlgpwgBTwB OyZs7BoDc52uJQYAphiiDL5KPIbg4oWf7/vUJJT9pH+nI9CdKDC+hVaHfIRI1ztT23MIlSO8LDL Fdqwvwf6M= X-Received: by 2002:a05:600c:287:b0:3ed:cc22:23db with SMTP id 7-20020a05600c028700b003edcc2223dbmr11833342wmk.3.1679988796701; Tue, 28 Mar 2023 00:33:16 -0700 (PDT) X-Google-Smtp-Source: AK7set+E7Hunz2KKt4RZvQ903yvOLNFadeK9bEOzN8DCEVH3HEHCePFn8XpKOb8OMCb77RgGdWB2qw== X-Received: by 2002:a05:600c:287:b0:3ed:cc22:23db with SMTP id 7-20020a05600c028700b003edcc2223dbmr11833309wmk.3.1679988796327; Tue, 28 Mar 2023 00:33:16 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id j6-20020a05600c190600b003ef6bc71cccsm7527075wmq.27.2023.03.28.00.33.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 00:33:16 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Peter Robinson , Tom , Robert Mader , Laurent Pinchart , Martijn Braam , Ondrej Jirman , Jacopo Mondi , =?UTF-8?q?Kamil=20Trzci=C5=84ski?= , Javier Martinez Canillas , Heiko Stuebner , Jarrah Gosbell , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v3 1/2] arm64: dts: rk3399-pinephone-pro: Add internal display support Date: Tue, 28 Mar 2023 09:33:08 +0200 Message-Id: <20230328073309.1743112-2-javierm@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230328073309.1743112-1-javierm@redhat.com> References: <20230328073309.1743112-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Martijn Braam The phone's display is using a Hannstar LCD panel. Support it by adding a panel DT node and all needed nodes (backlight, MIPI DSI, regulators, etc). Signed-off-by: Martijn Braam Co-developed-by: Kamil Trzci=C5=84ski Signed-off-by: Kamil Trzci=C5=84ski Co-developed-by: Ondrej Jirman Signed-off-by: Ondrej Jirman Signed-off-by: Javier Martinez Canillas Tested-by: Ondrej Jirman --- Changes in v3: - Fix some ./scripts/checkpatch.pl --strict warnings. - Add Ondrej Jirman Tested-by tag. - Change PWM period to 50000 since 20 kHz is recommended (Ondrej Jirman). - Remove useless comments for the panel regulators (Ondrej Jirman). - Drop unneeded pinctrl pull down conf for pins that either already have a pull-down resistor or are already driven by the SoC (Ondrej Jirman). - Remove "pwm-delay-us" property not supported in mainline (Ondrej Jirman). Changes in v2: - Drop touchscreen node because used the wrong compatible (Ondrej Jirman). - Fix assigned-clock-parents in vopb node (Ondrej Jirman). - Add vopl and vopl nodes. .../dts/rockchip/rk3399-pinephone-pro.dts | 95 +++++++++++++++++++ 1 file changed, 95 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index a0795a2b1cb1..539b36e8bff5 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -29,6 +29,11 @@ chosen { stdout-path =3D "serial2:115200n8"; }; =20 + backlight: backlight { + compatible =3D "pwm-backlight"; + pwms =3D <&pwm0 0 50000 0>; + }; + gpio-keys { compatible =3D "gpio-keys"; pinctrl-names =3D "default"; @@ -102,6 +107,30 @@ wifi_pwrseq: sdio-wifi-pwrseq { /* WL_REG_ON on module */ reset-gpios =3D <&gpio0 RK_PB2 GPIO_ACTIVE_LOW>; }; + + /* MIPI DSI panel 1.8v supply */ + vcc1v8_lcd: vcc1v8-lcd { + compatible =3D "regulator-fixed"; + enable-active-high; + regulator-name =3D "vcc1v8_lcd"; + regulator-min-microvolt =3D <1800000>; + regulator-max-microvolt =3D <1800000>; + vin-supply =3D <&vcc3v3_sys>; + gpio =3D <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>; + pinctrl-names =3D "default"; + }; + + /* MIPI DSI panel 2.8v supply */ + vcc2v8_lcd: vcc2v8-lcd { + compatible =3D "regulator-fixed"; + enable-active-high; + regulator-name =3D "vcc2v8_lcd"; + regulator-min-microvolt =3D <2800000>; + regulator-max-microvolt =3D <2800000>; + vin-supply =3D <&vcc3v3_sys>; + gpio =3D <&gpio3 RK_PA1 GPIO_ACTIVE_HIGH>; + pinctrl-names =3D "default"; + }; }; =20 &cpu_alert0 { @@ -139,6 +168,11 @@ &emmc_phy { status =3D "okay"; }; =20 +&gpu { + mali-supply =3D <&vdd_gpu>; + status =3D "okay"; +}; + &i2c0 { clock-frequency =3D <400000>; i2c-scl-rising-time-ns =3D <168>; @@ -362,6 +396,39 @@ &io_domains { status =3D "okay"; }; =20 +&mipi_dsi { + status =3D "okay"; + clock-master; + + ports { + mipi_out: port@1 { + #address-cells =3D <0>; + #size-cells =3D <0>; + reg =3D <1>; + + mipi_out_panel: endpoint { + remote-endpoint =3D <&mipi_in_panel>; + }; + }; + }; + + panel@0 { + compatible =3D "hannstar,hsd060bhw4"; + reg =3D <0>; + backlight =3D <&backlight>; + reset-gpios =3D <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>; + vcc-supply =3D <&vcc2v8_lcd>; + iovcc-supply =3D <&vcc1v8_lcd>; + pinctrl-names =3D "default"; + + port { + mipi_in_panel: endpoint { + remote-endpoint =3D <&mipi_out_panel>; + }; + }; + }; +}; + &pmu_io_domains { pmu1830-supply =3D <&vcc_1v8>; status =3D "okay"; @@ -429,6 +496,10 @@ &sdio0 { status =3D "okay"; }; =20 +&pwm0 { + status =3D "okay"; +}; + &sdmmc { bus-width =3D <4>; cap-sd-highspeed; @@ -479,3 +550,27 @@ bluetooth { &uart2 { status =3D "okay"; }; + +&vopb { + status =3D "okay"; + assigned-clocks =3D <&cru DCLK_VOP0_DIV>, <&cru DCLK_VOP0>, + <&cru ACLK_VOP0>, <&cru HCLK_VOP0>; + assigned-clock-rates =3D <0>, <0>, <400000000>, <100000000>; + assigned-clock-parents =3D <&cru PLL_GPLL>, <&cru DCLK_VOP0_DIV>; +}; + +&vopb_mmu { + status =3D "okay"; +}; + +&vopl { + status =3D "okay"; + assigned-clocks =3D <&cru DCLK_VOP1_DIV>, <&cru DCLK_VOP1>, + <&cru ACLK_VOP1>, <&cru HCLK_VOP1>; + assigned-clock-rates =3D <0>, <0>, <400000000>, <100000000>; + assigned-clock-parents =3D <&cru PLL_GPLL>, <&cru DCLK_VOP1_DIV>; +}; + +&vopl_mmu { + status =3D "okay"; +}; --=20 2.40.0 From nobody Sun May 5 20:20:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04467C77B60 for ; Tue, 28 Mar 2023 07:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232428AbjC1He5 (ORCPT ); Tue, 28 Mar 2023 03:34:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjC1HeP (ORCPT ); Tue, 28 Mar 2023 03:34:15 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF9C135A5 for ; Tue, 28 Mar 2023 00:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679988800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nNdM7KSyRgCrr4mbIGjnmBDUe48JVTbvN2evKlFTHYo=; b=f41Ho/HE/6AR+eNMByiUdffxM3nSOt/4aKn9kGWPk8ZMOgfkeVsYAmS2XoMfed9/pZTrmE 085ZFHGYmeE+4PSCs0AOqLjG1szVU/rLcllJBEIqykHRjZFfw8b71c7e0OreFMqFnnmUZH x8ZqXmIeM8VtQhaQ3xgYG917FfqynT4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-295-4iKo5mxyMeKxmij-_ygjgg-1; Tue, 28 Mar 2023 03:33:19 -0400 X-MC-Unique: 4iKo5mxyMeKxmij-_ygjgg-1 Received: by mail-wm1-f72.google.com with SMTP id q21-20020a05600c46d500b003ee570749f7so5979397wmo.7 for ; Tue, 28 Mar 2023 00:33:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679988798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nNdM7KSyRgCrr4mbIGjnmBDUe48JVTbvN2evKlFTHYo=; b=rHXI6khunStqdekIZFTengT4WLdWd77DY1Ql7xd5RrIH1Vp/bbzYOJzc3zVn82qqHN 72kiQBh8Z3gnM35V+f/713OJEGK0vQzwxnk9fro9gjrScyiduRSLakgCPF+g0MjPBFXU unOf2icSn6ci/VT5DtVOakp0Px8/25PmI+vqP+16M3vwID3zhHlJKZuct5QtVzAPpYMY +dVBzlew6FC/2rD2zLZVt+pohuhhU4WayaBhsM3kky8aMQkw1OJudjwWRhR6aqU6NNA+ 2dy/IVOvwJPanBRWxWMjCDfKQXf8zcNAWkPMSfO07tsfbwmRP9ahQAlSnjOzLr/SQ7No Nqtw== X-Gm-Message-State: AO0yUKWqlWgoOt6manXwEAH4Jg95ekoivjdTF976tx7WFX1XQpoHKJpS OhKxgIjrwwQKAtIVXB0RVlViK5V6gsnNDo9MWLkAfaFCUhbKIi0zweUH2n3Cz/gUtqHZHyafmj7 bROulBWEPXToB0asnQluoh65P6BR9OMmk+ebGD3GFtN0eXlhn9RGMh40DEGIJzsLMe1q3Es4FMM rEP5/Mipg= X-Received: by 2002:a05:600c:c6:b0:3ef:df3:1693 with SMTP id u6-20020a05600c00c600b003ef0df31693mr11393770wmm.32.1679988798138; Tue, 28 Mar 2023 00:33:18 -0700 (PDT) X-Google-Smtp-Source: AK7set98gCyXpnG4Ha5cE59btAVfSKxfqXI1RJYKrRZnSKKWGrx+Oi6U2VNaI7A9EVKO8nI+cTTlEQ== X-Received: by 2002:a05:600c:c6:b0:3ef:df3:1693 with SMTP id u6-20020a05600c00c600b003ef0df31693mr11393735wmm.32.1679988797783; Tue, 28 Mar 2023 00:33:17 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id j6-20020a05600c190600b003ef6bc71cccsm7527075wmq.27.2023.03.28.00.33.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Mar 2023 00:33:17 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Peter Robinson , Tom , Robert Mader , Laurent Pinchart , Martijn Braam , Ondrej Jirman , Jacopo Mondi , =?UTF-8?q?Kamil=20Trzci=C5=84ski?= , Javier Martinez Canillas , Caleb Connolly , Heiko Stuebner , Jarrah Gosbell , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v3 2/2] arm64: dts: rk3399-pinephone-pro: Add touchscreen support Date: Tue, 28 Mar 2023 09:33:09 +0200 Message-Id: <20230328073309.1743112-3-javierm@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230328073309.1743112-1-javierm@redhat.com> References: <20230328073309.1743112-1-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Martijn Braam The phone has a Goodix GT1158 touchscreen, add a DT node for it. Signed-off-by: Martijn Braam Co-developed-by: Kamil Trzci=C5=84ski Signed-off-by: Kamil Trzci=C5=84ski Co-developed-by: Ondrej Jirman Signed-off-by: Ondrej Jirman Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Use the correct "goodix,gt1158" compatible string (Ondrej Jirman). - Remove "poweroff-in-suspend" not supported in mainline (Ondrej Jirman). .../dts/rockchip/rk3399-pinephone-pro.dts | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts b/arch/a= rm64/boot/dts/rockchip/rk3399-pinephone-pro.dts index 539b36e8bff5..475ba78acc09 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts @@ -367,6 +367,25 @@ regulator-state-mem { }; }; =20 +&i2c3 { + i2c-scl-rising-time-ns =3D <450>; + i2c-scl-falling-time-ns =3D <15>; + status =3D "okay"; + + touchscreen@14 { + compatible =3D "goodix,gt1158"; + reg =3D <0x14>; + interrupt-parent =3D <&gpio3>; + interrupts =3D ; + irq-gpios =3D <&gpio3 RK_PB5 GPIO_ACTIVE_HIGH>; + reset-gpios =3D <&gpio3 RK_PB4 GPIO_ACTIVE_HIGH>; + AVDD28-supply =3D <&vcc3v0_touch>; + VDDIO-supply =3D <&vcc3v0_touch>; + touchscreen-size-x =3D <720>; + touchscreen-size-y =3D <1440>; + }; +}; + &cluster0_opp { opp04 { status =3D "disabled"; --=20 2.40.0