From nobody Sun Feb 8 17:46:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 972D6C76195 for ; Mon, 27 Mar 2023 09:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232689AbjC0JtA (ORCPT ); Mon, 27 Mar 2023 05:49:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231740AbjC0Jsy (ORCPT ); Mon, 27 Mar 2023 05:48:54 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3716E1984 for ; Mon, 27 Mar 2023 02:48:53 -0700 (PDT) Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32R8IUGG005717; Mon, 27 Mar 2023 11:48:35 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=selector1; bh=WYV7EBAofXJyjzZBSfwpOR5v4z00FX931Kh4b0ja95g=; b=mSHycwxz/M4wDaKtWXw9Z3IVed4FlmVQ6GoYzw7//rWelMxMz/3+WMymg3WmLLdpcwnT qzDFPsw27345E3DOOIHlgJExjay4+sKlpH1dM9L51UZHMwwtudOVC9UBMI+qowmYthhU foXNNIoj4MMKnGq+Bu9jp8vySRWt0BJKdCLjsmcqICfSi4ae1n7D5dRkNoIEkNgKHwOi AdiNbJMId8s6KKCD1+ZuaIC0KtN9ejKIteBlJ4kFoa5xG22gzfsPXi4bdh8AmdC6B9SU j4XI+MLcyP4jTLrEnBoKtHOlblQaOq/X49kbN623WINryfOHdWP7zIU2SopDktwLwiWd vA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3phsr59ygq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Mar 2023 11:48:35 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4DC9D10002A; Mon, 27 Mar 2023 11:48:35 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 481C6212FAB; Mon, 27 Mar 2023 11:48:35 +0200 (CEST) Received: from localhost (10.48.0.175) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 27 Mar 2023 11:48:35 +0200 From: Christophe Kerello To: , , CC: , , , Christophe Kerello Subject: [PATCH v2 1/2] mtd: rawnand: stm32_fmc2: do not support EDO mode Date: Mon, 27 Mar 2023 11:47:41 +0200 Message-ID: <20230327094742.38856-2-christophe.kerello@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230327094742.38856-1-christophe.kerello@foss.st.com> References: <20230327094742.38856-1-christophe.kerello@foss.st.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.48.0.175] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-24_01,2023-02-09_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" FMC2 controller does not support EDO mode (timings mode 4 and 5). Signed-off-by: Christophe Kerello Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash c= ontroller driver") Reviewed-by: Tudor Ambarus --- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/= stm32_fmc2_nand.c index 5d627048c420..3abb63d00a0b 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct nand= _chip *chip, int chipnr, if (IS_ERR(sdrt)) return PTR_ERR(sdrt); =20 + if (sdrt->tRC_min < 30000) + return -EOPNOTSUPP; + if (chipnr =3D=3D NAND_DATA_IFACE_CHECK_ONLY) return 0; =20 --=20 2.25.1 From nobody Sun Feb 8 17:46:57 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B41BC7619A for ; Mon, 27 Mar 2023 09:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232744AbjC0JtC (ORCPT ); Mon, 27 Mar 2023 05:49:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231196AbjC0Jsz (ORCPT ); Mon, 27 Mar 2023 05:48:55 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13264272C for ; Mon, 27 Mar 2023 02:48:53 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32R9EokW009540; Mon, 27 Mar 2023 11:48:39 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=selector1; bh=qc0y4lAt9GdcmkSaVA/yJM1SimYJoRCkG1QZdOU2rfQ=; b=6LhYbiINfXFB2MQn17wpiu3dm3tvDMi40VQ4E/3J/lraYCIYhNZH35mJ36t5W6zsTlpt sQ1fLf9C5tf8BKjzq8CXOyOSEItC8Rb3k+2FygHfQvvfHL18Zz21tzhslGbORadQlLIh 4soVMbdVNeifyvs4WzRG68KyEW6GFg1xhfsl7z1gtYuI+be0KuGVgtqB0w+Js7187/ns FCU56LujAdTzHxONjVVLJKFjbuQtT4uRtHGCvDmIZWhohILZdTMBYloHaqn+NdDZxkHW I7wcNHj6JRSG8MSMst56OwRHogoWQv6dq+5Hgo28qx2SnPgW96R2c3cYZ1HhLVi/1695 IQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3pk5xk9fvu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Mar 2023 11:48:39 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id C5F0A10002A; Mon, 27 Mar 2023 11:48:38 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C0701212FAC; Mon, 27 Mar 2023 11:48:38 +0200 (CEST) Received: from localhost (10.48.0.175) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 27 Mar 2023 11:48:38 +0200 From: Christophe Kerello To: , , CC: , , , Christophe Kerello Subject: [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min Date: Mon, 27 Mar 2023 11:47:42 +0200 Message-ID: <20230327094742.38856-3-christophe.kerello@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230327094742.38856-1-christophe.kerello@foss.st.com> References: <20230327094742.38856-1-christophe.kerello@foss.st.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.48.0.175] X-ClientProxiedBy: EQNCAS1NODE4.st.com (10.75.129.82) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-24_11,2023-03-24_01,2023-02-09_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch is using timings.mode value instead of checking tRC_min timing for EDO mode support. Signed-off-by: Christophe Kerello Reviewed-by: Tudor Ambarus --- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/= stm32_fmc2_nand.c index 3abb63d00a0b..9e74bcd90aaa 100644 --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand= _chip *chip, int chipnr, if (IS_ERR(sdrt)) return PTR_ERR(sdrt); =20 - if (sdrt->tRC_min < 30000) + if (conf->timings.mode > 3) return -EOPNOTSUPP; =20 if (chipnr =3D=3D NAND_DATA_IFACE_CHECK_ONLY) --=20 2.25.1