From nobody Mon Feb 9 10:28:29 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5596BC761AF for ; Mon, 27 Mar 2023 03:46:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232100AbjC0DqB (ORCPT ); Sun, 26 Mar 2023 23:46:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjC0Dp6 (ORCPT ); Sun, 26 Mar 2023 23:45:58 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 559D93C31 for ; Sun, 26 Mar 2023 20:45:56 -0700 (PDT) Received: from dggpemm500006.china.huawei.com (unknown [172.30.72.55]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PlJby6q14zL66b; Mon, 27 Mar 2023 11:45:02 +0800 (CST) Received: from thunder-town.china.huawei.com (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 27 Mar 2023 11:45:29 +0800 From: Zhen Lei To: Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , , , CC: Zhen Lei Subject: [PATCH] kmsan: fix a stale comment in kmsan_save_stack_with_flags() Date: Mon, 27 Mar 2023 11:41:49 +0800 Message-ID: <20230327034149.942-1-thunder.leizhen@huawei.com> X-Mailer: git-send-email 2.37.3.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After commit 446ec83805dd ("mm/page_alloc: use might_alloc()") and commit 84172f4bb752 ("mm/page_alloc: combine __alloc_pages and __alloc_pages_nodemask"), the comment is no longer accurate. Flag '__GFP_DIRECT_RECLAIM' is clear enough on its own, so remove the comment rather than update it. Signed-off-by: Zhen Lei Reviewed-by: Alexander Potapenko --- mm/kmsan/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kmsan/core.c b/mm/kmsan/core.c index f710257d68670ee..7d1e4aa30bae622 100644 --- a/mm/kmsan/core.c +++ b/mm/kmsan/core.c @@ -73,7 +73,7 @@ depot_stack_handle_t kmsan_save_stack_with_flags(gfp_t fl= ags, =20 nr_entries =3D stack_trace_save(entries, KMSAN_STACK_DEPTH, 0); =20 - /* Don't sleep (see might_sleep_if() in __alloc_pages_nodemask()). */ + /* Don't sleep. */ flags &=3D ~__GFP_DIRECT_RECLAIM; =20 handle =3D __stack_depot_save(entries, nr_entries, flags, true); --=20 2.25.1