From nobody Mon May 6 01:10:16 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD0B0C6FD1C for ; Sat, 25 Mar 2023 16:42:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231681AbjCYQmx (ORCPT ); Sat, 25 Mar 2023 12:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231522AbjCYQmv (ORCPT ); Sat, 25 Mar 2023 12:42:51 -0400 Received: from bgl-iport-3.cisco.com (bgl-iport-3.cisco.com [72.163.197.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0179EC42; Sat, 25 Mar 2023 09:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1564; q=dns/txt; s=iport; t=1679762570; x=1680972170; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=jXwmHBkZwD6FXbeoybFbsEbinYtApBspwJP2EDwlSEo=; b=aVp2u7qsvs5HgdTt4QdXSulZ5Rnofx9xYdWzmzJMhHtMqOoks9ptGjjD 9HdJlK05jpe3Y3dy1/10zW8cJczaLQWCCkhpGrd1FpVMyMp/6vm7Ll7Vn CMjsj1CAoyNuqtZIQKIlRLfWodeBUh+OOWGPpOPElxkWlXOFWBS2lYpP2 M=; X-IronPort-AV: E=Sophos;i="5.98,290,1673913600"; d="scan'208";a="9163683" Received: from vla196-nat.cisco.com (HELO bgl-core-3.cisco.com) ([72.163.197.24]) by bgl-iport-3.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 25 Mar 2023 16:42:46 +0000 Received: from bgl-ads-3583.cisco.com (bgl-ads-3583.cisco.com [173.39.60.220]) by bgl-core-3.cisco.com (8.15.2/8.15.2) with ESMTPS id 32PGgkFr013150 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 25 Mar 2023 16:42:46 GMT Received: by bgl-ads-3583.cisco.com (Postfix, from userid 1784405) id 618CCCC1296; Sat, 25 Mar 2023 22:12:46 +0530 (IST) From: Shinu Chandran To: richardcochran@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Shinu Chandran Subject: [PATCH] ptp: ptp_clock: Fix coding style issues in ptp_clock Date: Sat, 25 Mar 2023 22:12:32 +0530 Message-Id: <20230325164232.2434190-1-shinucha@cisco.com> X-Mailer: git-send-email 2.35.6 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Outbound-SMTP-Client: 173.39.60.220, bgl-ads-3583.cisco.com X-Outbound-Node: bgl-core-3.cisco.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Fixed coding style issues in ptp_clock.c Signed-off-by: Shinu Chandran --- drivers/ptp/ptp_clock.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index 62d4d29e7c05..8fe7f2ce9705 100644 --- a/drivers/ptp/ptp_clock.c +++ b/drivers/ptp/ptp_clock.c @@ -129,6 +129,7 @@ static int ptp_clock_adjtime(struct posix_clock *pc, st= ruct __kernel_timex *tx) err =3D ops->adjtime(ops, delta); } else if (tx->modes & ADJ_FREQUENCY) { long ppb =3D scaled_ppm_to_ppb(tx->freq); + if (ppb > ops->max_adj || ppb < -ops->max_adj) return -ERANGE; err =3D ops->adjfine(ops, tx->freq); @@ -278,11 +279,13 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock= _info *info, /* Register a new PPS source. */ if (info->pps) { struct pps_source_info pps; + memset(&pps, 0, sizeof(pps)); snprintf(pps.name, PPS_MAX_NAME_LEN, "ptp%d", index); pps.mode =3D PTP_PPS_MODE; pps.owner =3D info->owner; ptp->pps_source =3D pps_register_source(&pps, PTP_PPS_DEFAULTS); + if (IS_ERR(ptp->pps_source)) { err =3D PTR_ERR(ptp->pps_source); pr_err("failed to register pps source\n"); @@ -347,9 +350,8 @@ static int unregister_vclock(struct device *dev, void *= data) =20 int ptp_clock_unregister(struct ptp_clock *ptp) { - if (ptp_vclock_in_use(ptp)) { + if (ptp_vclock_in_use(ptp)) device_for_each_child(&ptp->dev, NULL, unregister_vclock); - } =20 ptp->defunct =3D 1; wake_up_interruptible(&ptp->tsev_wq); --=20 2.35.6